From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34F3BC7EE31 for ; Fri, 27 Jun 2025 14:24:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LPZ3O5Rwvq89lmi7xpDufo5YrwcKeIrsD6dbAjMTens=; b=mJKRb+g0pYoWDeu0wSs1hH5SRq n421JvztOge3xo5LwG3LW0hluyXC16jEKZUAhZDzEV13KrxOrv3vcEF//5WFaQIIiTED20DCh0VlR 5pCZXgzi9qoFta92TQ1WWMWy7mqSLuGeZXaCyXUmv++yKe1sD4AWOp+vLe+7h7KotmHPH7QE7QCwV ROHIf64KkQuQ/TwUMqchtIdZMPPeQI54ntp/lVdRtlnaIG2CKBlW3DmKoeKOiqZdKi9Bov0KasY/g uxLW7WwBBPODcPOq+zhCXehkM1mo+9EKv1/J+3DViyZQO/8MAEVHo0lgIqepFhtVKZOf2X5BT68np M4ZHe5dQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uVA0N-0000000EuDQ-3MjT; Fri, 27 Jun 2025 14:24:39 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uV9uj-0000000Esqj-05hB for linux-arm-kernel@lists.infradead.org; Fri, 27 Jun 2025 14:18:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 23AFE6111F; Fri, 27 Jun 2025 14:18:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA384C4CEE3; Fri, 27 Jun 2025 14:18:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751033927; bh=TaiQW3c+noRyzXQvsLousUbpwR3hV32c+YniAy5VZUU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JMFvBsxh25QJ2POJpnOoSHcIiORn+haen7v9wCSZAqbRWEWR8rp168/xP5JajxRet ABSMKTjuxgMOqYpqxHoeQAIY1ZO/1qnNPS1mZwEAmC6ZGJ+7oPy6aIr9chIwI3mMzx 1LwQNtcBxXDKjAqya0P7p7/blBNf1PY42VO6WrZJIuY+dkKjUMVR2n25EtXJNAYBR9 AXfHsrTv4FYdFOr/WwX1bKOOoWsBgt46qpWbERDFD3NLDjmQReTG1ZBzJlC2KUu2aT lgwUVSvQu451wB1EMcCCl1itmRUz/iFxcC0/eMTNQtR8zSTF1A1AGP4bgUwFaT/d6Y QSo2Oo2lIP7sA== Date: Fri, 27 Jun 2025 09:18:46 -0500 From: Rob Herring To: Herve Codina Cc: Andrew Lunn , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Michael Turquette , Stephen Boyd , Andi Shyti , Wolfram Sang , Peter Rosin , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , Bjorn Helgaas , Mark Brown , Len Brown , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Wolfram Sang , Geert Uytterhoeven , Davidlohr Bueso , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Dan Williams , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, linux-spi@vger.kernel.org, linux-acpi@vger.kernel.org, linux-cxl@vger.kernel.org, Allan Nielsen , Horatiu Vultur , Steen Hegelund , Luca Ceresoli , Thomas Petazzoni Subject: Re: [PATCH v3 02/28] driver core: Rename get_dev_from_fwnode() wrapper to get_device_from_fwnode() Message-ID: <20250627141846.GA3234475-robh@kernel.org> References: <20250613134817.681832-1-herve.codina@bootlin.com> <20250613134817.681832-3-herve.codina@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250613134817.681832-3-herve.codina@bootlin.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 13, 2025 at 03:47:42PM +0200, Herve Codina wrote: > get_dev_from_fwnode() calls get_device() and so it acquires a reference > on the device returned. > > In order to be more obvious that this wrapper is a get_device() variant, > rename it to get_device_from_fwnode(). > > Suggested-by: Mark Brown > Link: https://lore.kernel.org/lkml/CAGETcx97QjnjVR8Z5g0ndLHpK96hLd4aYSV=iEkKPNbNOccYmA@mail.gmail.com/ > Signed-off-by: Herve Codina > Reviewed-by: Andy Shevchenko > Reviewed-by: Saravana Kannan > Reviewed-by: Luca Ceresoli > --- > drivers/base/core.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index cbc0099d8ef2..36ccee91ba9a 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -1881,7 +1881,7 @@ static void fw_devlink_unblock_consumers(struct device *dev) > device_links_write_unlock(); > } > > -#define get_dev_from_fwnode(fwnode) get_device((fwnode)->dev) > +#define get_device_from_fwnode(fwnode) get_device((fwnode)->dev) In patch 3, you add the same define. Is there some reason to not move it to a header? Rob