Re: [GIT PULL 4/5] Broadcom drivers changes for 6.17

Andrea della Porta
2025-07-01T10:12:24Z

Hi Greg,

On 07:11 Tue 01 Jul , Greg Kroah-Hartman wrote:
> On Mon, Jun 30, 2025 at 12:02:15PM -0700, Florian Fainelli wrote:
> > The following changes since commit 19272b37aa4f83ca52bdf9c16d5d81bdd1354494:
> >
> > Linux 6.16-rc1 (2025-06-08 13:44:43 -0700)
> >
> > are available in the Git repository at:
> >
> > https://github.com/Broadcom/stblinux.git tags/arm-soc/for-6.17/drivers
> >
> > for you to fetch changes up to e3ce7b897388339b407d57969acaa26063e38209:
> >
> > pinctrl: rp1: Implement RaspberryPi RP1 pinmux/pinconf support (2025-06-25 12:08:56 -0700)
> >
> > ----------------------------------------------------------------
> > This pull request contains Broadcom SoCs drivers updates for 6.17,
> > please pull the following:
> >
> > - Andrea adds the RP1 clock, pinctrl/pinconf/gpio and misc driver to
> > bind them all
> >
> > ----------------------------------------------------------------
> > Andrea della Porta (5):
> > dt-bindings: clock: Add RaspberryPi RP1 clock bindings
> > clk: rp1: Add support for clocks provided by RP1
> > pinctrl: rp1: Implement RaspberryPi RP1 gpio support
> > misc: rp1: RaspberryPi RP1 misc driver
> > pinctrl: rp1: Implement RaspberryPi RP1 pinmux/pinconf support
> >
> > .../bindings/clock/raspberrypi,rp1-clocks.yaml | 58 +
> > drivers/clk/Kconfig | 9 +
> > drivers/clk/Makefile | 1 +
> > drivers/clk/clk-rp1.c | 1494 ++++++++++++++++
> > drivers/misc/Kconfig | 1 +
> > drivers/misc/Makefile | 1 +
> > drivers/misc/rp1/Kconfig | 20 +
> > drivers/misc/rp1/Makefile | 3 +
> > drivers/misc/rp1/rp1-pci.dtso | 25 +
> > drivers/misc/rp1/rp1_pci.c | 333 ++++
>
> Any chance to actually review this code before you throw it under a
> different maintainer's responsibility?
>
> And what's wrong with patches, why a pull request here?

Since the patchset is spanning several subsystems and some file
dependencies were shared between maintainers, Florian was so kind
to funnell all patches through the Broadcom tree, as the following
mail explains:

https://lore.kernel.org/all/0e154ae3-e0ab-4a4e-aa39-999ea1c720ed@broadcom.com/

Let me summarize the patch history here below:

dt-bindings: clock: Add RaspberryPi RP1 clock bindings -
Reviewed-by: Krzysztof and Florian [1,2]

clk: rp1: Add support for clocks provided by RP1 -
Stephen: [3]

pinctrl: rp1: Implement RaspberryPi RP1 gpio support -
Reviewed-by: Linus W. and Stefan W. [4,5]

misc: rp1: RaspberryPi RP1 misc driver -
Acked-by: Bjorn H. and Greg [6,7]

pinctrl: rp1: Implement RaspberryPi RP1 pinmux/pinconf support -
Acked-by: Linus W. [8]

Regarding the testing phase, I and some colleagues at SUSE have tested
the patchset from quite some time now.

Links:
[1] - https://lore.kernel.org/all/leeeqocyjme2sbjbwsw6whisyu6aeq7vfypdi4arktpowzxvek@ejjyxx4iliap/
[2] - https://lore.kernel.org/all/a70e8c45-97a8-4fb6-9b27-4f9ed020211c@broadcom.com/
[3] - https://lore.kernel.org/all/8513c30f597f757a199e4f9a565b0bf5@kernel.org/
[4] - https://lore.kernel.org/all/CACRpkdZCbvNY=B05e9wGqNr5b4t8GrDVsr01C3xd5E-WWwPyMQ@mail.gmail.com/
[5] - https://lore.kernel.org/all/0c6fa2cc-3a7e-4db2-bbad-7c19a876937e@gmx.net/
[6] - https://lore.kernel.org/all/20250416193152.GA78446@bhelgaas/
[7] - https://lore.kernel.org/all/2025042551-agency-boozy-dc3b@gregkh/
[8] - https://lore.kernel.org/all/CACRpkdbAxyZK_f8y6mzX_eJ3UM5ZtuXEpSmXE+QpUXaHKw_NGg@mail.gmail.com/

Many thanks,
Andrea

>
> thanks,
>
> greg k-h