From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18B92C8302F for ; Mon, 30 Jun 2025 23:13:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DzTYWc26VhY7F4Dd1PcZclEHh6aBgE/SboxldIm70BM=; b=R6qPRK9gr2xK5lAngqF2crkN1Z zFhye+OEVElI0PNGvFW2sKQ5zy9rBTbDnQveq7meZgSxuVfO+pY6bJh0L5jHAJO/5CBafFAvJjRSH AgnbrfJp9IODIJVVLWqOYLIkyNogR2k4HcTkXsp9TIfCdZ5yTbyu+i7Ow6aAShkEFLhZdmscx+7F9 w0CYu7ApmXOQvWncdQ3VyX29anXyl0XqR+HerWGdltDYb68NeLb6zSDM/BCeHrwVwXPHIexpeU9x/ gDoFwZdnujuDDPlfGY4qmzbZfDqKXLwtqPMagygycQjEEHDQz31jpc4onGqDPaQAlqkM0TdKLbYEz ORJKG7nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWNgR-00000003fjs-1Uhc; Mon, 30 Jun 2025 23:13:07 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWNao-00000003fJG-0f3o for linux-arm-kernel@lists.infradead.org; Mon, 30 Jun 2025 23:07:19 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id BAC54838; Tue, 1 Jul 2025 01:06:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1751324815; bh=F2c86YPB2yWAluPyg1zOw8RQH2nzZ+7OT6X/Myd+15c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JeCrGwaYFsgs0iI5OCZ3bsli3VjmGyndnl7tiGVlTdY5UFlCl3E1nJn1OThNKowdz eNBW4azDl5RQKTLJieyRSCdNckf2KXPnKoLPoKevlcHiWkmUYvH2UWNKKwOhIvElAx MqQ5xsQkTXr3MxxPBfNXwgbC8kAfEz1ZffCHg1ao= Date: Tue, 1 Jul 2025 02:06:51 +0300 From: Laurent Pinchart To: Frank Li Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 5/5] arm64: dts: imx8qxp-mek: add parallel ov5640 camera support Message-ID: <20250630230651.GG15184@pendragon.ideasonboard.com> References: <20250630-imx8qxp_pcam-v1-0-eccd38d99201@nxp.com> <20250630-imx8qxp_pcam-v1-5-eccd38d99201@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250630-imx8qxp_pcam-v1-5-eccd38d99201@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250630_160718_341647_DE149168 X-CRM114-Status: GOOD ( 20.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, Thank you for the patch. On Mon, Jun 30, 2025 at 06:28:21PM -0400, Frank Li wrote: > Add parallel ov5640 nodes in imx8qxp-mek and create overlay file to enable > it because it can work at two mode: MIPI and parallel mode. > > Signed-off-by: Frank Li > --- > arch/arm64/boot/dts/freescale/Makefile | 3 ++ > arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 37 +++++++++++++++++++ > .../dts/freescale/imx8x-mek-ov5640-parallel.dtso | 43 ++++++++++++++++++++++ > 3 files changed, 83 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile > index 02ef35578dbc7..a9fb11ccd3dea 100644 > --- a/arch/arm64/boot/dts/freescale/Makefile > +++ b/arch/arm64/boot/dts/freescale/Makefile > @@ -330,6 +330,9 @@ dtb-$(CONFIG_ARCH_MXC) += imx8qxp-mek-pcie-ep.dtb > imx8qxp-mek-ov5640-csi-dtbs := imx8qxp-mek.dtb imx8qxp-mek-ov5640-csi.dtbo > dtb-${CONFIG_ARCH_MXC} += imx8qxp-mek-ov5640-csi.dtb > > +imx8qxp-mek-ov5640-parallel-dtbs := imx8qxp-mek.dtb imx8x-mek-ov5640-parallel.dtbo > +dtb-${CONFIG_ARCH_MXC} += imx8qxp-mek-ov5640-parallel.dtb > + > dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqp-mba8xx.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8qxp-tqma8xqps-mb-smarc-2.dtb > dtb-$(CONFIG_ARCH_MXC) += imx8ulp-evk.dtb > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > index c95cb8acc360a..09eb85a9759e2 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > @@ -487,6 +487,23 @@ pca6416: gpio@20 { > #gpio-cells = <2>; > }; > > + ov5640_pi: camera@3c { > + compatible = "ovti,ov5640"; > + reg = <0x3c>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_parallel_csi>; > + clocks = <&pi0_misc_lpcg IMX_LPCG_CLK_0>; > + assigned-clocks = <&pi0_misc_lpcg IMX_LPCG_CLK_0>; > + assigned-clock-rates = <24000000>; > + clock-names = "xclk"; > + powerdown-gpios = <&lsio_gpio3 2 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&lsio_gpio3 3 GPIO_ACTIVE_LOW>; > + AVDD-supply = <®_2v8>; > + DVDD-supply = <®_1v5>; > + DOVDD-supply = <®_1v8>; > + status = "disabled"; /* Overlay enable it */ > + }; > + As far as I can tell, the sensor isn't soldered on the board, but is an external module connected through a cable. This DT node should therefore be moved to the overlay. > cs42888: audio-codec@48 { > compatible = "cirrus,cs42888"; > reg = <0x48>; > @@ -865,6 +882,26 @@ IMX8QXP_MIPI_CSI0_MCLK_OUT_MIPI_CSI0_ACM_MCLK_OUT 0xC0000041 > >; > }; > > + pinctrl_parallel_csi: parallelcsigrp { > + fsl,pins = < > + IMX8QXP_CSI_D00_CI_PI_D02 0xc0000041 > + IMX8QXP_CSI_D01_CI_PI_D03 0xc0000041 > + IMX8QXP_CSI_D02_CI_PI_D04 0xc0000041 > + IMX8QXP_CSI_D03_CI_PI_D05 0xc0000041 > + IMX8QXP_CSI_D04_CI_PI_D06 0xc0000041 > + IMX8QXP_CSI_D05_CI_PI_D07 0xc0000041 > + IMX8QXP_CSI_D06_CI_PI_D08 0xc0000041 > + IMX8QXP_CSI_D07_CI_PI_D09 0xc0000041 > + > + IMX8QXP_CSI_MCLK_CI_PI_MCLK 0xc0000041 > + IMX8QXP_CSI_PCLK_CI_PI_PCLK 0xc0000041 > + IMX8QXP_CSI_HSYNC_CI_PI_HSYNC 0xc0000041 > + IMX8QXP_CSI_VSYNC_CI_PI_VSYNC 0xc0000041 > + IMX8QXP_CSI_EN_LSIO_GPIO3_IO02 0xc0000041 > + IMX8QXP_CSI_RESET_LSIO_GPIO3_IO03 0xc0000041 > + >; > + }; Same for this one. > + > pinctrl_pcieb: pcieagrp { > fsl,pins = < > IMX8QXP_PCIE_CTRL0_PERST_B_LSIO_GPIO4_IO00 0x06000021 > diff --git a/arch/arm64/boot/dts/freescale/imx8x-mek-ov5640-parallel.dtso b/arch/arm64/boot/dts/freescale/imx8x-mek-ov5640-parallel.dtso > new file mode 100644 > index 0000000000000..927d6640662f3 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8x-mek-ov5640-parallel.dtso > @@ -0,0 +1,43 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright 2025 NXP > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > + > +&ov5640_pi { > + status = "okay"; > + > + port { > + ov5640_pi_ep: endpoint { > + remote-endpoint = <¶llel_csi_in>; > + data-lanes = <1 2>; data-lanes is not allowed for parallel buses. > + bus-type = ; > + bus-width = <8>; > + vsync-active = <0>; > + hsync-active = <1>; > + pclk-sample = <1>; > + }; > + }; > +}; > + > +¶llel_csi { > + status = "okay"; > + > + ports { > + port@0 { > + parallel_csi_in: endpoint { > + remote-endpoint = <&ov5640_pi_ep>; > + }; > + }; > + > + }; > +}; > + > +&isi { > + status = "okay"; > +}; -- Regards, Laurent Pinchart