Re: [PATCH 5/5] arm64: dts: imx943: Add LVDS/DISPLAY CSR nodes

Peng Fan
2025-07-01T14:56:23Z

On Tue, Jul 01, 2025 at 01:38:11PM +0200, Krzysztof Kozlowski wrote:
>On 01/07/2025 09:04, Peng Fan wrote:
>> Add nodes for LVDS/DISPLAY CSR.
>>
>> Add ldb_pll_div7 node which is used for clock source of DISPLAY CSR.
>>
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/imx943.dtsi | 34 +++++++++++++++++++++++++++++++
>> 1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx943.dtsi b/arch/arm64/boot/dts/freescale/imx943.dtsi
>> index 45b8da758e87771c0775eb799ce2da3aac37c060..cf67dba21e4f6f27fff7e5d29744086e4ec9c021 100644
>> --- a/arch/arm64/boot/dts/freescale/imx943.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx943.dtsi
>> @@ -3,6 +3,8 @@
>> * Copyright 2025 NXP
>> */
>>
>> +#include <dt-bindings/clock/nxp,imx94-clock.h>
>> +
>> #include "imx94.dtsi"
>>
>> / {
>> @@ -145,4 +147,36 @@ l3_cache: l3-cache {
>> cache-unified;
>> };
>> };
>> +
>> + ldb_pll_pixel: ldb_pll_div7 {
>
>Not a DTS coding style.
>
>Please use name for all fixed clocks which matches current format
>recommendation: 'clock-<freq>' (see also the pattern in the binding for
>any other options).

oops, I should use '-'. And the rate is not fixed, so not able to
use clock-<freq> for node name.

grep "fixed-factor-clock" ./Documentation/devicetree/bindings/ -rn, I
checked renesas,emev2-smu.yaml, fixed-factor-clock.yaml,
I could use "ldb-pll-div7-clk" in V2.

Thanks,
Peng

>
>https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/clock/fixed-clock.yaml?h=v6.11-rc1
>
>> + compatible = "fixed-factor-clock";
>> + #clock-cells = <0>;
>> + clocks = <&scmi_clk IMX94_CLK_LDBPLL>;
>> + clock-div = <7>;
>> + clock-mult = <1>;
>> + clock-output-names = "ldb_pll_div7";
>> + };
>
>
>
>Best regards,
>Krzysztof