From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3F24C7EE30 for ; Wed, 2 Jul 2025 10:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EmnxK/fcrxxXUhMhQ9V8hHxw8+/ly6dtIUYblCY5Q1g=; b=jlT0LWxosiGaB2/hUx76LYex+D /EWU0j8etcsc09wJ7gy6hmv0Bbl1v6l1Od0rYvJEbluP+QNEPIWWtYtwP1/vXsNeJznd0vuSa/SUb BpIRgvQz4N2NdtlwogFkH2obNmj7U1fiAEEAjlHlutxGkRcRxNtd+F3jNhszjUXM1DPiBx2J+eQi6 rhcjGtNmYOJsPKwTJolehMOE3IzZ6LBiGmXyNWGkKkOA4NxSBH7SbYB/P/4nJo6zeIBfXUKuCygKE kG6G+eBrpmV241bVO8t7YQrxCY5wHF+NyoprOIf/a5P4+ZsjNZLK2aTtZinijMTGYJUneUC9EK9vE j6IqnyCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWuKi-00000007sq5-475q; Wed, 02 Jul 2025 10:04:52 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uWtvJ-00000007nbu-3kBz; Wed, 02 Jul 2025 09:38:39 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 966C4E91; Wed, 2 Jul 2025 11:38:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1751449088; bh=DGKrttRsQr4Iev/uBW1PHry4ekiuQTspS65d9746Hfk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OaQRH80s6vm2oaq0DfRpQ8cCRCiwGUiKn9uTbKfY2N5A5lVPkpUNu2d23a80gt6kj ZNipU0xVGKEARmwGwLxQve3e93XgPhXPlqa4QG1qZ0GEyo+pcKGpKPDLEGG1Z9DQTT JGHs9kaLxL5FYJyPWFLq6nEjQDFhfcGOBwG1hLd0= Date: Wed, 2 Jul 2025 12:38:06 +0300 From: Laurent Pinchart To: Frank Li Cc: Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Eugen Hristev , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Peng Fan , Alice Yuan , Vinod Koul , Kishon Vijay Abraham I , Philipp Zabel , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, "Guoniu.zhou" Subject: Re: [PATCH 5/7] media: nxp: add DesignWare MIPI CSI2 controller driver Message-ID: <20250702093806.GF16835@pendragon.ideasonboard.com> References: <20250701-95_cam-v1-0-c5172bab387b@nxp.com> <20250701-95_cam-v1-5-c5172bab387b@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250701-95_cam-v1-5-c5172bab387b@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250702_023838_065947_4400FD58 X-CRM114-Status: GOOD ( 11.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, Thank you for the patch. On Tue, Jul 01, 2025 at 06:06:10PM -0400, Frank Li wrote: > From: "Guoniu.zhou" > > Add V4L2 subdev driver for DesignWare MIPI CSI2 controller. This seems to be at least the third instance of a driver for the CSI-2 receiver, the first two being drivers/media/platform/raspberrypi/rp1-cfe/dphy.c and the second one drivers/media/platform/renesas/rcar-csi2.c (the latter seems to support multiple CSI-2 receivers). drivers/staging/media/imx/imx6-mipi-csi2.c seem related too, likely for an old version of the IP. Could we please try to avoid code duplication ? > Signed-off-by: Guoniu.zhou > Signed-off-by: Frank Li > --- > MAINTAINERS | 1 + > drivers/media/platform/nxp/Kconfig | 11 + > drivers/media/platform/nxp/Makefile | 1 + > drivers/media/platform/nxp/dwc-mipi-csi2.c | 1675 ++++++++++++++++++++++++++++ This should go to drivers/media/platform/synopsys/ > 4 files changed, 1688 insertions(+) [snip] -- Regards, Laurent Pinchart