* [PATCH 1/2] ASoC: fsl_mqs: Distinguish different modules by system manager indices
2025-06-20 5:52 [PATCH 0/2] ASoC: fsl_mqs: support MQS2 on i.MX94 platform Shengjiu Wang
@ 2025-06-20 5:52 ` Shengjiu Wang
2025-07-03 2:37 ` Peng Fan
2025-06-20 5:52 ` [PATCH 2/2] ASoC: fsl_mqs: rename system manager indices for i.MX95 Shengjiu Wang
2025-07-03 17:10 ` [PATCH 0/2] ASoC: fsl_mqs: support MQS2 on i.MX94 platform Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Shengjiu Wang @ 2025-06-20 5:52 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, shengjiu.wang, Xiubo.Lee,
nicoleotsuka, lgirdwood, broonie, perex, tiwai, cristian.marussi,
peng.fan, sudeep.holla, arnd, imx, linux-arm-kernel, linux-kernel,
linux-sound, linuxppc-dev
On i.MX94, the MQS2 also needs to be configured by SCMI interface, add
sm_index variable in struct fsl_mqs_soc_data to distinguish the MQS1 and
MQS2 on this platform.
Add the system manager indices for i.MX94 in the header file.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
include/linux/firmware/imx/sm.h | 8 ++++++++
sound/soc/fsl/fsl_mqs.c | 11 ++++++++---
2 files changed, 16 insertions(+), 3 deletions(-)
diff --git a/include/linux/firmware/imx/sm.h b/include/linux/firmware/imx/sm.h
index a8a17eeb7d90..a6220c500f7c 100644
--- a/include/linux/firmware/imx/sm.h
+++ b/include/linux/firmware/imx/sm.h
@@ -18,6 +18,14 @@
#define SCMI_IMX_CTRL_SAI4_MCLK 4 /* WAKE SAI4 MCLK */
#define SCMI_IMX_CTRL_SAI5_MCLK 5 /* WAKE SAI5 MCLK */
+#define SCMI_IMX94_CTRL_PDM_CLK_SEL 0U /*!< AON PDM clock sel */
+#define SCMI_IMX94_CTRL_MQS1_SETTINGS 1U /*!< AON MQS settings */
+#define SCMI_IMX94_CTRL_MQS2_SETTINGS 2U /*!< WAKE MQS settings */
+#define SCMI_IMX94_CTRL_SAI1_MCLK 3U /*!< AON SAI1 MCLK */
+#define SCMI_IMX94_CTRL_SAI2_MCLK 4U /*!< WAKE SAI2 MCLK */
+#define SCMI_IMX94_CTRL_SAI3_MCLK 5U /*!< WAKE SAI3 MCLK */
+#define SCMI_IMX94_CTRL_SAI4_MCLK 6U /*!< WAKE SAI4 MCLK */
+
int scmi_imx_misc_ctrl_get(u32 id, u32 *num, u32 *val);
int scmi_imx_misc_ctrl_set(u32 id, u32 val);
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
index e34e5ea98de5..11f2f3792dce 100644
--- a/sound/soc/fsl/fsl_mqs.c
+++ b/sound/soc/fsl/fsl_mqs.c
@@ -39,6 +39,7 @@ enum reg_type {
* struct fsl_mqs_soc_data - soc specific data
*
* @type: control register space type
+ * @sm_index: index from definition in system manager
* @ctrl_off: control register offset
* @en_mask: enable bit mask
* @en_shift: enable bit shift
@@ -51,6 +52,7 @@ enum reg_type {
*/
struct fsl_mqs_soc_data {
enum reg_type type;
+ int sm_index;
int ctrl_off;
int en_mask;
int en_shift;
@@ -82,7 +84,7 @@ static int fsl_mqs_sm_read(void *context, unsigned int reg, unsigned int *val)
if (IS_ENABLED(CONFIG_IMX_SCMI_MISC_DRV) &&
mqs_priv->soc->ctrl_off == reg)
- return scmi_imx_misc_ctrl_get(SCMI_IMX_CTRL_MQS1_SETTINGS, &num, val);
+ return scmi_imx_misc_ctrl_get(mqs_priv->soc->sm_index, &num, val);
return -EINVAL;
};
@@ -93,7 +95,7 @@ static int fsl_mqs_sm_write(void *context, unsigned int reg, unsigned int val)
if (IS_ENABLED(CONFIG_IMX_SCMI_MISC_DRV) &&
mqs_priv->soc->ctrl_off == reg)
- return scmi_imx_misc_ctrl_set(SCMI_IMX_CTRL_MQS1_SETTINGS, val);
+ return scmi_imx_misc_ctrl_set(mqs_priv->soc->sm_index, val);
return -EINVAL;
};
@@ -386,6 +388,7 @@ static const struct fsl_mqs_soc_data fsl_mqs_imx93_data = {
static const struct fsl_mqs_soc_data fsl_mqs_imx95_aon_data = {
.type = TYPE_REG_SM,
+ .sm_index = SCMI_IMX_CTRL_MQS1_SETTINGS,
.ctrl_off = 0x88,
.en_mask = BIT(1),
.en_shift = 1,
@@ -412,6 +415,7 @@ static const struct fsl_mqs_soc_data fsl_mqs_imx95_netc_data = {
static const struct fsl_mqs_soc_data fsl_mqs_imx943_aon_data = {
.type = TYPE_REG_SM,
+ .sm_index = SCMI_IMX94_CTRL_MQS1_SETTINGS,
.ctrl_off = 0x88,
.en_mask = BIT(1),
.en_shift = 1,
@@ -424,7 +428,8 @@ static const struct fsl_mqs_soc_data fsl_mqs_imx943_aon_data = {
};
static const struct fsl_mqs_soc_data fsl_mqs_imx943_wakeup_data = {
- .type = TYPE_REG_GPR,
+ .type = TYPE_REG_SM,
+ .sm_index = SCMI_IMX94_CTRL_MQS2_SETTINGS,
.ctrl_off = 0x10,
.en_mask = BIT(1),
.en_shift = 1,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ASoC: fsl_mqs: rename system manager indices for i.MX95
2025-06-20 5:52 [PATCH 0/2] ASoC: fsl_mqs: support MQS2 on i.MX94 platform Shengjiu Wang
2025-06-20 5:52 ` [PATCH 1/2] ASoC: fsl_mqs: Distinguish different modules by system manager indices Shengjiu Wang
@ 2025-06-20 5:52 ` Shengjiu Wang
2025-07-03 2:41 ` Peng Fan
2025-07-03 17:10 ` [PATCH 0/2] ASoC: fsl_mqs: support MQS2 on i.MX94 platform Mark Brown
2 siblings, 1 reply; 6+ messages in thread
From: Shengjiu Wang @ 2025-06-20 5:52 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, shengjiu.wang, Xiubo.Lee,
nicoleotsuka, lgirdwood, broonie, perex, tiwai, cristian.marussi,
peng.fan, sudeep.holla, arnd, imx, linux-arm-kernel, linux-kernel,
linux-sound, linuxppc-dev
The system manager indices names are different for each platform, rename
the indices for i.MX95 to differentiate with other platform.
Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
include/linux/firmware/imx/sm.h | 12 ++++++------
sound/soc/fsl/fsl_mqs.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/include/linux/firmware/imx/sm.h b/include/linux/firmware/imx/sm.h
index a6220c500f7c..d4212bc42b2c 100644
--- a/include/linux/firmware/imx/sm.h
+++ b/include/linux/firmware/imx/sm.h
@@ -11,12 +11,12 @@
#include <linux/scmi_imx_protocol.h>
#include <linux/types.h>
-#define SCMI_IMX_CTRL_PDM_CLK_SEL 0 /* AON PDM clock sel */
-#define SCMI_IMX_CTRL_MQS1_SETTINGS 1 /* AON MQS settings */
-#define SCMI_IMX_CTRL_SAI1_MCLK 2 /* AON SAI1 MCLK */
-#define SCMI_IMX_CTRL_SAI3_MCLK 3 /* WAKE SAI3 MCLK */
-#define SCMI_IMX_CTRL_SAI4_MCLK 4 /* WAKE SAI4 MCLK */
-#define SCMI_IMX_CTRL_SAI5_MCLK 5 /* WAKE SAI5 MCLK */
+#define SCMI_IMX95_CTRL_PDM_CLK_SEL 0 /* AON PDM clock sel */
+#define SCMI_IMX95_CTRL_MQS1_SETTINGS 1 /* AON MQS settings */
+#define SCMI_IMX95_CTRL_SAI1_MCLK 2 /* AON SAI1 MCLK */
+#define SCMI_IMX95_CTRL_SAI3_MCLK 3 /* WAKE SAI3 MCLK */
+#define SCMI_IMX95_CTRL_SAI4_MCLK 4 /* WAKE SAI4 MCLK */
+#define SCMI_IMX95_CTRL_SAI5_MCLK 5 /* WAKE SAI5 MCLK */
#define SCMI_IMX94_CTRL_PDM_CLK_SEL 0U /*!< AON PDM clock sel */
#define SCMI_IMX94_CTRL_MQS1_SETTINGS 1U /*!< AON MQS settings */
diff --git a/sound/soc/fsl/fsl_mqs.c b/sound/soc/fsl/fsl_mqs.c
index 11f2f3792dce..901f840df904 100644
--- a/sound/soc/fsl/fsl_mqs.c
+++ b/sound/soc/fsl/fsl_mqs.c
@@ -388,7 +388,7 @@ static const struct fsl_mqs_soc_data fsl_mqs_imx93_data = {
static const struct fsl_mqs_soc_data fsl_mqs_imx95_aon_data = {
.type = TYPE_REG_SM,
- .sm_index = SCMI_IMX_CTRL_MQS1_SETTINGS,
+ .sm_index = SCMI_IMX95_CTRL_MQS1_SETTINGS,
.ctrl_off = 0x88,
.en_mask = BIT(1),
.en_shift = 1,
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] ASoC: fsl_mqs: support MQS2 on i.MX94 platform
2025-06-20 5:52 [PATCH 0/2] ASoC: fsl_mqs: support MQS2 on i.MX94 platform Shengjiu Wang
2025-06-20 5:52 ` [PATCH 1/2] ASoC: fsl_mqs: Distinguish different modules by system manager indices Shengjiu Wang
2025-06-20 5:52 ` [PATCH 2/2] ASoC: fsl_mqs: rename system manager indices for i.MX95 Shengjiu Wang
@ 2025-07-03 17:10 ` Mark Brown
2 siblings, 0 replies; 6+ messages in thread
From: Mark Brown @ 2025-07-03 17:10 UTC (permalink / raw)
To: shawnguo, s.hauer, kernel, festevam, shengjiu.wang, Xiubo.Lee,
nicoleotsuka, lgirdwood, perex, tiwai, cristian.marussi, peng.fan,
sudeep.holla, arnd, imx, linux-arm-kernel, linux-kernel,
linux-sound, linuxppc-dev, Shengjiu Wang
On Fri, 20 Jun 2025 13:52:27 +0800, Shengjiu Wang wrote:
> ASoC: fsl_mqs: support MQS2 on i.MX94 platform
>
> Shengjiu Wang (2):
> ASoC: fsl_mqs: Distinguish different modules by system manager indices
> ASoC: fsl_mqs: rename system manager indices for i.MX95
>
> include/linux/firmware/imx/sm.h | 20 ++++++++++++++------
> sound/soc/fsl/fsl_mqs.c | 11 ++++++++---
> 2 files changed, 22 insertions(+), 9 deletions(-)
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/2] ASoC: fsl_mqs: Distinguish different modules by system manager indices
commit: 9931d2899eec3737f4e4fa9fc900be7329816e94
[2/2] ASoC: fsl_mqs: rename system manager indices for i.MX95
commit: baee26a9d6cd3d3c6c3c03c56270aa647a67e4bd
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread