From: Nishanth Menon <nm@ti.com>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Guillaume La Roque <glaroque@baylibre.com>,
Andrew Davis <afd@ti.com>, <vishalm@ti.com>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, <linux@ew.tq-group.com>
Subject: Re: [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3
Date: Thu, 3 Jul 2025 07:28:13 -0500 [thread overview]
Message-ID: <20250703122813.jh2muwzwe4ok6b6d@process> (raw)
In-Reply-To: <9042d63de85f7ae8bf73760e9d2d7652c18a738c.camel@ew.tq-group.com>
On 09:25-20250702, Matthias Schiffer wrote:
> On Tue, 2025-07-01 at 20:57 +0200, Guillaume La Roque wrote:
> >
> > Le 01/07/2025 à 16:36, Matthias Schiffer a écrit :
> > > On Mon, 2025-05-19 at 10:20 +0200, Guillaume La Roque wrote:
> > > >
> > > > After patch done on TI_MESSAGE_MANAGER[1] and TI_SCI_PROTOCOL[2] driver
> > > > select on ARCH_K3 are not needed anymore.
> > > > Select MAILBOX by default is not needed anymore[3],
> > > > PM_GENERIC_DOMAIN if PM was enabled by default so not needed.
> > >
> > > Hi,
> >
> > Hi,
> >
> > >
> > > what selects PM_GENERIC_DOMAIN in your configuration? linux-next fails to boot
> > > on our AM62x-based TQMa62xx if I don't (partially) revert this patch - I have
> > > not found a way to enable PM_GENERIC_DOMAIN and TI_SCI_PM_DOMAINS without
> > > enabling other unneeded features to pull it in.
> > >
> > With master branch if i apply this patch and i do make ARCH=arm64
> > defconfig and check in .config both TI_SCI_PM_DOMAINS and
> > PM_GENERIC_DOMAINS are enabled.
> > with linux-next it's same. i don't really understand link with PM part
> > in this patch and boot issue on your SOM.
> >
> > I probably misunderstand something.
> >
> >
> > what is your problem exactly ?
> >
> > if you can share log or link to jobs
>
>
> Hi Guillaume,
>
> with arm64_defconfig, this problem doesn't occur, as other CONFIG_ARCH_* symbols
> also have "select PM_GENERIC_DOMAINS" (with or without "if PM").
>
> We are using a smaller config specific to our K3-based SOMs however. I have
> attached a defconfig that shows the problem - if you use this as the base for
> .config on linux-next, there is no way to enable TI_SCI_PM_DOMAINS, as nothing
> selects PM_GENERIC_DOMAINS.
>
> So unless I'm missing some other configuration that would actually be useful on
> the K3 platform and that would pull in PM_GENERIC_DOMAINS, I think that part
> needs to be reverted. I can send a patch to that effect later.
Is a better approach to select PM_GENERIC_DOMAINS in
drivers/pmdomain/ti/Kconfig instead of depends (similar to what
drivers/pmdomain/qcom/Kconfig or drivers/pmdomain/arm/Kconfig does since
TI_SCI_PM_DOMAINS requires PM_GENERIC_DOMAINS?
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2025-07-03 14:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 8:20 [PATCH v2] arm64: Kconfig.platforms: remove useless select for ARCH_K3 Guillaume La Roque
2025-06-24 18:42 ` Vignesh Raghavendra
2025-07-01 14:36 ` Matthias Schiffer
2025-07-01 18:57 ` Guillaume La Roque
2025-07-02 7:25 ` Matthias Schiffer
2025-07-02 18:14 ` Guillaume La Roque
2025-07-03 12:28 ` Nishanth Menon [this message]
2025-07-07 9:59 ` Guillaume La Roque
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250703122813.jh2muwzwe4ok6b6d@process \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=catalin.marinas@arm.com \
--cc=glaroque@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@ew.tq-group.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=vishalm@ti.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).