From: Jean Delvare <jdelvare@suse.de>
To: Andrew Jeffery <andrew@codeconstruct.com.au>
Cc: linux-aspeed@lists.ozlabs.org, Joel Stanley <joel@jms.id.au>,
Henry Martin <bsdhenrymartin@gmail.com>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Andrew Geissler <geissonator@yahoo.com>,
Ninad Palsule <ninad@linux.ibm.com>,
Patrick Venture <venture@google.com>,
Robert Lippert <roblip@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 08/10] soc: aspeed: lpc-snoop: Use dev_err_probe() where possible
Date: Fri, 4 Jul 2025 16:46:37 +0200 [thread overview]
Message-ID: <20250704164637.3552933a@endymion> (raw)
In-Reply-To: <20250616-aspeed-lpc-snoop-fixes-v2-8-3cdd59c934d3@codeconstruct.com.au>
On Mon, 16 Jun 2025 22:43:45 +0930, Andrew Jeffery wrote:
> Exploit that it returns the provided error to eliminate some lines, and
> return the actual error involved rather than -ENODEV.
>
> Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>
> ---
> drivers/soc/aspeed/aspeed-lpc-snoop.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
> (...)
LGTM.
Acked-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2025-07-04 14:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 13:13 [PATCH v2 00/10] soc: aspeed: lpc-snoop: Miscellaneous fixes Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 01/10] soc: aspeed: lpc-snoop: Cleanup resources in stack-order Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 02/10] soc: aspeed: lpc-snoop: Don't disable channels that aren't enabled Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 03/10] soc: aspeed: lpc-snoop: Ensure model_data is valid Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 04/10] soc: aspeed: lpc-snoop: Constrain parameters in channel paths Andrew Jeffery
2025-07-04 16:44 ` Jean Delvare
2025-07-08 2:06 ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 05/10] soc: aspeed: lpc-snoop: Rename 'channel' to 'index' " Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 06/10] soc: aspeed: lpc-snoop: Rearrange " Andrew Jeffery
2025-07-04 15:34 ` Jean Delvare
2025-07-08 2:06 ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 07/10] soc: aspeed: lpc-snoop: Switch to devm_clk_get_enabled() Andrew Jeffery
2025-07-04 14:42 ` Jean Delvare
2025-06-16 13:13 ` [PATCH v2 08/10] soc: aspeed: lpc-snoop: Use dev_err_probe() where possible Andrew Jeffery
2025-07-04 14:46 ` Jean Delvare [this message]
2025-06-16 13:13 ` [PATCH v2 09/10] soc: aspeed: lpc-snoop: Consolidate channel initialisation Andrew Jeffery
2025-07-04 15:13 ` Jean Delvare
2025-07-08 2:06 ` Andrew Jeffery
2025-06-16 13:13 ` [PATCH v2 10/10] soc: aspeed: lpc-snoop: Lift channel config to const structs Andrew Jeffery
2025-07-04 16:23 ` Jean Delvare
2025-07-08 2:07 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250704164637.3552933a@endymion \
--to=jdelvare@suse.de \
--cc=andrew@codeconstruct.com.au \
--cc=bsdhenrymartin@gmail.com \
--cc=geissonator@yahoo.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=patrick.rudolph@9elements.com \
--cc=roblip@gmail.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).