From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DA61C83F0A for ; Tue, 8 Jul 2025 16:49:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=snlky0rzf5HvYtCIGoPprXYgpLt63cCjRVxbkAdO6Uo=; b=L0YJoT3ZGo8ECRqCw4coc0RfsM UEyqGuN2x0LCXrV7kXY3dV+gtRW4+zO+5QI7JwCiC+Ggo56Z8vX4HJYOyK6R1nHlAVlQ5eVXfFgOQ rskZaK4wna4yNWavznH2fwdgU27ZsO+CFADPC46pKR7wOceHd/2GQeWvCLGlAUdXKO1y19VPuIW3b xuuYaZLCd3QM0kC9g6qp9trxWb4YHR+w4eI7YMMgDw59fFRsapdAl0Um1zydUGX+sbmY4AmHEVFmf P/4hkbS0lmvnFKg5PdW/9UF33/m3bfv/NHB5K1BI0K2jILtvYXdqaWLU6geJ4qhb6Fh7R7Ih4oghc KsAX/Nhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZBVU-000000060yp-2f7i; Tue, 08 Jul 2025 16:49:24 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uZAhM-00000005tLO-0Dc3 for linux-arm-kernel@lists.infradead.org; Tue, 08 Jul 2025 15:57:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 5100044AE2; Tue, 8 Jul 2025 15:57:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6F95C4CEED; Tue, 8 Jul 2025 15:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751990255; bh=L2yUgoap+0fIAC1x2Nd6QW3SBW0rBu5+7f0Tcjm9Ywc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J1jepkKCv2aJV5MgoCfhIinofXQ9i5ADG62GKPZyENWSaZ46dAiG/HxVlJgr94pAz xfRhdveay8Eidb8cO4D+UyHmAQa8v0b9AoqF3U3S1YBD4E2mFXVukQyZxs+Qy3O9tJ yy16ab348jwfbbLmIoAMWRUxFvaq99BScncWZbiIlN1u990ERXUtwAKU9H4czUrKiG BqqUspmFPms+Cnep6drugVPK6oYZsWupxJDVah0QcAH480jBiXfNyaetaxBASmAw+V kbUkzq1wi0Bjw+/00BA6CA/CiNpHC3CquXYI5DsJsu3ptmVlLN8CSnlD7usZvblvZg ryFPdYYH3yvxQ== Date: Tue, 8 Jul 2025 10:57:33 -0500 From: Rob Herring To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?iso-8859-1?Q?K=F6ry?= Maincent , Marek =?iso-8859-1?Q?Beh=FAn?= , Oleksij Rempel , =?iso-8859-1?Q?Nicol=F2?= Veronese , Simon Horman , mwojtas@chromium.org, Antoine Tenart , devicetree@vger.kernel.org, Conor Dooley , Krzysztof Kozlowski , Romain Gantois , Daniel Golle , Dimitri Fedrau Subject: Re: [PATCH net-next v7 01/15] dt-bindings: net: Introduce the ethernet-connector description Message-ID: <20250708155733.GA481837-robh@kernel.org> References: <20250630143315.250879-1-maxime.chevallier@bootlin.com> <20250630143315.250879-2-maxime.chevallier@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250630143315.250879-2-maxime.chevallier@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250708_085736_144018_ADC57900 X-CRM114-Status: GOOD ( 29.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 30, 2025 at 04:33:00PM +0200, Maxime Chevallier wrote: > The ability to describe the physical ports of Ethernet devices is useful > to describe multi-port devices, as well as to remove any ambiguity with > regard to the nature of the port. > > Moreover, describing ports allows for a better description of features > that are tied to connectors, such as PoE through the PSE-PD devices. > > Introduce a binding to allow describing the ports, for now with 2 > attributes : > > - The number of lanes, which is a quite generic property that allows > differentating between multiple similar technologies such as BaseT1 > and "regular" BaseT (which usually means BaseT4). > > - The media that can be used on that port, such as BaseT for Twisted > Copper, BaseC for coax copper, BaseS/L for Fiber, BaseK for backplane > ethernet, etc. This allows defining the nature of the port, and > therefore avoids the need for vendor-specific properties such as > "micrel,fiber-mode" or "ti,fiber-mode". > > The port description lives in its own file, as it is intended in the > future to allow describing the ports for phy-less devices. > > Signed-off-by: Maxime Chevallier > --- > .../bindings/net/ethernet-connector.yaml | 47 +++++++++++++++++++ > .../devicetree/bindings/net/ethernet-phy.yaml | 18 +++++++ > MAINTAINERS | 1 + > 3 files changed, 66 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ethernet-connector.yaml > > diff --git a/Documentation/devicetree/bindings/net/ethernet-connector.yaml b/Documentation/devicetree/bindings/net/ethernet-connector.yaml > new file mode 100644 > index 000000000000..2aa28e6c1523 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ethernet-connector.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/ethernet-connector.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Generic Ethernet Connector > + > +maintainers: > + - Maxime Chevallier > + > +description: > + An Ethernet Connectr represents the output of a network component such as typo > + a PHY, an Ethernet controller with no PHY, or an SFP module. > + > +properties: > + > + lanes: > + description: > + Defines the number of lanes on the port, that is the number of physical > + channels used to convey the data with the link partner. > + $ref: /schemas/types.yaml#/definitions/uint32 maximum? Or I'd guess this is power of 2 values? > + > + media: > + description: > + The mediums, as defined in 802.3, that can be used on the port. > + items: > + enum: > + - BaseT > + - BaseK > + - BaseS > + - BaseC > + - BaseL > + - BaseD > + - BaseE > + - BaseF > + - BaseV > + - BaseMLD > + - BaseX This can be multiple values? But then how does one know what is actually attached? > + > +required: > + - lanes > + - media > + > +additionalProperties: true > + > +... > diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > index 71e2cd32580f..6bf670beb66f 100644 > --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml > +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml > @@ -277,6 +277,17 @@ properties: > > additionalProperties: false > > + mdi: > + type: object > + > + patternProperties: > + '^connector-[a-f0-9]+$': > + $ref: /schemas/net/ethernet-connector.yaml# > + > + unevaluatedProperties: false > + > + additionalProperties: false > + > required: > - reg > > @@ -313,5 +324,12 @@ examples: > default-state = "keep"; > }; > }; > + > + mdi { > + connector-0 { > + lanes = <2>; > + media = "BaseT"; > + }; > + }; > }; > }; > diff --git a/MAINTAINERS b/MAINTAINERS > index bb9df569a3ff..20806cfc1003 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8946,6 +8946,7 @@ R: Russell King > L: netdev@vger.kernel.org > S: Maintained > F: Documentation/ABI/testing/sysfs-class-net-phydev > +F: Documentation/devicetree/bindings/net/ethernet-connector.yaml > F: Documentation/devicetree/bindings/net/ethernet-phy.yaml > F: Documentation/devicetree/bindings/net/mdio* > F: Documentation/devicetree/bindings/net/qca,ar803x.yaml > -- > 2.49.0 >