From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
Srinivas Neeli <srinivas.neeli@amd.com>,
Michal Simek <michal.simek@amd.com>,
Nandor Han <nandor.han@ge.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com,
linux-arm-kernel@lists.infradead.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 14/19] gpio: xtensa: remove unneeded .set() callback
Date: Wed, 09 Jul 2025 08:41:51 +0200 [thread overview]
Message-ID: <20250709-gpiochip-set-rv-gpio-remaining-v1-14-b8950f69618d@linaro.org> (raw)
In-Reply-To: <20250709-gpiochip-set-rv-gpio-remaining-v1-0-b8950f69618d@linaro.org>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
GPIO core deals just fine with input-only controllers not implementing
the .set() callback. Remove the unneeded dummy implementation.
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
drivers/gpio/gpio-xtensa.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/gpio/gpio-xtensa.c b/drivers/gpio/gpio-xtensa.c
index c8af34a6368f4f69f9960fff7f8c27a2c8ddea8b..341b691ac2345b93320a6e8b933444d26dcf50e6 100644
--- a/drivers/gpio/gpio-xtensa.c
+++ b/drivers/gpio/gpio-xtensa.c
@@ -86,12 +86,6 @@ static int xtensa_impwire_get_value(struct gpio_chip *gc, unsigned offset)
return !!(impwire & BIT(offset));
}
-static void xtensa_impwire_set_value(struct gpio_chip *gc, unsigned offset,
- int value)
-{
- BUG(); /* output only; should never be called */
-}
-
static int xtensa_expstate_get_direction(struct gpio_chip *gc, unsigned offset)
{
return GPIO_LINE_DIRECTION_OUT; /* output only */
@@ -128,7 +122,6 @@ static struct gpio_chip impwire_chip = {
.ngpio = 32,
.get_direction = xtensa_impwire_get_direction,
.get = xtensa_impwire_get_value,
- .set = xtensa_impwire_set_value,
};
static struct gpio_chip expstate_chip = {
--
2.48.1
next prev parent reply other threads:[~2025-07-09 7:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 6:41 [PATCH 00/19] gpio: use new GPIO line value setter callbacks in remaining drivers Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 01/19] gpio: vx855: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 02/19] gpio: wcd934x: check the return value of regmap_update_bits() Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 03/19] gpio: wcd934x: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 04/19] gpio: wcove: " Bartosz Golaszewski
2025-07-09 8:32 ` Andy Shevchenko
2025-07-09 8:41 ` Andy Shevchenko
2025-07-09 14:21 ` Sathyanarayanan Kuppuswamy
2025-07-09 6:41 ` [PATCH 05/19] gpio: winbond: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 06/19] gpio: wm831x: " Bartosz Golaszewski
2025-07-09 9:41 ` Charles Keepax
2025-07-09 6:41 ` [PATCH 07/19] gpio: wm8350: " Bartosz Golaszewski
2025-07-09 9:42 ` Charles Keepax
2025-07-09 6:41 ` [PATCH 08/19] gpio: wm8994: " Bartosz Golaszewski
2025-07-09 9:43 ` Charles Keepax
2025-07-09 6:41 ` [PATCH 09/19] gpio: xgene: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 10/19] gpio: xilinx: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 11/19] gpio: xlp: drop unneeded ngpio checks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 12/19] gpio: xlp: use new GPIO line value setter callbacks Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 13/19] gpio: xra1403: " Bartosz Golaszewski
2025-07-09 6:41 ` Bartosz Golaszewski [this message]
2025-07-09 6:41 ` [PATCH 15/19] gpio: xtensa: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 16/19] gpio: zevio: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 17/19] gpio: zynq: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 18/19] gpio: zynqmp-modepin: " Bartosz Golaszewski
2025-07-09 6:41 ` [PATCH 19/19] gpio: zynqmp-modepin: set line value in .direction_output() Bartosz Golaszewski
2025-07-15 7:56 ` (subset) [PATCH 00/19] gpio: use new GPIO line value setter callbacks in remaining drivers Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709-gpiochip-set-rv-gpio-remaining-v1-14-b8950f69618d@linaro.org \
--to=brgl@bgdev.pl \
--cc=andy@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nandor.han@ge.com \
--cc=patches@opensource.cirrus.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=srinivas.neeli@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).