From: Rob Herring <robh@kernel.org>
To: Luo Jie <quic_luoj@quicinc.com>
Cc: Georgi Djakov <djakov@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Anusha Rao <quic_anusha@quicinc.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com,
quic_linchen@quicinc.com, quic_leiwei@quicinc.com,
quic_pavir@quicinc.com, quic_suruchia@quicinc.com
Subject: Re: [PATCH v3 05/10] dt-bindings: clock: ipq9574: Rename NSS CC source clocks to drop rate
Date: Thu, 10 Jul 2025 17:54:12 -0500 [thread overview]
Message-ID: <20250710225412.GA25762-robh@kernel.org> (raw)
In-Reply-To: <20250710-qcom_ipq5424_nsscc-v3-5-f149dc461212@quicinc.com>
On Thu, Jul 10, 2025 at 08:28:13PM +0800, Luo Jie wrote:
> Drop the clock rate suffix from the NSS Clock Controller clock names for
> PPE and NSS clocks. A generic name allows for easier extension of support
> to additional SoCs that utilize same hardware design.
This is an ABI change. You must state that here and provide a reason the
change is okay (assuming it is). Otherwise, you are stuck with the name
even if not optimal.
>
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
> ---
> .../devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> index 17252b6ea3be..b9ca69172adc 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> @@ -25,8 +25,8 @@ properties:
> clocks:
> items:
> - description: Board XO source
> - - description: CMN_PLL NSS 1200MHz (Bias PLL cc) clock source
> - - description: CMN_PLL PPE 353MHz (Bias PLL ubi nc) clock source
> + - description: CMN_PLL NSS (Bias PLL cc) clock source
> + - description: CMN_PLL PPE (Bias PLL ubi nc) clock source
> - description: GCC GPLL0 OUT AUX clock source
> - description: Uniphy0 NSS Rx clock source
> - description: Uniphy0 NSS Tx clock source
> @@ -42,8 +42,8 @@ properties:
> clock-names:
> items:
> - const: xo
> - - const: nss_1200
> - - const: ppe_353
> + - const: nss
> + - const: ppe
> - const: gpll0_out
> - const: uniphy0_rx
> - const: uniphy0_tx
> @@ -82,8 +82,8 @@ examples:
> <&uniphy 5>,
> <&gcc GCC_NSSCC_CLK>;
> clock-names = "xo",
> - "nss_1200",
> - "ppe_353",
> + "nss",
> + "ppe",
> "gpll0_out",
> "uniphy0_rx",
> "uniphy0_tx",
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-07-11 1:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 12:28 [PATCH v3 00/10] Add Network Subsystem (NSS) clock controller support for IPQ5424 SoC Luo Jie
2025-07-10 12:28 ` [PATCH v3 01/10] dt-bindings: interconnect: Add Qualcomm IPQ5424 NSSNOC IDs Luo Jie
2025-07-18 13:41 ` Georgi Djakov
2025-07-10 12:28 ` [PATCH v3 02/10] clk: qcom: ipq5424: Enable NSS NoC clocks to use icc-clk Luo Jie
2025-07-17 20:40 ` Konrad Dybcio
2025-07-18 9:21 ` Luo Jie
2025-07-10 12:28 ` [PATCH v3 03/10] dt-bindings: clock: gcc-ipq5424: Add definition for GPLL0_OUT_AUX Luo Jie
2025-07-10 12:28 ` [PATCH v3 04/10] clock: qcom: gcc-ipq5424: Add gpll0_out_aux clock Luo Jie
2025-07-17 20:41 ` Konrad Dybcio
2025-07-18 9:12 ` Luo Jie
2025-07-10 12:28 ` [PATCH v3 05/10] dt-bindings: clock: ipq9574: Rename NSS CC source clocks to drop rate Luo Jie
2025-07-10 22:54 ` Rob Herring [this message]
2025-07-11 12:15 ` Konrad Dybcio
2025-07-18 9:12 ` Luo Jie
2025-07-18 9:28 ` Konrad Dybcio
2025-07-18 15:51 ` Luo Jie
2025-07-29 13:53 ` Konrad Dybcio
2025-07-29 13:57 ` Krzysztof Kozlowski
2025-07-30 11:50 ` Luo Jie
2025-07-10 12:28 ` [PATCH v3 06/10] arm64: dts: qcom: ipq9574: Rename NSSCC source clock names " Luo Jie
2025-07-10 12:28 ` [PATCH v3 07/10] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5424 SoC Luo Jie
2025-07-10 22:55 ` Rob Herring
2025-07-11 12:16 ` Konrad Dybcio
2025-07-18 9:05 ` Luo Jie
2025-07-10 12:28 ` [PATCH v3 08/10] clk: qcom: Add NSS clock controller driver for IPQ5424 Luo Jie
2025-07-10 12:28 ` [PATCH v3 09/10] arm64: dts: qcom: ipq5424: Add NSS clock controller node Luo Jie
2025-07-10 12:28 ` [PATCH v3 10/10] arm64: defconfig: Build NSS clock controller driver for IPQ5424 Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710225412.GA25762-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).