From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B44CDC8303C for ; Fri, 11 Jul 2025 10:55:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xOe0DECHbh24BVQ5E5u9fAtHwwKQN2MvVta0PHunC5I=; b=q0JAh+4j1i1q3pbHUouQ1jr9mc 3/92OcBDFT23kY/2wp7zt850SFZ/tg+6D/Mlhd8iuOd3ebG7+ps8nHJLla/RdIGmvUVZ+wxP05AkY vl5vcDWBXZ8Jej8/ZHxPza67enKk/wQ5wbfX6CoDcLjo2Z/UkYC8Ii9gj6UR549EF/oH4EUlq4mLP msZelSKA7AksfAeF5cku7QLkQs7XIFQ6i26fdzh3uJ/5Nu7pFfjkJstP9rbnlR+QoheCMBn6iyj4i 8j1iEj8orrhjtEBl4q3NAdqufn+95gHtkgcsMjS8oC0LOeAgr+RVBBj1clgRmYfqx3KAvyp9sabKY rdfCdJUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uaBQ0-0000000EXLB-41JM; Fri, 11 Jul 2025 10:55:52 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uaA3n-0000000EIvc-0wrw for linux-arm-kernel@lists.infradead.org; Fri, 11 Jul 2025 09:28:52 +0000 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bdmXS37K6z6L4yR; Fri, 11 Jul 2025 17:25:28 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 2177D14020C; Fri, 11 Jul 2025 17:28:46 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Jul 2025 11:28:45 +0200 Date: Fri, 11 Jul 2025 10:28:43 +0100 From: Jonathan Cameron To: Alireza Sanaee CC: , , , , , , , , , , , , , , , Suzuki K Poulose Subject: Re: [PATCH v2 3/5] coresight: cti: Use of_cpu_phandle_to_id for grabbing CPU id Message-ID: <20250711102843.000003e6@huawei.com> In-Reply-To: <20250708151502.561-4-alireza.sanaee@huawei.com> References: <20250708151502.561-1-alireza.sanaee@huawei.com> <20250708151502.561-4-alireza.sanaee@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250711_022851_410132_E9A377EB X-CRM114-Status: GOOD ( 15.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 8 Jul 2025 16:15:00 +0100 Alireza Sanaee wrote: > Use the newly created API to grab CPU id. > > Signed-off-by: Alireza Sanaee > --- > .../hwtracing/coresight/coresight-cti-platform.c | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-platform.c b/drivers/hwtracing/coresight/coresight-cti-platform.c > index d0ae10bf6128..e1dc559d54aa 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-platform.c > +++ b/drivers/hwtracing/coresight/coresight-cti-platform.c > @@ -41,20 +41,8 @@ > */ > static int of_cti_get_cpu_at_node(const struct device_node *node) > { > - int cpu; > - struct device_node *dn; > + int cpu = of_cpu_phandle_to_id(node, NULL, 0); Could do a single line - kind of down to coresight maintainers preference though! return (of_cpu_phandle_to_id(node, NULL, 0) < 0) ? -1; cpu; +CC Suzuki (you got the two reviewers in the +CC but not the maintainer) > > - if (node == NULL) > - return -1; > - > - dn = of_parse_phandle(node, "cpu", 0); > - /* CTI affinity defaults to no cpu */ > - if (!dn) > - return -1; > - cpu = of_cpu_node_to_id(dn); > - of_node_put(dn); > - > - /* No Affinity if no cpu nodes are found */ > return (cpu < 0) ? -1 : cpu; > } >