From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A9E3C83F1A for ; Fri, 11 Jul 2025 10:10:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mkuoHcD1+i00Q6PyG1ktlAcSybgSWSLAzIQlmH3AajY=; b=46BM6tqObrCLdWpB/KPaWPbo87 IF5A6cxUP4xSsJ1lJE3R248cdsz8zOPvTR0q806rnH/yaL2uFCiADGTabnn6qsIKoeCh38CQCeA16 LF/3y+FJW53Zw2KPj1PkqCwE7ZrbsQhD0YjgOgDSEC12/HRqwzjA9M1QrHLTV14wIHmSGJRCqYaM0 l10Axo7PiH3MoQzTBJbngujgUxcMh5yt2UUJeG9MAXCowzawUnTVYp6DFrvvLqf9rirMnqIFb2Gn7 Rtnot3XZA31whIaGgpdZBS/7pjdvhoLqsBuPC/9pTzkx8JWx6MxVirp+jcNFcFsaKZHiMxJ8iJBcr USc+rFAQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uaAhv-0000000ERzQ-2Lbd; Fri, 11 Jul 2025 10:10:19 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uaA5k-0000000EJWt-13Nz for linux-arm-kernel@lists.infradead.org; Fri, 11 Jul 2025 09:30:53 +0000 Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4bdmdX0nZxz6GBQk; Fri, 11 Jul 2025 17:29:52 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 970991402EF; Fri, 11 Jul 2025 17:30:46 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 11 Jul 2025 11:30:45 +0200 Date: Fri, 11 Jul 2025 10:30:44 +0100 From: Jonathan Cameron To: Alireza Sanaee CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v2 4/5] coresight: Use of_cpu_phandle_to_id for grabbing CPU id Message-ID: <20250711103044.000024f0@huawei.com> In-Reply-To: <20250708151502.561-5-alireza.sanaee@huawei.com> References: <20250708151502.561-1-alireza.sanaee@huawei.com> <20250708151502.561-5-alireza.sanaee@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml100002.china.huawei.com (7.191.160.241) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250711_023052_436939_C830F71B X-CRM114-Status: GOOD ( 13.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 8 Jul 2025 16:15:01 +0100 Alireza Sanaee wrote: > Use the newly created API to grab CPU id. > > Signed-off-by: Alireza Sanaee Reviewed-by: Jonathan Cameron We could just squash this to the call site, however it is in an if / else if with the much larger acpi equivalent call so probably worth keeping this trivial helper. > --- > drivers/hwtracing/coresight/coresight-platform.c | 15 +-------------- > 1 file changed, 1 insertion(+), 14 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c > index 0db64c5f4995..95d46ea08936 100644 > --- a/drivers/hwtracing/coresight/coresight-platform.c > +++ b/drivers/hwtracing/coresight/coresight-platform.c > @@ -167,20 +167,7 @@ of_coresight_get_output_ports_node(const struct device_node *node) > > static int of_coresight_get_cpu(struct device *dev) > { > - int cpu; > - struct device_node *dn; > - > - if (!dev->of_node) > - return -ENODEV; > - > - dn = of_parse_phandle(dev->of_node, "cpu", 0); > - if (!dn) > - return -ENODEV; > - > - cpu = of_cpu_node_to_id(dn); > - of_node_put(dn); > - > - return cpu; > + return of_cpu_phandle_to_id(dev->of_node, NULL, 0); > } > > /*