Re: [PATCH v3 5/6] coresight: Use of_cpu_phandle_to_id for grabbing CPU ID

Mike Leach
2025-07-18T13:01:55Z

On Fri, 18 Jul 2025 at 10:51, Alireza Sanaee <alireza.sanaee@huawei.com> wrote:
>
> Use the newly created API (of_cpu_phandle_to_id) to grab CPU ID.
>
> Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
> Signed-off-by: Alireza Sanaee <alireza.sanaee@huawei.com>
> ---
> drivers/hwtracing/coresight/coresight-platform.c | 15 +--------------
> 1 file changed, 1 insertion(+), 14 deletions(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c
> index 0db64c5f4995..95d46ea08936 100644
> --- a/drivers/hwtracing/coresight/coresight-platform.c
> +++ b/drivers/hwtracing/coresight/coresight-platform.c
> @@ -167,20 +167,7 @@ of_coresight_get_output_ports_node(const struct device_node *node)
>
> static int of_coresight_get_cpu(struct device *dev)
> {
> - int cpu;
> - struct device_node *dn;
> -
> - if (!dev->of_node)
> - return -ENODEV;
> -
> - dn = of_parse_phandle(dev->of_node, "cpu", 0);
> - if (!dn)
> - return -ENODEV;
> -
> - cpu = of_cpu_node_to_id(dn);
> - of_node_put(dn);
> -
> - return cpu;
> + return of_cpu_phandle_to_id(dev->of_node, NULL, 0);
> }
>
> /*
> --
> 2.43.0
>

Reviewed-by: Mike Leach <mike.leach@linaro.org>

--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK