From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
atenart@kernel.org, linux-crypto@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: add crypto offload support on MT7981
Date: Mon, 21 Jul 2025 11:36:08 +0200 [thread overview]
Message-ID: <20250721-camouflaged-dramatic-rattlesnake-e7f87f@kuoka> (raw)
In-Reply-To: <20250720174903.1321533-2-olek2@wp.pl>
On Sun, Jul 20, 2025 at 07:49:03PM +0200, Aleksander Jan Bajkowski wrote:
> The MT7981 as well as the MT7986 have a built-in EIP-97 crypto accelerator.
> This commit adds the missing entry in the dts.
>
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
> ---
> arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> index 5cbea9cd411f..ebab8dde1e70 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> @@ -94,6 +94,20 @@ pwm@10048000 {
> #pwm-cells = <2>;
> };
>
> + crypto@10320000 {
> + compatible = "inside-secure,safexcel-eip97";
Missing SoC compatible. You should not use IP block compatibles alone
and your previous patch explains why: some wires can be connected
differently.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-21 10:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-20 17:49 [PATCH 1/2] dt-bindings: crypto: inside-secure,safexcel: make eip/mem IRQ optional Aleksander Jan Bajkowski
2025-07-20 17:49 ` [PATCH 2/2] arm64: dts: mediatek: add crypto offload support on MT7981 Aleksander Jan Bajkowski
2025-07-21 9:36 ` Krzysztof Kozlowski [this message]
2025-07-21 9:35 ` [PATCH 1/2] dt-bindings: crypto: inside-secure,safexcel: make eip/mem IRQ optional Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250721-camouflaged-dramatic-rattlesnake-e7f87f@kuoka \
--to=krzk@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=atenart@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=olek2@wp.pl \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox