Re: [PATCH v2 3/4] dt-bindings: ufs: mediatek,ufs: add MT8195 compatible and update clock nodes

Peter Wang (王信友)
2025-07-23T10:02:35Z

On Tue, 2025-07-22 at 11:39 +0200, AngeloGioacchino Del Regno wrote:
>
> The unipro mp_bclk really is the ufs-sap clock; besides, the standard
> has clocks
> for both TX and RX symbols - and also MT8195 (and also MT6991,
> MT8196, and others)
> UFS controller do have both TX and RX symbol clocks.
>
> Besides, you're also missing the crypto clocks for UFS, which brings
> the count to
> 12 total clocks for MT8195.

> Please, look at my old submission, which actually fixes the
> compatibles other than
> adding the right clocks for all UFS controllers in MediaTek
> platforms.
>
> https://lore.kernel.org/all/20240612074309.50278-1-angelogioacchino.delregno@collabora.com/
>

Hi Angelo,

The clock architecture may vary depending on the platform.
These clock patch look good to me.

> I want to take the occasion to remind everyone that my fixes were
> discarded because
> the MediaTek UFS driver maintainer wants to keep the low quality of
> the driver in
> favor of easier downstream porting - which is *not* in any way
> adhering to quality
> standards that the Linux community deserves.
>
> Cheers,
> Angelo

I want to clarify that I am not opposing this in order to keep the
low quality of the driver for the sake of easier downstream porting.
My objection is purely due to the quality of this patch:
https://lore.kernel.org/all/eb47587159484abca8e6d65dddcf0844822ce99f.camel@mediatek.com/
Originally, this could have been a simple matter handled by a single
DTS setting,
but this patch requires checking a bunch of DTS voltage settings.
This increases the complexity of the boot process, and I don't see any
benefit from it.

Even though I think the other patches look good to me, I haven't seen
any new ones uploaded.
I would like to reiterate that I welcome any upstream contributions
related to Linux UFS on MediaTek platforms.

Thanks
Peter