From: Krzysztof Kozlowski <krzk@kernel.org>
To: rentao.bupt@gmail.com
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew@lunn.ch>, Tao Ren <taoren@meta.com>
Subject: Re: [PATCH v3 07/13] ARM: dts: aspeed: Add Facebook Wedge400-data64 (AST2500) BMC
Date: Thu, 24 Jul 2025 10:05:40 +0200 [thread overview]
Message-ID: <20250724-overjoyed-panther-from-camelot-f2ff4f@kuoka> (raw)
In-Reply-To: <20250723233013.142337-8-rentao.bupt@gmail.com>
On Wed, Jul 23, 2025 at 04:30:03PM -0700, rentao.bupt@gmail.com wrote:
> + /*
> + * PCA9548 (11-0076) provides 8 channels connecting to
> + * FCM (Fan Controller Module).
> + */
> + i2c32 = &imux32;
> + i2c33 = &imux33;
> + i2c34 = &imux34;
> + i2c35 = &imux35;
> + i2c36 = &imux36;
> + i2c37 = &imux37;
> + i2c38 = &imux38;
> + i2c39 = &imux39;
> +
> + spi2 = &spi_gpio;
> + };
> +
> + chosen {
> + stdout-path = &uart1;
> + bootargs = "console=ttyS0,9600n8 root=/dev/ram rw";
Drop bootargs. You are duplicating stdout path and choice of root is
definitely not a mainline user friendly.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-24 9:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 23:29 [PATCH v3 00/13] ARM: dts: aspeed: Add Meta Darwin dts rentao.bupt
2025-07-23 23:29 ` [PATCH v3 01/13] ARM: dts: aspeed: wedge400: Fix DTB warnings rentao.bupt
2025-07-23 23:29 ` [PATCH v3 02/13] ARM: dts: aspeed: fuji: " rentao.bupt
2025-07-23 23:29 ` [PATCH v3 03/13] ARM: dts: aspeed: Fix DTB warnings in ast2600-facebook-netbmc-common.dtsi rentao.bupt
2025-07-23 23:30 ` [PATCH v3 04/13] ARM: dts: aspeed: Move eMMC out of ast2600-facebook-netbmc-common.dtsi rentao.bupt
2025-07-23 23:30 ` [PATCH v3 05/13] ARM: dts: aspeed: Add facebook-bmc-flash-layout-128-data64.dtsi rentao.bupt
2025-07-23 23:30 ` [PATCH v3 06/13] dt-bindings: arm: aspeed: add Facebook Wedge400-data64 board rentao.bupt
2025-07-24 10:03 ` Krzysztof Kozlowski
2025-07-23 23:30 ` [PATCH v3 07/13] ARM: dts: aspeed: Add Facebook Wedge400-data64 (AST2500) BMC rentao.bupt
2025-07-24 8:05 ` Krzysztof Kozlowski [this message]
2025-07-25 5:20 ` Tao Ren
2025-07-23 23:30 ` [PATCH v3 08/13] ARM: dts: aspeed: wedge400: Include wedge400-data64.dts rentao.bupt
2025-07-23 23:30 ` [PATCH v3 09/13] dt-bindings: arm: aspeed: add Facebook Fuji-data64 board rentao.bupt
2025-07-23 23:30 ` [PATCH v3 10/13] ARM: dts: aspeed: Add Facebook Fuji-data64 (AST2600) Board rentao.bupt
2025-07-24 0:03 ` Andrew Lunn
2025-07-24 1:03 ` Tao Ren
2025-07-24 12:53 ` Andrew Lunn
2025-07-25 5:18 ` Tao Ren
2025-07-27 5:57 ` Tao Ren
2025-07-27 15:45 ` Andrew Lunn
2025-07-28 5:34 ` Tao Ren
2025-07-23 23:30 ` [PATCH v3 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts rentao.bupt
2025-07-23 23:30 ` [PATCH v3 12/13] dt-bindings: arm: aspeed: add Facebook Darwin board rentao.bupt
2025-07-23 23:30 ` [PATCH v3 13/13] ARM: dts: aspeed: Add Facebook Darwin (AST2600) BMC rentao.bupt
2025-07-23 23:44 ` [PATCH v3 00/13] ARM: dts: aspeed: Add Meta Darwin dts Tao Ren
2025-07-25 3:19 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250724-overjoyed-panther-from-camelot-f2ff4f@kuoka \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rentao.bupt@gmail.com \
--cc=robh@kernel.org \
--cc=taoren@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).