From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 711B4C87FC5 for ; Thu, 24 Jul 2025 22:33:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=AiltF6+KJNHeRSKXUsFzRhJVyiqLqaN5MJ+Nzk+Ij9o=; b=R2W6iixSUffti/veUUyoGiE8gV j4L/LxBsdN95hvi2J3ZJNp0IORRdSyXDO1Tp6KqZr4QtktrUPp7U1TfGUibLSSslIjU4qfK1yBf2O TRLDNjf4XhgHnc0ypFilyqdfVi2BSbc4ingsc7Yn01xiV1522naS030BIWH8zuwzojjuI1B0HpX8A ZJqpSxPdPuW7qujGECy5jvAqhu4Wc82RR1c+d0YwrlOkSJW9Pbdflx0XNxjjusVx3a5i6EeHjGc0s O75H4K7qYvr8imaoxG7nru3At91o3FgQXbWtoXMDqfGqZDmvRohpKKtIodUXBufPgFbkTkrxGOkIq 8MhyA1+Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uf4Ur-00000008bOI-260e; Thu, 24 Jul 2025 22:33:05 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uf4DV-00000008ZTC-3pTy for linux-arm-kernel@lists.infradead.org; Thu, 24 Jul 2025 22:15:11 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 78DE4169; Fri, 25 Jul 2025 00:14:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1753395268; bh=wnDieMEk7I0tE4d8tFbRvCZXpUeQxwW/lMFB5n8RFBg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iIKxAq8NUNohSczhCUHjFjYjqGXvzOVyJgHf8JfWyG1deUVOrNEMGVQtTRSy2Gndc 2Sg3ej8KtZL7H49g0cjQdnvEkPeMXmVH26rENhDo520m1dlD7IT579WdFLK5tOkZQr 8evCoDc4SwrI+mq5D6iovJFdU1TD5D3YBx8Nb1m4= Date: Fri, 25 Jul 2025 01:15:04 +0300 From: Laurent Pinchart To: Frank.Li@nxp.com Cc: Mauro Carvalho Chehab , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alice Yuan Subject: Re: [PATCH v3 1/4] dt-bindings: media: add i.MX parallel CPI support Message-ID: <20250724221504.GB17890@pendragon.ideasonboard.com> References: <20250708-imx8qxp_pcam-v3-0-c8533e405df1@nxp.com> <20250708-imx8qxp_pcam-v3-1-c8533e405df1@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250708-imx8qxp_pcam-v3-1-c8533e405df1@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250724_151510_095135_95378BB4 X-CRM114-Status: GOOD ( 21.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, On Tue, Jul 08, 2025 at 01:48:42PM -0400, Frank Li via B4 Relay wrote: > From: Alice Yuan > > Document the binding for parallel CPI controller found in i.MX8QXP, i.MX93 > and i.MX91 SoCs. > > Signed-off-by: Alice Yuan > Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart > --- > Change in v3: > - use enum at compatible string > - add ref to video-interfaces.yaml# > - use cpi as node name in examples. > - replace csi (Camera Serial Interface) with CPI (Camera Parallel Interface) > in commit message. > > Change in v2: > - use pcif surfix as Laurent Pinchart's suggest. > - put power-domains into required list > --- > .../devicetree/bindings/media/fsl,imx93-pcif.yaml | 126 +++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 127 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/fsl,imx93-pcif.yaml b/Documentation/devicetree/bindings/media/fsl,imx93-pcif.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..f92e9af371c91636cef42e48573198d4ea5e15f5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/fsl,imx93-pcif.yaml > @@ -0,0 +1,126 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/fsl,imx93-pcif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX8/9 Parallel Camera Interface > + > +maintainers: > + - Frank Li > + > +description: | > + This is device node for the Parallel Camera Interface which enables the > + chip to connect directly to external Parallel CMOS image sensors. > + Supports up to 80MHz input clock from sensor. > + Supports the following input data formats > + - 8-bit/10-bit Camera Sensor Interface (CSI) > + - 8-bit data port for RGB, YCbCr, and YUV data input > + - 8-bit/10-bit data ports for Bayer data input > + Parallel Camera Interface is hooked to the Imaging subsystem via the > + Pixel Link. > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx8qxp-pcif > + - fsl,imx93-pcif > + - items: > + - enum: > + - fsl,imx91-pcif > + - const: fsl,imx93-pcif > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: pixel > + - const: ipg > + > + power-domains: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false > + description: Input port node. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-type: > + const: 5 > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + unevaluatedProperties: false > + description: Output port node. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-type: > + const: 5 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - power-domains > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + cpi@4ac10070 { > + compatible = "fsl,imx93-pcif"; > + reg = <0x4ac10070 0x10>; > + clocks = <&clk IMX93_CLK_MIPI_CSI_GATE>, > + <&clk IMX93_CLK_MEDIA_APB>; > + clock-names = "pixel", "ipg"; > + assigned-clocks = <&clk IMX93_CLK_CAM_PIX>; > + assigned-clock-parents = <&clk IMX93_CLK_VIDEO_PLL>; > + assigned-clock-rates = <140000000>; > + power-domains = <&media_blk_ctrl IMX93_MEDIABLK_PD_MIPI_CSI>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + endpoint { > + remote-endpoint = <&mt9m114_ep>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + endpoint { > + remote-endpoint = <&isi_in>; > + }; > + }; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 8dc0f6609d1fe2e3eefd50088dbe566d9e107bfa..8ae0667d2bb41fb6a1549bd3b2b33f326cbd1303 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -15107,6 +15107,7 @@ L: linux-media@vger.kernel.org > S: Maintained > T: git git://linuxtv.org/media.git > F: Documentation/admin-guide/media/imx7.rst > +F: Documentation/devicetree/bindings/media/fsl,imx93-pcif.yaml > F: Documentation/devicetree/bindings/media/nxp,imx-mipi-csi2.yaml > F: Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > F: Documentation/devicetree/bindings/media/nxp,imx8mq-mipi-csi2.yaml -- Regards, Laurent Pinchart