Re: [net-next v16 04/12] net: mtip: The L2 switch driver for imx287

Jakub Kicinski
2025-07-26T20:44:00Z

On Sat, 26 Jul 2025 22:13:23 +0200 Lukasz Majewski wrote:
> > > + ret = register_netdev(fep->ndev[i]);
> > > + if (ret) {
> > > + dev_err(&fep->ndev[i]->dev,
> > > + "%s: ndev %s register err: %d\n",
> > > __func__,
> > > + fep->ndev[i]->name, ret);
> > > + break;
> > > + }
> >
> > Error handling in case of register_netdev() still buggy, AFAICT.
>
> I've added the code to set fep->ndev[i] = NULL to mtip_ndev_cleanup().
> IMHO this is the correct place to add it.

If register_netdev() fails you will try to unregister it and hit
a BUG_ON().