Re: [net-next v16 04/12] net: mtip: The L2 switch driver for imx287

Lukasz Majewski
2025-07-26T20:16:22Z

[-- Attachment #1: Type: text/plain, Size: 1435 bytes --]

Hi Jakub,

> On Fri, 25 Jul 2025 00:33:10 +0200 Lukasz Majewski wrote:
> > + for (i = 0; i < SWITCH_EPORT_NUMBER; i++) {
> > + fep->ndev[i] = alloc_netdev(sizeof(struct
> > mtip_ndev_priv),
> > + fep->ndev_name[i],
> > NET_NAME_USER,
> > + ether_setup);
> > + if (!fep->ndev[i]) {
> > + ret = -ENOMEM;
> > + break;
> > + }
> > +
> > + fep->ndev[i]->ethtool_ops = &mtip_ethtool_ops;
> > + fep->ndev[i]->netdev_ops = &mtip_netdev_ops;
> > + SET_NETDEV_DEV(fep->ndev[i], &pdev->dev);
> > +
> > + priv = netdev_priv(fep->ndev[i]);
> > + priv->dev = fep->ndev[i];
> > + priv->fep = fep;
> > + priv->portnum = i + 1;
> > + fep->ndev[i]->irq = fep->irq;
> > +
> > + mtip_setup_mac(fep->ndev[i]);
> > +
> > + ret = register_netdev(fep->ndev[i]);
> > + if (ret) {
> > + dev_err(&fep->ndev[i]->dev,
> > + "%s: ndev %s register err: %d\n",
> > __func__,
> > + fep->ndev[i]->name, ret);
> > + break;
> > + }
>
> Error handling in case of register_netdev() still buggy, AFAICT.

I've added the code to set fep->ndev[i] = NULL to mtip_ndev_cleanup().
IMHO this is the correct place to add it.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Johanna Denk,
Tabea Lutz HRB 165235 Munich, Office: Kirchenstr.5, D-82194
Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]