From: Jonathan Cameron <jic23@kernel.org>
To: Sanjay Suthar <sanjaysuthar661996@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, ribalda@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, neil.armstrong@linaro.org,
khilman@baylibre.com, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com
Subject: Re: [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs
Date: Sun, 27 Jul 2025 14:08:28 +0100 [thread overview]
Message-ID: <20250727140828.4893fc51@jic23-huawei> (raw)
In-Reply-To: <8f4358e8-ecd6-4d86-8326-25d21c3a4ea2@gmail.com>
On Thu, 24 Jul 2025 22:38:14 +0530
Sanjay Suthar <sanjaysuthar661996@gmail.com> wrote:
> On 24/07/25 15:42, Jonathan Cameron wrote:
> > On Tue, 22 Jul 2025 22:35:13 +0530
> > Sanjay Suthar <sanjaysuthar661996@gmail.com> wrote:
> >
> >> Fix minor grammatical issues by removing duplicated "is" in two devicetree
> >> binding documents:
> >>
> >> - net/amlogic,meson-dwmac.yaml
> >> - iio/dac/ti,dac7612.yaml
> >>
> >> Signed-off-by: Sanjay Suthar <sanjaysuthar661996@gmail.com>
> > I'd have no problem with the argument that this can go through either
> > tree if there was any interaction between the files or the changes, but
> > here there isn't. This is just causing potential mess if either tree ends
> > up with other changes overlapping this for no benefit. Please split into
> > two patches, one for each subsystem. You should be fine to keep the
> > various tags given here for the new patches.
>
> Thanks for the review. I understand your concern regarding splitting the
> changes. My intention was that, since the fix is a trivial and identical
> grammatical correction across both subsystems, it didn’t seem necessary
> to separate them.
>
> However, I’m open to either approach — keeping it as a single patch or
> splitting it if that's preferred. As I’m still new to this process, I’ll
> defer to @krzysztof and the DT maintainers for the final call on how
> this should be handled.
>
> Please let me know the preferred direction, and I’ll be happy to update
> accordingly.
DT bindings ultimately go through the subsystem trees (in vast majority of
cases) to avoid churn issues and keep them aligned with driver changes.
So split it.
Thanks
Jonathan
>
> Best regards,
>
> Sanjay Suthar
>
prev parent reply other threads:[~2025-07-27 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-22 17:05 [PATCH v3] dt-bindings: cleanup: fix duplicated 'is is' in YAML docs Sanjay Suthar
2025-07-22 19:38 ` Martin Blumenstingl
2025-07-23 16:29 ` Sanjay Suthar
2025-07-23 19:41 ` Martin Blumenstingl
2025-07-23 7:42 ` Krzysztof Kozlowski
2025-07-23 16:34 ` Sanjay Suthar
2025-07-23 23:46 ` Jakub Kicinski
2025-07-24 10:12 ` Jonathan Cameron
2025-07-24 17:08 ` Sanjay Suthar
2025-07-27 13:08 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250727140828.4893fc51@jic23-huawei \
--to=jic23@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=edumazet@google.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=pabeni@redhat.com \
--cc=ribalda@kernel.org \
--cc=robh@kernel.org \
--cc=sanjaysuthar661996@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox