public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: t.figa@samsung.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DT: if dt is available don't use s3c_arch_init
Date: Mon, 23 Sep 2013 14:37:22 +0200	[thread overview]
Message-ID: <2025079.MVbFYJdokX@amdc1227> (raw)
In-Reply-To: <1379931289-29384-1-git-send-email-m.krawczuk@partner.samsung.com>

Hi Mateusz,

On Monday 23 of September 2013 12:14:49 Mateusz Krawczuk wrote:
> It prevents from executing platform code, when booting from device tree.
> 
> Signed-off-by: Mateusz Krawczuk <m.krawczuk@partner.samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/plat-samsung/init.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/plat-samsung/init.c b/arch/arm/plat-samsung/init.c
> index aa9511b..0ace02d 100644
> --- a/arch/arm/plat-samsung/init.c
> +++ b/arch/arm/plat-samsung/init.c
> @@ -20,6 +20,7 @@
>  #include <linux/module.h>
>  #include <linux/interrupt.h>
>  #include <linux/ioport.h>
> +#include <linux/of.h>
>  #include <linux/serial_core.h>
>  #include <linux/platform_device.h>
>  #include <linux/of.h>
> @@ -152,6 +153,8 @@ static int __init s3c_arch_init(void)
>  {
>  	int ret;
> 
> +	if (of_have_populated_dt())
> +		return 0;

I'm not sure if this is the correct thing to do here (note platforms that 
still want this initialization to be handled, even when booting with DT).

The DT case is already handled several lines below in if (cpu == NULL) 
check and if your platform requires this initialization not to happen you 
should assure it has cpu == NULL.

Best regards,
Tomasz

  parent reply	other threads:[~2013-09-23 12:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-23 10:14 [PATCH] DT: if dt is available don't use s3c_arch_init Mateusz Krawczuk
2013-09-23 10:28 ` Sachin Kamat
2013-09-23 12:37 ` Tomasz Figa [this message]
2013-09-26  3:56   ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025079.MVbFYJdokX@amdc1227 \
    --to=t.figa@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox