linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Julien Massot <julien.massot@collabora.com>
To: kernel@collabora.com, Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Ikjoon Jang <ikjn@chromium.org>,
	 Enric Balletbo i Serra <eballetbo@kernel.org>,
	 Chen-Yu Tsai <wenst@chromium.org>,
	Weiyi Lu <weiyi.lu@mediatek.com>,
	 Eugen Hristev <eugen.hristev@linaro.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	 Julien Massot <jmassot@collabora.com>,
	Sean Wang <sean.wang@kernel.org>,
	 Linus Walleij <linus.walleij@linaro.org>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	 linux-mediatek@lists.infradead.org, linux-sound@vger.kernel.org,
	 linux-gpio@vger.kernel.org,
	Julien Massot <julien.massot@collabora.com>
Subject: [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values
Date: Fri, 01 Aug 2025 13:18:10 +0200	[thread overview]
Message-ID: <20250801-mtk-dtb-warnings-v1-8-6ba4e432427b@collabora.com> (raw)
In-Reply-To: <20250801-mtk-dtb-warnings-v1-0-6ba4e432427b@collabora.com>

The properties `mediatek,pull-up-adv` and `mediatek,pull-down-adv`
were using incorrect values like `<10>` and `<01>`. These values
are parsed as decimal (10 and 1 respectively), not binary.

However, the driver interprets these as bitfields:
  - BIT(0): R0
  - BIT(1): R1

So valid values are:
  - 0 => no pull
  - 1 => enable R0
  - 2 => enable R1
  - 3 => enable R0 + R1

Using `<10>` is invalid as it exceeds the accepted range.
It was likely intended as binary `0b10` (i.e., `2`),
to enable R1 only.

This patch replaces incorrect values with the correct ones
and removes the leading zero from `<01>` to avoid confusion
with bitfield notation.

Signed-off-by: Julien Massot <julien.massot@collabora.com>
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 400c61d1103561db6ee0fb2d2e1c157529d03206..02bdfdb8e53c87dba0ba0024e0c69fcee825552b 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -574,19 +574,19 @@ pins-cmd-dat {
 				 <PINMUX_GPIO122__FUNC_MSDC0_CMD>;
 			input-enable;
 			drive-strength = <MTK_DRIVE_14mA>;
-			mediatek,pull-up-adv = <01>;
+			mediatek,pull-up-adv = <1>;
 		};
 
 		pins-clk {
 			pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
 			drive-strength = <MTK_DRIVE_14mA>;
-			mediatek,pull-down-adv = <10>;
+			mediatek,pull-down-adv = <2>;
 		};
 
 		pins-rst {
 			pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
 			drive-strength = <MTK_DRIVE_14mA>;
-			mediatek,pull-down-adv = <01>;
+			mediatek,pull-down-adv = <1>;
 		};
 	};
 
@@ -603,25 +603,25 @@ pins-cmd-dat {
 				 <PINMUX_GPIO122__FUNC_MSDC0_CMD>;
 			input-enable;
 			drive-strength = <MTK_DRIVE_14mA>;
-			mediatek,pull-up-adv = <01>;
+			mediatek,pull-up-adv = <1>;
 		};
 
 		pins-clk {
 			pinmux = <PINMUX_GPIO124__FUNC_MSDC0_CLK>;
 			drive-strength = <MTK_DRIVE_14mA>;
-			mediatek,pull-down-adv = <10>;
+			mediatek,pull-down-adv = <2>;
 		};
 
 		pins-ds {
 			pinmux = <PINMUX_GPIO131__FUNC_MSDC0_DSL>;
 			drive-strength = <MTK_DRIVE_14mA>;
-			mediatek,pull-down-adv = <10>;
+			mediatek,pull-down-adv = <2>;
 		};
 
 		pins-rst {
 			pinmux = <PINMUX_GPIO133__FUNC_MSDC0_RSTB>;
 			drive-strength = <MTK_DRIVE_14mA>;
-			mediatek,pull-up-adv = <01>;
+			mediatek,pull-up-adv = <1>;
 		};
 	};
 
@@ -633,13 +633,13 @@ pins-cmd-dat {
 				 <PINMUX_GPIO33__FUNC_MSDC1_DAT2>,
 				 <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
 			input-enable;
-			mediatek,pull-up-adv = <10>;
+			mediatek,pull-up-adv = <2>;
 		};
 
 		pins-clk {
 			pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
 			input-enable;
-			mediatek,pull-down-adv = <10>;
+			mediatek,pull-down-adv = <2>;
 		};
 	};
 
@@ -652,13 +652,13 @@ pins-cmd-dat {
 				 <PINMUX_GPIO30__FUNC_MSDC1_DAT3>;
 			drive-strength = <6>;
 			input-enable;
-			mediatek,pull-up-adv = <10>;
+			mediatek,pull-up-adv = <2>;
 		};
 
 		pins-clk {
 			pinmux = <PINMUX_GPIO29__FUNC_MSDC1_CLK>;
 			drive-strength = <8>;
-			mediatek,pull-down-adv = <10>;
+			mediatek,pull-down-adv = <2>;
 			input-enable;
 		};
 	};

-- 
2.50.1



  parent reply	other threads:[~2025-08-01 11:42 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-01 11:18 [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Julien Massot
2025-08-01 11:18 ` [PATCH 1/9] dt-bindings: clock: mediatek: Add power-domains property Julien Massot
2025-08-01 17:19   ` Rob Herring (Arm)
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-20 13:27     ` Julien Massot
2025-08-01 11:18 ` [PATCH 2/9] dt-bindings: arm: mediatek: Support mt8183-audiosys binding variant Julien Massot
2025-08-01 17:21   ` Rob Herring
2025-08-20 13:28     ` Julien Massot
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-20 13:30     ` Julien Massot
2025-08-01 11:18 ` [PATCH 3/9] arm64: dts: mt8183: Rename nodes to match audiosys binding schema Julien Massot
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 4/9] ASoc: dt-binding: Convert mt8183-afe-pcm binding to YAML Julien Massot
2025-08-01 17:26   ` Rob Herring
2025-08-20 13:32     ` Julien Massot
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 5/9] dt-bindings: sound: Convert MT8183 DA7219 sound card bindings " Julien Massot
2025-08-01 17:28   ` Rob Herring
2025-08-20 13:33     ` Julien Massot
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 6/9] ASoC: dt-binding: Convert MediaTek mt8183-mt6358 " Julien Massot
2025-08-01 17:29   ` Rob Herring
2025-08-20 13:34     ` Julien Massot
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-01 11:18 ` [PATCH 7/9] dt-bindings: pinctrl: mediatek: mt8183: Allow gpio-line-names Julien Massot
2025-08-01 17:30   ` Rob Herring (Arm)
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-18 15:16   ` Linus Walleij
2025-08-01 11:18 ` Julien Massot [this message]
2025-08-04  7:59   ` [PATCH 8/9] arm64: dts: mediatek: mt8183-kukui: Fix pull-down/up-adv values AngeloGioacchino Del Regno
2025-08-06  6:38   ` Chen-Yu Tsai
2025-08-18 15:22     ` Linus Walleij
2025-08-19  5:27       ` Chen-Yu Tsai
2025-08-19  5:29         ` Chen-Yu Tsai
2025-08-19  9:12           ` Julien Massot
2025-08-01 11:18 ` [PATCH 9/9] arm64: dts: mediatek: mt8183-pumkin: " Julien Massot
2025-08-04  7:59   ` AngeloGioacchino Del Regno
2025-08-01 13:26 ` [PATCH 0/9] MediaTek devicetree/bindings warnings sanitization second round Rob Herring (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250801-mtk-dtb-warnings-v1-8-6ba4e432427b@collabora.com \
    --to=julien.massot@collabora.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=eballetbo@kernel.org \
    --cc=eugen.hristev@linaro.org \
    --cc=ikjn@chromium.org \
    --cc=jmassot@collabora.com \
    --cc=kernel@collabora.com \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sean.wang@kernel.org \
    --cc=weiyi.lu@mediatek.com \
    --cc=wenst@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).