From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E12E2C87FCA for ; Fri, 1 Aug 2025 17:34:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+DtLqWt0RH6iO3+9BYod+1Nz6NKvB/x/ipIsyCwJyeM=; b=ir7mxc+l6WNTDdy7kUWnQRPm5q dOaxwE5LNGNMF8fgg6BJrCCEPbm24e0PH5tWdvvP1PuvXIgmn74GK96CrSGeIB4xPxOEhueRP+5Py aEolIcynnRENZ/dG8c7L1wip9jwzE/OPo2VN6D6RQa8BrdKmpadtQHcyw/NhpkrjjbI4gNc4vgwyF 1lzfOmOp8JbbYPP9Mmcb67sFOH283j0gwM8x7gP/UYOPwKjsVcWiC3PZmIfC/krxwH5kxXpOEvZou 7gkpsVmmBmEpQkrj+IYBGFx4C932zLtdR2ANYe3w9czhZCnSVKc/oMmSjPFWmK1t6rnAG8w6+OCKq jkCNjIkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uhteX-00000006YY1-27Ri; Fri, 01 Aug 2025 17:34:45 +0000 Received: from relay6-d.mail.gandi.net ([217.70.183.198]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uhtDG-00000006V1N-3pkG for linux-arm-kernel@lists.infradead.org; Fri, 01 Aug 2025 17:06:36 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 6B36341C7B; Fri, 1 Aug 2025 17:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1754067992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+DtLqWt0RH6iO3+9BYod+1Nz6NKvB/x/ipIsyCwJyeM=; b=kVsDcI8tVIZ9az8Z9IFImwbP5Qu3o6qq2cTADnSkorOVDY4EngMnIk4bFJ2a9/spFrA5E0 +iC+/G8ADzx+FgI+CJTm+qRQ2GLSFSCjI3wR42jdEJwlrRFmhGI6ARYvaK+V+cN8Lhm4c6 RVqpldFYVspDn8ra5DPAh2rdDBr+IHifVzakXLZns3yAk/brFZEzbiN/4Rv94f/4DedQ66 CsRYU91YPB2tzxkfPpfbkNcyOU0wbONthpqD0gQ/yB1Xhqu0v8sE2V+wyCK/t6xRMsY2g5 Mc8kAZa1+1nIBviTXmz+nyv+Xyo5PCaZ7tmZYRzYBlIO+Lf89Jo8811+aeiziw== Date: Fri, 1 Aug 2025 19:06:25 +0200 From: Luca Ceresoli To: Maxime Ripard Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Tomi Valkeinen , Philipp Zabel , Hui Pu , Thomas Petazzoni , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/9] drm/omapdrm: use drm_bridge_chain_get_last_bridge() Message-ID: <20250801190625.7b9f5f50@booty> In-Reply-To: <20250725-holistic-ambrosial-jellyfish-f41f6b@houat> References: <20250709-drm-bridge-alloc-getput-drm_bridge_get_next_bridge-v1-0-48920b9cf369@bootlin.com> <20250709-drm-bridge-alloc-getput-drm_bridge_get_next_bridge-v1-4-48920b9cf369@bootlin.com> <20250710-daffy-mini-booby-574fca@houat> <20250714123240.16d8dcb1@booty> <20250725-holistic-ambrosial-jellyfish-f41f6b@houat> Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddutdegvdehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpefnuhgtrgcuvegvrhgvshholhhiuceolhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgeelffefgfehhfdtvdefueefieevkefggfelkeeiudetkeektedvhedukefgvddvnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppedvrgdtvdemieejtdemvddtvddtmegvrgdtudemsggvgedumeelhegvjeemfeegfeemledufegvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddvmeeijedtmedvtddvtdemvggrtddumegsvgegudemleehvgejmeefgeefmeeludefvgdphhgvlhhopegsohhothihpdhmrghilhhfrhhomheplhhutggrrdgtvghrvghsohhlihessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepvdegpdhrtghpthhtohepmhhrihhprghrugeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoheprghnughriigvjhdrhhgrjhgurgesihhnthgvlhdrtghomhdprhgtphhtthhopehnvghilhdrrghrmhhsthhrohhngheslhhinhgrr hhordhorhhgpdhrtghpthhtoheprhhfohhssheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepnfgruhhrvghnthdrphhinhgthhgrrhhtsehiuggvrghsohhnsghorghrugdrtghomhdprhgtphhtthhopehjohhnrghssehkfihisghoohdrshgvpdhrtghpthhtohepjhgvrhhnvghjrdhskhhrrggsvggtsehgmhgrihhlrdgtohhmpdhrtghpthhtohepmhgrrghrthgvnhdrlhgrnhhkhhhorhhstheslhhinhhugidrihhnthgvlhdrtghomh X-GND-Sasl: luca.ceresoli@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250801_100635_090559_12A3DD24 X-CRM114-Status: GOOD ( 30.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Fri, 25 Jul 2025 16:15:23 +0200 Maxime Ripard wrote: > On Mon, Jul 14, 2025 at 12:32:40PM +0200, Luca Ceresoli wrote: > > Hi Maxime, > > > > On Thu, 10 Jul 2025 09:13:46 +0200 > > Maxime Ripard wrote: > > > > > On Wed, Jul 09, 2025 at 06:48:03PM +0200, Luca Ceresoli wrote: > > > > Use drm_bridge_chain_get_last_bridge() instead of open coding a loop with > > > > two invocations of drm_bridge_get_next_bridge() per iteration. > > > > > > > > Besides being cleaner and more efficient, this change is necessary in > > > > preparation for drm_bridge_get_next_bridge() to get a reference to the > > > > returned bridge. > > > > > > > > Signed-off-by: Luca Ceresoli > > > > --- > > > > drivers/gpu/drm/omapdrm/omap_drv.c | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c > > > > index 054b71dba6a75b8c42198c4b102a093f43a675a2..3bbcec01428a6f290afdfa40ef6f79629539a584 100644 > > > > --- a/drivers/gpu/drm/omapdrm/omap_drv.c > > > > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c > > > > @@ -378,12 +378,12 @@ static int omap_display_id(struct omap_dss_device *output) > > > > struct device_node *node = NULL; > > > > > > > > if (output->bridge) { > > > > - struct drm_bridge *bridge = output->bridge; > > > > - > > > > - while (drm_bridge_get_next_bridge(bridge)) > > > > - bridge = drm_bridge_get_next_bridge(bridge); > > > > + struct drm_bridge *bridge = > > > > + drm_bridge_chain_get_last_bridge(output->bridge->encoder); > > > > > > > > node = bridge->of_node; > > > > + > > > > + drm_bridge_put(bridge); > > > > > > Any reason you're not using __free(drm_bridge_put) here? > > > > Just because the code is simple enough that an explicit > > drm_bridge_put() is clearly sufficient. > > > > Do you think __free() should be used even in such trivial cases? > > It's a matter of opinion at this point :) > > It' makes it a bit easier and consistent so that's why I raised it, but > if you feel like it's too much, that's fine by me as well. In the end I chose to use __free here as well for v2, for consistency over the series. Luca -- Luca Ceresoli, Bootlin Embedded Linux and Kernel engineering https://bootlin.com