[PATCH 0/4] ARM: dts: aspeed: Convert remaining ASRock systems to NVMEM layout syntax

[PATCH 0/4] ARM: dts: aspeed: Convert remaining ASRock systems to NVMEM layout syntax

[Tan Siewert]

Hi,

While investigating an issue with an ASRock Rack platform, I noticed
that most of the ASPEED device trees using NVMEM cells to populate
MAC addresses still rely on a deprecated NVMEM binding syntax.
As a result, the MAC addresses are not populated from the
device tree/NVMEM cells properly, and an address from "the chip" is
being used instead.

Commit 76c5533925434 ("ARM: dts: aspeed: convert ASRock SPC621D8HM3
NVMEM content to layout syntax") was the only system that had previously
been converted to the new layout syntax.

This patch series converts all remaining ASRock Rack systems in the ASPEED
device trees to use the new NVMEM layout syntax.

Tan Siewert (4):
  ARM: dts: aspeed: e3c246d4i: convert NVMEM content to layout syntax
  ARM: dts: aspeed: e3c256d4i: convert NVMEM content to layout syntax
  ARM: dts: aspeed: romed8hm3: convert NVMEM content to layout syntax
  ARM: dts: aspeed: x570d4u: convert NVMEM content to layout syntax

 .../dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dts | 12 ++++++++----
 .../dts/aspeed/aspeed-bmc-asrock-e3c256d4i.dts | 12 ++++++++----
 .../dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts | 12 ++++++++----
 .../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts   | 18 +++++++++++-------
 4 files changed, 35 insertions(+), 19 deletions(-)

-- 
2.43.0

[PATCH 1/4] ARM: dts: aspeed: e3c246d4i: convert NVMEM content to layout syntax

[Tan Siewert]

The used bindings syntax has been deprecated and doesn't work properly
anymore.

Use the newer (and non-deprecated) fixed-layout approach. See commit
bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
details.

Signed-off-by: Tan Siewert <tan@siewert.io>
---
 .../boot/dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dts  | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dts
index 93190f4e696c..3ebd80db06f9 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dts
@@ -106,11 +106,15 @@ eeprom@57 {
 		compatible = "st,24c128", "atmel,24c128";
 		reg = <0x57>;
 		pagesize = <16>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 
-		eth0_macaddress: macaddress@3f80 {
-			reg = <0x3f80 6>;
+		nvmem-layout {
+			compatible = "fixed-layout";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			eth0_macaddress: macaddress@3f80 {
+				reg = <0x3f80 6>;
+			};
 		};
 	};
 };
-- 
2.43.0

[PATCH 2/4] ARM: dts: aspeed: e3c256d4i: convert NVMEM content to layout syntax

[Tan Siewert]

The used bindings syntax has been deprecated and doesn't work properly
anymore.

Use the newer (and non-deprecated) fixed-layout approach. See commit
bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
details.

Signed-off-by: Tan Siewert <tan@siewert.io>
---
 .../boot/dts/aspeed/aspeed-bmc-asrock-e3c256d4i.dts  | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c256d4i.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c256d4i.dts
index 9d00ce9475f2..8c57a071f488 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c256d4i.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-e3c256d4i.dts
@@ -191,11 +191,15 @@ eeprom@57 {
 		compatible = "st,24c128", "atmel,24c128";
 		reg = <0x57>;
 		pagesize = <16>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 
-		eth0_macaddress: macaddress@3f80 {
-			reg = <0x3f80 6>;
+		nvmem-layout {
+			compatible = "fixed-layout";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			eth0_macaddress: macaddress@3f80 {
+				reg = <0x3f80 6>;
+			};
 		};
 	};
 };
-- 
2.43.0

[PATCH 3/4] ARM: dts: aspeed: romed8hm3: convert NVMEM content to layout syntax

[Tan Siewert]

The used bindings syntax has been deprecated and doesn't work properly
anymore.

Use the newer (and non-deprecated) fixed-layout approach. See commit
bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
details.

Signed-off-by: Tan Siewert <tan@siewert.io>
---
 .../boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts  | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
index 6dd221644dc6..e306655ce4a3 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts
@@ -134,11 +134,15 @@ eeprom@50 {
 		compatible = "st,24c128", "atmel,24c128";
 		reg = <0x50>;
 		pagesize = <16>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 
-		eth0_macaddress: macaddress@3f80 {
-			reg = <0x3f80 6>;
+		nvmem-layout {
+			compatible = "fixed-layout";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			eth0_macaddress: macaddress@3f80 {
+				reg = <0x3f80 6>;
+			};
 		};
 	};
 };
-- 
2.43.0

[PATCH 4/4] ARM: dts: aspeed: x570d4u: convert NVMEM content to layout syntax

[Tan Siewert]

The used bindings syntax has been deprecated and doesn't work properly
anymore.

Use the newer (and non-deprecated) fixed-layout approach. See commit
bd912c991d2e ("dt-bindings: nvmem: layouts: add fixed-layout") for
details.

Signed-off-by: Tan Siewert <tan@siewert.io>
---
 .../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts   | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts
index 0943e0bf1305..e61a6cb43438 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-asrock-x570d4u.dts
@@ -232,15 +232,19 @@ eeprom@57 {
 		compatible = "st,24c128", "atmel,24c128";
 		reg = <0x57>;
 		pagesize = <16>;
-		#address-cells = <1>;
-		#size-cells = <1>;
 
-		eth0_macaddress: macaddress@3f80 {
-			reg = <0x3f80 6>;
-		};
+		nvmem-layout {
+			compatible = "fixed-layout";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			eth0_macaddress: macaddress@3f80 {
+				reg = <0x3f80 6>;
+			};
 
-		eth1_macaddress: macaddress@3f88 {
-			reg = <0x3f88 6>;
+			eth1_macaddress: macaddress@3f88 {
+				reg = <0x3f88 6>;
+			};
 		};
 	};
 };
-- 
2.43.0

Re: [PATCH 0/4] ARM: dts: aspeed: Convert remaining ASRock systems to NVMEM layout syntax

[Zev Weiss]

On Sun, Aug 03, 2025 at 08:18:16AM PDT, Tan Siewert wrote:
>Hi,
>
>While investigating an issue with an ASRock Rack platform, I noticed
>that most of the ASPEED device trees using NVMEM cells to populate
>MAC addresses still rely on a deprecated NVMEM binding syntax.
>As a result, the MAC addresses are not populated from the
>device tree/NVMEM cells properly, and an address from "the chip" is
>being used instead.
>
>Commit 76c5533925434 ("ARM: dts: aspeed: convert ASRock SPC621D8HM3
>NVMEM content to layout syntax") was the only system that had previously
>been converted to the new layout syntax.
>
>This patch series converts all remaining ASRock Rack systems in the ASPEED
>device trees to use the new NVMEM layout syntax.
>
>Tan Siewert (4):
>  ARM: dts: aspeed: e3c246d4i: convert NVMEM content to layout syntax
>  ARM: dts: aspeed: e3c256d4i: convert NVMEM content to layout syntax
>  ARM: dts: aspeed: romed8hm3: convert NVMEM content to layout syntax
>  ARM: dts: aspeed: x570d4u: convert NVMEM content to layout syntax
>
> .../dts/aspeed/aspeed-bmc-asrock-e3c246d4i.dts | 12 ++++++++----
> .../dts/aspeed/aspeed-bmc-asrock-e3c256d4i.dts | 12 ++++++++----
> .../dts/aspeed/aspeed-bmc-asrock-romed8hm3.dts | 12 ++++++++----
> .../dts/aspeed/aspeed-bmc-asrock-x570d4u.dts   | 18 +++++++++++-------
> 4 files changed, 35 insertions(+), 19 deletions(-)
>
>-- 
>2.43.0
>
>

For the series,

Reviewed-by: Zev Weiss <zev@bewilderbeest.net>

Thanks Tan!

Re: [PATCH 0/4] ARM: dts: aspeed: Convert remaining ASRock systems to NVMEM layout syntax

[Andrew Jeffery]

On Sun, 03 Aug 2025 17:18:16 +0200, Tan Siewert wrote:
> While investigating an issue with an ASRock Rack platform, I noticed
> that most of the ASPEED device trees using NVMEM cells to populate
> MAC addresses still rely on a deprecated NVMEM binding syntax.
> As a result, the MAC addresses are not populated from the
> device tree/NVMEM cells properly, and an address from "the chip" is
> being used instead.
> 
> [...]

Thanks, I've applied this to the BMC tree.

-- 
Andrew Jeffery <andrew@codeconstruct.com.au>