From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Waqar Hameed" <waqar.hameed@axis.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Cosmin Tanislav" <cosmin.tanislav@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Matteo Martelli" <matteomartelli3@gmail.com>,
"Heiko Stuebner" <heiko@sntech.de>,
"Francesco Dolcini" <francesco@dolcini.it>,
"João Paulo Gonçalves" <jpaulo.silvagoncalves@gmail.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Subhajit Ghosh" <subhajit.ghosh@tweaklogic.com>,
"Mudit Sharma" <muditsharma.info@gmail.com>,
"Gerald Loacker" <gerald.loacker@wolfvision.net>,
"Song Qiang" <songqiang1304521@gmail.com>,
"Crt Mori" <cmo@melexis.com>,
kernel@axis.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v2] iio: Remove error prints for devm_add_action_or_reset()
Date: Sat, 9 Aug 2025 21:00:01 +0100 [thread overview]
Message-ID: <20250809210001.4d8af4cd@jic23-huawei> (raw)
In-Reply-To: <CAHp75VeGvgv6TAYRRtEySmESkjygW79ms-Yd64h08_+7JjJMJw@mail.gmail.com>
On Tue, 5 Aug 2025 15:06:02 +0200
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Tue, Aug 5, 2025 at 11:33 AM Waqar Hameed <waqar.hameed@axis.com> wrote:
> >
> > When `devm_add_action_or_reset()` fails, it is due to a failed memory
> > allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
> > anything when error is `-ENOMEM`. Therefore, remove the useless call to
> > `dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
> > return the value instead.
>
> Even more, the devm has tracepoints in case somebody really wants to
> investigate failures.
>
> Fully in support of this change.
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
Applied to the testing branch of iio.git. I'll rebase that
on rc1 once available.
Jonathan
next prev parent reply other threads:[~2025-08-09 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 9:33 [PATCH v2] iio: Remove error prints for devm_add_action_or_reset() Waqar Hameed
2025-08-05 13:06 ` Andy Shevchenko
2025-08-09 20:00 ` Jonathan Cameron [this message]
2025-08-05 16:08 ` Nuno Sá
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250809210001.4d8af4cd@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cmo@melexis.com \
--cc=cosmin.tanislav@analog.com \
--cc=dlechner@baylibre.com \
--cc=francesco@dolcini.it \
--cc=gerald.loacker@wolfvision.net \
--cc=heiko@sntech.de \
--cc=hvilleneuve@dimonoff.com \
--cc=jpaulo.silvagoncalves@gmail.com \
--cc=kernel@axis.com \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=matteomartelli3@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=muditsharma.info@gmail.com \
--cc=nuno.sa@analog.com \
--cc=songqiang1304521@gmail.com \
--cc=subhajit.ghosh@tweaklogic.com \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox