linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Nick Chan <towinchenmi@gmail.com>
To: Will Deacon <will@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Catalin Marinas <catalin.marinas@arm.com>,
	Janne Grunau <j@jannau.net>,
	 Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Neal Gompa <neal@gompa.dev>,  Sven Peter <sven@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	 linux-perf-users@vger.kernel.org, devicetree@vger.kernel.org,
	 asahi@lists.linux.dev, linux-kernel@vger.kernel.org,
	 Nick Chan <towinchenmi@gmail.com>
Subject: [PATCH v8 02/21] drivers/perf: apple_m1: Only init PMUv3 remap when EL2 is available
Date: Mon, 11 Aug 2025 21:54:34 +0800	[thread overview]
Message-ID: <20250811-apple-cpmu-v8-2-c560ebd9ca46@gmail.com> (raw)
In-Reply-To: <20250811-apple-cpmu-v8-0-c560ebd9ca46@gmail.com>

The events in the Apple A7 PMU is very different from the ones in M1, and
EL2 is not available on Apple A7. Instead of assigning the wrong PMUv3
remap on A7 or declaring a new PMUv3 remap that would never be used in
practice, skip initializing PMUv3 remap altogther when EL2 is unavailable.

Signed-off-by: Nick Chan <towinchenmi@gmail.com>
---
 drivers/perf/apple_m1_cpu_pmu.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/perf/apple_m1_cpu_pmu.c b/drivers/perf/apple_m1_cpu_pmu.c
index 81b6f1a623499566ef04d04075752f34e2cb6a92..f3948528e28e0189efd0f17fde0d808930d936af 100644
--- a/drivers/perf/apple_m1_cpu_pmu.c
+++ b/drivers/perf/apple_m1_cpu_pmu.c
@@ -645,8 +645,10 @@ static int m1_pmu_init(struct arm_pmu *cpu_pmu, u32 flags)
 	cpu_pmu->reset		  = m1_pmu_reset;
 	cpu_pmu->set_event_filter = m1_pmu_set_event_filter;
 
-	cpu_pmu->map_pmuv3_event  = m1_pmu_map_pmuv3_event;
-	m1_pmu_init_pmceid(cpu_pmu);
+	if (is_hyp_mode_available()) {
+		cpu_pmu->map_pmuv3_event  = m1_pmu_map_pmuv3_event;
+		m1_pmu_init_pmceid(cpu_pmu);
+	}
 
 	bitmap_set(cpu_pmu->cntr_mask, 0, M1_PMU_NR_COUNTERS);
 	cpu_pmu->attr_groups[ARMPMU_ATTR_GROUP_EVENTS] = &m1_pmu_events_attr_group;

-- 
2.50.1



  parent reply	other threads:[~2025-08-11 14:52 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 13:54 [PATCH v8 00/21] drivers/perf: apple_m1: Add Apple A7-A11, T2 SoC support Nick Chan
2025-08-11 13:54 ` [PATCH v8 01/21] dt-bindings: arm: pmu: Add Apple A7-A11 SoC CPU PMU compatibles Nick Chan
2025-08-11 13:54 ` Nick Chan [this message]
2025-08-11 13:54 ` [PATCH v8 03/21] drivers/perf: apple_m1: Support per-implementation event tables Nick Chan
2025-08-11 13:54 ` [PATCH v8 04/21] drivers/perf: apple_m1: Support a per-implementation number of counters Nick Chan
2025-08-11 13:54 ` [PATCH v8 05/21] drivers/perf: apple_m1: Support configuring counters for 32-bit EL0 Nick Chan
2025-08-11 13:54 ` [PATCH v8 06/21] drivers/perf: apple_m1: Support per-implementation PMU startup Nick Chan
2025-08-11 13:54 ` [PATCH v8 07/21] drivers/perf: apple_m1: Support per-implementation event attr group Nick Chan
2025-08-11 13:54 ` [PATCH v8 08/21] drivers/perf: apple_m1: Add Apple A7 support Nick Chan
2025-08-11 13:54 ` [PATCH v8 09/21] drivers/perf: apple_m1: Add Apple A8/A8X support Nick Chan
2025-08-11 13:54 ` [PATCH v8 10/21] drivers/perf: apple_m1: Add A9/A9X support Nick Chan
2025-08-11 13:54 ` [PATCH v8 11/21] drivers/perf: apple_m1: Add Apple A10/A10X/T2 Support Nick Chan
2025-08-11 13:54 ` [PATCH v8 12/21] drivers/perf: apple_m1: Add Apple A11 Support Nick Chan
2025-08-11 13:54 ` [PATCH v8 13/21] arm64: dts: apple: s5l8960x: Add CPU PMU nodes Nick Chan
2025-08-11 13:54 ` [PATCH v8 14/21] arm64: dts: apple: t7000: " Nick Chan
2025-08-11 13:54 ` [PATCH v8 15/21] arm64: dts: apple: t7001: " Nick Chan
2025-08-11 13:54 ` [PATCH v8 16/21] arm64: dts: apple: s800-0-3: " Nick Chan
2025-08-11 13:54 ` [PATCH v8 17/21] arm64: dts: apple: s8001: " Nick Chan
2025-08-11 13:54 ` [PATCH v8 18/21] arm64: dts: apple: t8010: " Nick Chan
2025-08-11 13:54 ` [PATCH v8 19/21] arm64: dts: apple: t8011: " Nick Chan
2025-08-11 13:54 ` [PATCH v8 20/21] arm64: dts: apple: t8012: " Nick Chan
2025-08-11 13:54 ` [PATCH v8 21/21] arm64: dts: apple: t8015: " Nick Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250811-apple-cpmu-v8-2-c560ebd9ca46@gmail.com \
    --to=towinchenmi@gmail.com \
    --cc=alyssa@rosenzweig.io \
    --cc=asahi@lists.linux.dev \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j@jannau.net \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=neal@gompa.dev \
    --cc=robh@kernel.org \
    --cc=sven@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).