Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Jeremy Linton <jeremy.linton@arm.com>
Cc: "Christoph Lameter (Ampere)" <cl@gentwo.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Huang Shijie <shijie@os.amperecomputing.com>,
	catalin.marinas@arm.com, will@kernel.org,
	patches@amperecomputing.com, Shubhang@os.amperecomputing.com,
	krzysztof.kozlowski@linaro.org, bjorn.andersson@oss.qualcomm.com,
	geert+renesas@glider.be, arnd@arndb.de, nm@ti.com,
	ebiggers@kernel.org, nfraprado@collabora.com,
	prabhakar.mahadev-lad.rj@bp.renesas.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: defconfig: enable CONFIG_SCHED_CLUSTER
Date: Wed, 13 Aug 2025 10:28:47 +0100	[thread overview]
Message-ID: <20250813-gifted-nimble-wildcat-6cdf65@sudeepholla> (raw)
In-Reply-To: <2d9259e4-1b58-435d-bf02-9c4badd52fd9@arm.com>

On Tue, Aug 12, 2025 at 12:32:36PM -0500, Jeremy Linton wrote:
> On 8/12/25 11:33 AM, Christoph Lameter (Ampere) wrote:
> > On Mon, 11 Aug 2025, Jeremy Linton wrote:
> > 
> > >  From what I've seen, SCHED_CLUSTER seems to be a bit of give and take
> > > depending on benchmark and machine. I'm not sure if it should be default
> > > enabled or not, but it would really be nice to have at least a larger sweep of
> > > benchmarks/machines in order to be sure of the decision.
> > 
> > If the hardware provides a clusterid then I think this clusterid should be
> > used for the sched domains. CONFIG_SCHED_CLUSTER does that. So it should
> > be the default.
> 
> Hi,
> 
> The problem is that this information is being sourced from the ACPI PPTT.
> The ACPI specification (AFAIK) doesn't define a cluster, so the linux
> cluster information is being 'invented' based on however the firmware vendor
> choose to group CPU nodes in the PPTT. Which means its possible for them to
> unknowingly create clusters, or also fail to create them when they make
> sense.

+1, completely agree. As Jeremy mentioned, it is hit or miss and cluster
is loosely defined and IIRC Huawei pushed this based on their platform at
the time and it did break some benchmarks on few other platforms. So it
is not a good idea to make it default config IMO.

-- 
Regards,
Sudeep


  reply	other threads:[~2025-08-13  9:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08  2:55 [PATCH] arm64: defconfig: enable CONFIG_SCHED_CLUSTER Huang Shijie
2025-08-11 15:13 ` Jeremy Linton
2025-08-12  3:05   ` Shijie Huang
2025-08-12 16:33   ` Christoph Lameter (Ampere)
2025-08-12 17:32     ` Jeremy Linton
2025-08-13  9:28       ` Sudeep Holla [this message]
2025-08-13 15:55         ` Christoph Lameter (Ampere)
2025-08-13 22:56           ` Christoph Lameter (Ampere)
2025-08-14 10:03             ` Sudeep Holla
2025-08-14 16:30               ` Christoph Lameter (Ampere)
2025-08-15 10:48                 ` Sudeep Holla
2025-08-15 16:46                   ` Jeremy Linton
2025-08-18  9:33                     ` Sudeep Holla
2025-08-20 23:44                       ` Christoph Lameter (Ampere)
2025-08-21 12:11                         ` Sudeep Holla
2026-01-20 22:59                           ` Ankur Arora
2025-08-27  2:33                       ` Shijie Huang
2025-08-27 10:19                         ` Sudeep Holla
2025-08-14 10:07           ` Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250813-gifted-nimble-wildcat-6cdf65@sudeepholla \
    --to=sudeep.holla@arm.com \
    --cc=Shubhang@os.amperecomputing.com \
    --cc=arnd@arndb.de \
    --cc=bjorn.andersson@oss.qualcomm.com \
    --cc=catalin.marinas@arm.com \
    --cc=cl@gentwo.org \
    --cc=ebiggers@kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=jeremy.linton@arm.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfraprado@collabora.com \
    --cc=nm@ti.com \
    --cc=patches@amperecomputing.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=shijie@os.amperecomputing.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox