From: Conor Dooley <conor@kernel.org>
To: Alex Elder <elder@riscstar.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
dlan@gentoo.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com, lkundrak@v3.sk,
devicetree@vger.kernel.org, linux-serial@vger.kernel.org,
spacemit@lists.linux.dev, linux-mediatek@lists.infradead.org,
linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names
Date: Wed, 13 Aug 2025 17:51:28 +0100 [thread overview]
Message-ID: <20250813-squint-glass-b68c6520a229@spud> (raw)
In-Reply-To: <20250813031338.2328392-1-elder@riscstar.com>
[-- Attachment #1: Type: text/plain, Size: 1456 bytes --]
On Tue, Aug 12, 2025 at 10:13:35PM -0500, Alex Elder wrote:
> There are two compatible strings defined in "8250.yaml" that require
> two clocks to be specified, along with their names:
> - "spacemit,k1-uart", used in "spacemit/k1.dtsi"
> - "nxp,lpc1850-uart", used in "lpc/lpc18xx.dtsi"
>
> When only one clock is used, the name is not required. However there
> are two places that do specify a name:
> - In "mediatek/mt7623.dtsi", the clock for the "mediatek,mtk-btif"
> compatible serial device is named "main"
> - In "qca/ar9132.dtsi", the clock for the "ns8250" compatible
> serial device is named "uart"
>
> In commit d2db0d7815444 ("dt-bindings: serial: 8250: allow clock
> 'uartclk' and 'reg' for nxp,lpc1850-uart"), Frank Li added the
> restriction that two named clocks be used for the NXP platform
> mentioned above.
>
> Change that logic, so that an additional condition for (only) the
> SpacemiT platform similarly restricts the two clocks to have the
> names "core" and "bus".
>
> Finally, add "main" and "uart" as allowed names when a single clock is
> specified.
>
> Fixes: 2c0594f9f0629 ("dt-bindings: serial: 8250: support an optional second clock")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202507160314.wrC51lXX-lkp@intel.com/
> Signed-off-by: Alex Elder <elder@riscstar.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2025-08-13 18:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 3:13 [PATCH v2] dt-bindings: serial: 8250: allow "main" and "uart" as clock names Alex Elder
2025-08-13 16:51 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250813-squint-glass-b68c6520a229@spud \
--to=conor@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=elder@riscstar.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkundrak@v3.sk \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox