* [PATCH] phy: rockchip: naneng-combphy: Convert comma to semicolon
@ 2025-08-14 1:39 Chen Ni
2025-08-20 17:02 ` (subset) " Vinod Koul
0 siblings, 1 reply; 2+ messages in thread
From: Chen Ni @ 2025-08-14 1:39 UTC (permalink / raw)
To: vkoul, kishon, heiko
Cc: linux-phy, linux-arm-kernel, linux-rockchip, linux-kernel,
Chen Ni
Replace comma between expressions with semicolons.
Using a ',' in place of a ';' can have unintended side effects.
Although that is not the case here, it is seems best to use ';'
unless ',' is intended.
Found by inspection.
No functional change intended.
Compile tested only.
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
index 0d25872e6712..a3ef19807b9e 100644
--- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
@@ -1252,7 +1252,7 @@ static int rk3588_combphy_cfg(struct rockchip_combphy_priv *priv)
writel(val, priv->mmio + RK3568_PHYREG15);
/* Set PLL KVCO fine tuning signals. */
- val = RK3568_PHYREG33_PLL_KVCO_VALUE << RK3568_PHYREG33_PLL_KVCO_SHIFT,
+ val = RK3568_PHYREG33_PLL_KVCO_VALUE << RK3568_PHYREG33_PLL_KVCO_SHIFT;
rockchip_combphy_updatel(priv, RK3568_PHYREG33_PLL_KVCO_MASK, val, RK3568_PHYREG33);
/* Enable controlling random jitter. */
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] phy: rockchip: naneng-combphy: Convert comma to semicolon
2025-08-14 1:39 [PATCH] phy: rockchip: naneng-combphy: Convert comma to semicolon Chen Ni
@ 2025-08-20 17:02 ` Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2025-08-20 17:02 UTC (permalink / raw)
To: kishon, heiko, Chen Ni
Cc: linux-phy, linux-arm-kernel, linux-rockchip, linux-kernel
On Thu, 14 Aug 2025 09:39:43 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
>
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
>
> Found by inspection.
> No functional change intended.
> Compile tested only.
>
> [...]
Applied, thanks!
[1/1] phy: rockchip: naneng-combphy: Convert comma to semicolon
commit: a8f9de937dbf7bdabda72bd0c51e201e550129c2
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-20 23:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-14 1:39 [PATCH] phy: rockchip: naneng-combphy: Convert comma to semicolon Chen Ni
2025-08-20 17:02 ` (subset) " Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).