* [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR
@ 2025-08-14 16:40 Linus Walleij
2025-08-14 16:40 ` [PATCH 1/3] dt-bindings: Add Actiontec vendor prefix Linus Walleij
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Linus Walleij @ 2025-08-14 16:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
Imre Kaloz
Cc: devicetree, linux-arm-kernel, Linus Walleij
This patch series adds device trees for Actiontec MI424WR
versions A, C and D.
These routers are quite common in the Americas and uses
the IXP4xx SoC.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Linus Walleij (3):
dt-bindings: Add Actiontec vendor prefix
dt-bindings: arm: List actiontec devices
ARM: dts: Add ixp4xx Actiontec MI424WR device trees
.../devicetree/bindings/arm/intel-ixp4xx.yaml | 2 +
.../devicetree/bindings/vendor-prefixes.yaml | 2 +
arch/arm/boot/dts/intel/ixp/Makefile | 2 +
.../ixp/intel-ixp42x-actiontec-mi424wr-ac.dts | 37 +++
.../intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dts | 38 +++
.../intel/ixp/intel-ixp42x-actiontec-mi424wr.dtsi | 273 +++++++++++++++++++++
6 files changed, 354 insertions(+)
---
base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
change-id: 20250814-ixp4xx-mi424wr-dts-afef5c00d68d
Best regards,
--
Linus Walleij <linus.walleij@linaro.org>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/3] dt-bindings: Add Actiontec vendor prefix
2025-08-14 16:40 [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Linus Walleij
@ 2025-08-14 16:40 ` Linus Walleij
2025-08-14 20:46 ` Conor Dooley
2025-08-14 16:40 ` [PATCH 2/3] dt-bindings: arm: List actiontec devices Linus Walleij
` (2 subsequent siblings)
3 siblings, 1 reply; 12+ messages in thread
From: Linus Walleij @ 2025-08-14 16:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
Imre Kaloz
Cc: devicetree, linux-arm-kernel, Linus Walleij
Actiontec is a US manufacturer of telecom equipment.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 77160cd47f54079a39f35b570d69f7c4c2274724..a0abe9e39291eb687793d1b4b4187524a004a413 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -48,6 +48,8 @@ patternProperties:
description: Acme Systems srl
"^actions,.*":
description: Actions Semiconductor Co., Ltd.
+ "^actiontec,.*":
+ description: Actiontec Electronics, Inc
"^active-semi,.*":
description: Active-Semi International Inc
"^ad,.*":
--
2.50.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/3] dt-bindings: arm: List actiontec devices
2025-08-14 16:40 [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Linus Walleij
2025-08-14 16:40 ` [PATCH 1/3] dt-bindings: Add Actiontec vendor prefix Linus Walleij
@ 2025-08-14 16:40 ` Linus Walleij
2025-08-14 20:46 ` Conor Dooley
` (2 more replies)
2025-08-14 16:40 ` [PATCH 3/3] ARM: dts: Add ixp4xx Actiontec MI424WR device trees Linus Walleij
2025-08-15 21:19 ` [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Rob Herring (Arm)
3 siblings, 3 replies; 12+ messages in thread
From: Linus Walleij @ 2025-08-14 16:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
Imre Kaloz
Cc: devicetree, linux-arm-kernel, Linus Walleij
One two IXP4xx device families from OpenWrts backlog:
Actiontec MI424WR revision A/C and revision D, both
of these are IXP4xx devices.
Revisions E and later use different chipsets.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
index d60792b1d995f909f621b3326e62d19223f6683c..b7b430896596aacb792983d8538b84f389cc5bd1 100644
--- a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
+++ b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
@@ -16,6 +16,8 @@ properties:
oneOf:
- items:
- enum:
+ - actiontec,mi424wr-ac
+ - actiontec,mi424wr-d
- adieng,coyote
- arcom,vulcan
- dlink,dsm-g600-a
--
2.50.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 3/3] ARM: dts: Add ixp4xx Actiontec MI424WR device trees
2025-08-14 16:40 [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Linus Walleij
2025-08-14 16:40 ` [PATCH 1/3] dt-bindings: Add Actiontec vendor prefix Linus Walleij
2025-08-14 16:40 ` [PATCH 2/3] dt-bindings: arm: List actiontec devices Linus Walleij
@ 2025-08-14 16:40 ` Linus Walleij
2025-08-14 21:13 ` Florian Fainelli
2025-08-15 21:19 ` [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Rob Herring (Arm)
3 siblings, 1 reply; 12+ messages in thread
From: Linus Walleij @ 2025-08-14 16:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
Imre Kaloz
Cc: devicetree, linux-arm-kernel, Linus Walleij
The Actiontex MI424WR is a pretty widespread home router, made
in many different revisions.
Revisions A, C and D are based on IXP42x. We add a device tree
for the A/C variant and one for the D variant as these differ in
the location of the WAN PHY on the MDIO bus, and the ethernet
interfaces for the WAN PHY and the DSA switch are switched around.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/boot/dts/intel/ixp/Makefile | 2 +
.../ixp/intel-ixp42x-actiontec-mi424wr-ac.dts | 37 +++
.../intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dts | 38 +++
.../intel/ixp/intel-ixp42x-actiontec-mi424wr.dtsi | 273 +++++++++++++++++++++
4 files changed, 350 insertions(+)
diff --git a/arch/arm/boot/dts/intel/ixp/Makefile b/arch/arm/boot/dts/intel/ixp/Makefile
index ab8525f1ea1d25abe72fca4dd323d97e2d3c5bb4..cb30d8d55016fbe00848242d9d1a017f7e48c6db 100644
--- a/arch/arm/boot/dts/intel/ixp/Makefile
+++ b/arch/arm/boot/dts/intel/ixp/Makefile
@@ -1,5 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
dtb-$(CONFIG_ARCH_IXP4XX) += \
+ intel-ixp42x-actiontec-mi424wr-ac.dtb \
+ intel-ixp42x-actiontec-mi424wr-d.dtb \
intel-ixp42x-linksys-nslu2.dtb \
intel-ixp42x-linksys-wrv54g.dtb \
intel-ixp42x-freecom-fsg-3.dtb \
diff --git a/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-ac.dts b/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-ac.dts
new file mode 100644
index 0000000000000000000000000000000000000000..413b9255f9e3cf24fd1dde6a300a8295e3fdee0f
--- /dev/null
+++ b/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-ac.dts
@@ -0,0 +1,37 @@
+// SPDX-License-Identifier: ISC
+/*
+ * Device Tree file for the IXP425-based Actiontec MI424WR revision A and C
+ * Based on a board file from OpenWrt by Jose Vasconcellos.
+ */
+
+/dts-v1/;
+
+#include "intel-ixp42x-actiontec-mi424wr.dtsi"
+
+/ {
+ model = "Actiontec MI424WR rev A/C";
+ compatible = "actiontec,mi424wr-ac", "intel,ixp42x";
+
+ soc {
+ /* EthB used for WAN */
+ ethernet@c8009000 {
+ phy-handle = <&phy17>; // 17 on revision A-C
+
+ mdio {
+ phy17: ethernet-phy@17 {
+ /* WAN */
+ reg = <17>;
+ };
+ };
+ };
+
+ /* EthC used for LAN */
+ ethernet@c800a000 {
+ /* Fixed link to the CPU MII port on the KS8995 */
+ fixed-link {
+ speed = <100>;
+ full-duplex;
+ };
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dts b/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dts
new file mode 100644
index 0000000000000000000000000000000000000000..3619c6411a5c04b78d32aac5f2fc0c42a99e7acd
--- /dev/null
+++ b/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dts
@@ -0,0 +1,38 @@
+// SPDX-License-Identifier: ISC
+/*
+ * Device Tree file for the IXP425-based Actiontec MI424WR revision D
+ * Based on a board file from OpenWrt by Jose Vasconcellos.
+ */
+
+/dts-v1/;
+
+#include "intel-ixp42x-actiontec-mi424wr.dtsi"
+
+/ {
+ model = "Actiontec MI424WR rev D";
+ compatible = "actiontec,mi424wr-d", "intel,ixp42x";
+
+ soc {
+ /* EthB used for LAN */
+ ethernet@c8009000 {
+ /* Fixed link to the CPU MII port on the KS8995 */
+ fixed-link {
+ speed = <100>;
+ full-duplex;
+ };
+
+ mdio {
+ /* PHY ID 0x00221450 */
+ phy5: ethernet-phy@5 {
+ /* WAN */
+ reg = <5>;
+ };
+ };
+ };
+
+ /* EthC used for WAN */
+ ethernet@c800a000 {
+ phy-handle = <&phy5>; // 5 on revision D
+ };
+ };
+};
diff --git a/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr.dtsi b/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr.dtsi
new file mode 100644
index 0000000000000000000000000000000000000000..f3712848bb2410839162efd4e85e2c88208955b9
--- /dev/null
+++ b/arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr.dtsi
@@ -0,0 +1,273 @@
+// SPDX-License-Identifier: ISC
+/*
+ * Device Tree file for the IXP425-based Actiontec MI424WR
+ * Based on a board file from OpenWrt by Jose Vasconcellos.
+ */
+
+#include "intel-ixp42x.dtsi"
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
+
+/ {
+ #address-cells = <1>;
+ #size-cells = <1>;
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x00000000 0x02000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200n8";
+ stdout-path = "uart1:115200n8";
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ led-wan-coax {
+ color = <LED_COLOR_ID_GREEN>;
+ function = "wan-coax";
+ gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ led-power-alarm {
+ color = <LED_COLOR_ID_RED>;
+ function = LED_FUNCTION_ALARM;
+ gpios = <&gpio1 0 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ led-power {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_POWER;
+ gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+ default-state = "on";
+ linux,default-trigger = "heartbeat";
+ };
+ led-wireless {
+ color = <LED_COLOR_ID_GREEN>;
+ function = LED_FUNCTION_WLAN;
+ gpios = <&gpio1 2 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ led-internet-down {
+ color = <LED_COLOR_ID_RED>;
+ function = "internet-down";
+ gpios = <&gpio1 3 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ led-internet-up {
+ color = <LED_COLOR_ID_GREEN>;
+ function = "internet-up";
+ gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ led-lan-coax {
+ color = <LED_COLOR_ID_GREEN>;
+ function = "lan-coax";
+ gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ led-wan-ethernet-alarm {
+ color = <LED_COLOR_ID_RED>;
+ function = "wan-ethernet-alarm";
+ gpios = <&gpio1 6 GPIO_ACTIVE_HIGH>;
+ default-state = "off";
+ };
+ /* The last three LEDs are not mounted but traces exist on the PCB */
+ led-phone-1 {
+ color = <LED_COLOR_ID_GREEN>;
+ function = "phone-1";
+ gpios = <&gpio1 8 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ led-phone-2 {
+ color = <LED_COLOR_ID_GREEN>;
+ function = "phone-2";
+ gpios = <&gpio1 9 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ led-voip {
+ color = <LED_COLOR_ID_GREEN>;
+ function = "voip";
+ gpios = <&gpio1 10 GPIO_ACTIVE_LOW>;
+ default-state = "off";
+ };
+ };
+
+ gpio_keys {
+ compatible = "gpio-keys";
+
+ button-reset {
+ wakeup-source;
+ linux,code = <KEY_RESTART>;
+ label = "reset";
+ gpios = <&gpio0 10 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+ spi {
+ compatible = "spi-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ sck-gpios = <&gpio0 2 GPIO_ACTIVE_HIGH>;
+ mosi-gpios = <&gpio0 4 GPIO_ACTIVE_HIGH>;
+ miso-gpios = <&gpio0 3 GPIO_ACTIVE_HIGH>;
+ cs-gpios = <&gpio0 9 GPIO_ACTIVE_LOW>;
+ num-chipselects = <1>;
+
+ ethernet-switch@0 {
+ compatible = "micrel,ks8995";
+ reg = <0>;
+ spi-max-frequency = <50000000>;
+
+ ethernet-ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ ethernet-port@0 {
+ reg = <0>;
+ label = "lan1";
+ phy-mode = "mii";
+ phy-handle = <&phy1>;
+ };
+ ethernet-port@1 {
+ reg = <1>;
+ label = "lan2";
+ phy-mode = "mii";
+ phy-handle = <&phy2>;
+ };
+ ethernet-port@2 {
+ reg = <2>;
+ label = "lan3";
+ phy-mode = "mii";
+ phy-handle = <&phy3>;
+ };
+ ethernet-port@3 {
+ reg = <3>;
+ label = "lan4";
+ phy-mode = "mii";
+ phy-handle = <&phy4>;
+ };
+ ethernet-port@4 {
+ reg = <4>;
+ ethernet = <ðc>;
+ phy-mode = "mii";
+ fixed-link {
+ speed = <100>;
+ full-duplex;
+ };
+ };
+
+ };
+ };
+ };
+
+ soc {
+ bus@c4000000 {
+ flash@0,0 {
+ compatible = "intel,ixp4xx-flash", "cfi-flash";
+ bank-width = <2>;
+ /*
+ * 8 MB of Flash in 64 0x20000 sized blocks
+ * mapped in at CS0.
+ */
+ reg = <0 0x00000000 0x0800000>;
+
+ /* Configure expansion bus to allow writes */
+ intel,ixp4xx-eb-write-enable = <1>;
+
+ partitions {
+ compatible = "redboot-fis";
+ fis-index-block = <0x3f>;
+ };
+ };
+ gpio1: gpio@1,0 {
+ /* MMIO GPIO at CS1 */
+ compatible = "brcm,bcm6345-gpio";
+ gpio-controller;
+ #gpio-cells = <2>;
+ bank-width = <2>;
+ big-endian;
+ reg = <1 0x00000000 0x2>;
+ reg-names = "dat";
+ /* Expansion bus settings */
+ intel,ixp4xx-eb-write-enable = <1>;
+
+ pci-reset-hog {
+ gpio-hog;
+ gpios = <7 GPIO_ACTIVE_HIGH>;
+ output-high;
+ line-name = "PCI reset";
+ };
+ pstn-relay-hog-1 {
+ gpio-hog;
+ gpios = <11 GPIO_ACTIVE_HIGH>;
+ output-low;
+ line-name = "PSTN relay control 1";
+ };
+ pstn-relay-hog-2 {
+ gpio-hog;
+ gpios = <12 GPIO_ACTIVE_HIGH>;
+ output-low;
+ line-name = "PSTN relay control 2";
+ };
+ };
+ };
+
+ pci@c0000000 {
+ status = "okay";
+
+ #interrupt-cells = <1>;
+ interrupt-map-mask = <0xf800 0 0 7>;
+ interrupt-map =
+ /* IDSEL 13 */
+ <0x6800 0 0 1 &gpio0 8 IRQ_TYPE_LEVEL_LOW>, /* INT A on slot 13 is irq 8 */
+ <0x6800 0 0 2 &gpio0 6 IRQ_TYPE_LEVEL_LOW>, /* INT B on slot 13 is irq 6 */
+ /* IDSEL 14 */
+ <0x7000 0 0 1 &gpio0 8 IRQ_TYPE_LEVEL_LOW>, /* INT A on slot 14 is irq 7 */
+ <0x7000 0 0 2 &gpio0 6 IRQ_TYPE_LEVEL_LOW>, /* INT B on slot 14 is irq 8 */
+ /* IDSEL 15 */
+ <0x7800 0 0 1 &gpio0 8 IRQ_TYPE_LEVEL_LOW>, /* INT A on slot 15 is irq 6 */
+ <0x7800 0 0 2 &gpio0 6 IRQ_TYPE_LEVEL_LOW>; /* INT B on slot 15 is irq 7 */
+ };
+
+ ethb: ethernet@c8009000 {
+ status = "okay";
+ queue-rx = <&qmgr 3>;
+ queue-txready = <&qmgr 20>;
+ phy-mode = "mii";
+
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ /* 1, 2, 3 and 4 are ports on the KS8995 switch */
+ phy1: ethernet-phy@1 {
+ /* LAN1 */
+ reg = <1>;
+ };
+ phy2: ethernet-phy@2 {
+ /* LAN2 */
+ reg = <2>;
+ };
+ phy3: ethernet-phy@3 {
+ /* LAN3 */
+ reg = <3>;
+ };
+ phy4: ethernet-phy@4 {
+ /* LAN4 */
+ reg = <4>;
+ };
+ };
+ };
+
+ ethc: ethernet@c800a000 {
+ status = "okay";
+ queue-rx = <&qmgr 4>;
+ queue-txready = <&qmgr 21>;
+ phy-mode = "mii";
+ };
+ };
+};
--
2.50.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] dt-bindings: arm: List actiontec devices
2025-08-14 16:40 ` [PATCH 2/3] dt-bindings: arm: List actiontec devices Linus Walleij
@ 2025-08-14 20:46 ` Conor Dooley
2025-08-14 21:03 ` Rob Herring
2025-08-14 21:04 ` Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Conor Dooley @ 2025-08-14 20:46 UTC (permalink / raw)
To: Linus Walleij
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
Imre Kaloz, devicetree, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
On Thu, Aug 14, 2025 at 06:40:04PM +0200, Linus Walleij wrote:
> One two IXP4xx device families from OpenWrts backlog:
> Actiontec MI424WR revision A/C and revision D, both
> of these are IXP4xx devices.
>
> Revisions E and later use different chipsets.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 1/3] dt-bindings: Add Actiontec vendor prefix
2025-08-14 16:40 ` [PATCH 1/3] dt-bindings: Add Actiontec vendor prefix Linus Walleij
@ 2025-08-14 20:46 ` Conor Dooley
0 siblings, 0 replies; 12+ messages in thread
From: Conor Dooley @ 2025-08-14 20:46 UTC (permalink / raw)
To: Linus Walleij
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
Imre Kaloz, devicetree, linux-arm-kernel
[-- Attachment #1: Type: text/plain, Size: 52 bytes --]
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] dt-bindings: arm: List actiontec devices
2025-08-14 16:40 ` [PATCH 2/3] dt-bindings: arm: List actiontec devices Linus Walleij
2025-08-14 20:46 ` Conor Dooley
@ 2025-08-14 21:03 ` Rob Herring
2025-08-14 21:04 ` Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2025-08-14 21:03 UTC (permalink / raw)
To: Linus Walleij
Cc: Krzysztof Kozlowski, Conor Dooley, Linus Walleij, Imre Kaloz,
devicetree, linux-arm-kernel
On Thu, Aug 14, 2025 at 06:40:04PM +0200, Linus Walleij wrote:
> One two IXP4xx device families from OpenWrts backlog:
One two?
OpenWrt's
> Actiontec MI424WR revision A/C and revision D, both
> of these are IXP4xx devices.
>
> Revisions E and later use different chipsets.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> index d60792b1d995f909f621b3326e62d19223f6683c..b7b430896596aacb792983d8538b84f389cc5bd1 100644
> --- a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> +++ b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> @@ -16,6 +16,8 @@ properties:
> oneOf:
> - items:
> - enum:
> + - actiontec,mi424wr-ac
> + - actiontec,mi424wr-d
> - adieng,coyote
> - arcom,vulcan
> - dlink,dsm-g600-a
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/3] dt-bindings: arm: List actiontec devices
2025-08-14 16:40 ` [PATCH 2/3] dt-bindings: arm: List actiontec devices Linus Walleij
2025-08-14 20:46 ` Conor Dooley
2025-08-14 21:03 ` Rob Herring
@ 2025-08-14 21:04 ` Rob Herring
2 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2025-08-14 21:04 UTC (permalink / raw)
To: Linus Walleij
Cc: Krzysztof Kozlowski, Conor Dooley, Linus Walleij, Imre Kaloz,
devicetree, linux-arm-kernel
On Thu, Aug 14, 2025 at 06:40:04PM +0200, Linus Walleij wrote:
> One two IXP4xx device families from OpenWrts backlog:
> Actiontec MI424WR revision A/C and revision D, both
> of these are IXP4xx devices.
Also, 'ixp4xx' should be in the subject.
>
> Revisions E and later use different chipsets.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> index d60792b1d995f909f621b3326e62d19223f6683c..b7b430896596aacb792983d8538b84f389cc5bd1 100644
> --- a/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> +++ b/Documentation/devicetree/bindings/arm/intel-ixp4xx.yaml
> @@ -16,6 +16,8 @@ properties:
> oneOf:
> - items:
> - enum:
> + - actiontec,mi424wr-ac
> + - actiontec,mi424wr-d
> - adieng,coyote
> - arcom,vulcan
> - dlink,dsm-g600-a
>
> --
> 2.50.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] ARM: dts: Add ixp4xx Actiontec MI424WR device trees
2025-08-14 16:40 ` [PATCH 3/3] ARM: dts: Add ixp4xx Actiontec MI424WR device trees Linus Walleij
@ 2025-08-14 21:13 ` Florian Fainelli
2025-08-15 9:09 ` Linus Walleij
0 siblings, 1 reply; 12+ messages in thread
From: Florian Fainelli @ 2025-08-14 21:13 UTC (permalink / raw)
To: Linus Walleij, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Linus Walleij, Imre Kaloz
Cc: devicetree, linux-arm-kernel
On 8/14/25 09:40, Linus Walleij wrote:
> The Actiontex MI424WR is a pretty widespread home router, made
> in many different revisions.
>
> Revisions A, C and D are based on IXP42x. We add a device tree
> for the A/C variant and one for the D variant as these differ in
> the location of the WAN PHY on the MDIO bus, and the ethernet
> interfaces for the WAN PHY and the DSA switch are switched around.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
[snip]
> + gpio1: gpio@1,0 {
> + /* MMIO GPIO at CS1 */
> + compatible = "brcm,bcm6345-gpio";
Is that really the compatible string we want to use here?
--
Florian
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 3/3] ARM: dts: Add ixp4xx Actiontec MI424WR device trees
2025-08-14 21:13 ` Florian Fainelli
@ 2025-08-15 9:09 ` Linus Walleij
0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2025-08-15 9:09 UTC (permalink / raw)
To: Florian Fainelli
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Walleij,
Imre Kaloz, devicetree, linux-arm-kernel
On Thu, Aug 14, 2025 at 11:13 PM Florian Fainelli
<florian.fainelli@broadcom.com> wrote:
> On 8/14/25 09:40, Linus Walleij wrote:
> > The Actiontex MI424WR is a pretty widespread home router, made
> > in many different revisions.
> >
> > Revisions A, C and D are based on IXP42x. We add a device tree
> > for the A/C variant and one for the D variant as these differ in
> > the location of the WAN PHY on the MDIO bus, and the ethernet
> > interfaces for the WAN PHY and the DSA switch are switched around.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
>
> [snip]
>
> > + gpio1: gpio@1,0 {
> > + /* MMIO GPIO at CS1 */
> > + compatible = "brcm,bcm6345-gpio";
>
> Is that really the compatible string we want to use here?
Yes as a matter of fact ... I got slapped for not just using compatible strings
that are ... compatible and piling up new ones :/
Maybe I should try adding a new one, I suppose just "basic-mmio"
would not be an acceptable cover-all compatible string?
I guess you're right, I should poke the DT binding people as to what
to do about this.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR
2025-08-14 16:40 [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Linus Walleij
` (2 preceding siblings ...)
2025-08-14 16:40 ` [PATCH 3/3] ARM: dts: Add ixp4xx Actiontec MI424WR device trees Linus Walleij
@ 2025-08-15 21:19 ` Rob Herring (Arm)
2025-08-19 13:14 ` Linus Walleij
3 siblings, 1 reply; 12+ messages in thread
From: Rob Herring (Arm) @ 2025-08-15 21:19 UTC (permalink / raw)
To: Linus Walleij
Cc: Conor Dooley, Linus Walleij, linux-arm-kernel,
Krzysztof Kozlowski, Imre Kaloz, devicetree
On Thu, 14 Aug 2025 18:40:02 +0200, Linus Walleij wrote:
> This patch series adds device trees for Actiontec MI424WR
> versions A, C and D.
>
> These routers are quite common in the Americas and uses
> the IXP4xx SoC.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Linus Walleij (3):
> dt-bindings: Add Actiontec vendor prefix
> dt-bindings: arm: List actiontec devices
> ARM: dts: Add ixp4xx Actiontec MI424WR device trees
>
> .../devicetree/bindings/arm/intel-ixp4xx.yaml | 2 +
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> arch/arm/boot/dts/intel/ixp/Makefile | 2 +
> .../ixp/intel-ixp42x-actiontec-mi424wr-ac.dts | 37 +++
> .../intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dts | 38 +++
> .../intel/ixp/intel-ixp42x-actiontec-mi424wr.dtsi | 273 +++++++++++++++++++++
> 6 files changed, 354 insertions(+)
> ---
> base-commit: 8f5ae30d69d7543eee0d70083daf4de8fe15d585
> change-id: 20250814-ixp4xx-mi424wr-dts-afef5c00d68d
>
> Best regards,
> --
> Linus Walleij <linus.walleij@linaro.org>
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
This patch series was applied (using b4) to base:
Base: using specified base-commit 8f5ae30d69d7543eee0d70083daf4de8fe15d585
If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)
New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/intel/' for 20250814-ixp4xx-mi424wr-dts-v1-0-b7c10f3c4193@linaro.org:
arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-ac.dtb: gpio@1,0 (brcm,bcm6345-gpio): 'bank-width', 'intel,ixp4xx-eb-write-enable', 'pci-reset-hog', 'pstn-relay-hog-1', 'pstn-relay-hog-2' do not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-mmio.yaml#
arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-ac.dtb: /soc/usb@c800b000: failed to match any schema with compatible: ['intel,ixp4xx-udc']
arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dtb: gpio@1,0 (brcm,bcm6345-gpio): 'bank-width', 'intel,ixp4xx-eb-write-enable', 'pci-reset-hog', 'pstn-relay-hog-1', 'pstn-relay-hog-2' do not match any of the regexes: '^pinctrl-[0-9]+$'
from schema $id: http://devicetree.org/schemas/gpio/gpio-mmio.yaml#
arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-d.dtb: /soc/usb@c800b000: failed to match any schema with compatible: ['intel,ixp4xx-udc']
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR
2025-08-15 21:19 ` [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Rob Herring (Arm)
@ 2025-08-19 13:14 ` Linus Walleij
0 siblings, 0 replies; 12+ messages in thread
From: Linus Walleij @ 2025-08-19 13:14 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Conor Dooley, Linus Walleij, linux-arm-kernel,
Krzysztof Kozlowski, Imre Kaloz, devicetree
On Fri, Aug 15, 2025 at 11:19 PM Rob Herring (Arm) <robh@kernel.org> wrote:
> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/intel/' for 20250814-ixp4xx-mi424wr-dts-v1-0-b7c10f3c4193@linaro.org:
>
> arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-ac.dtb: gpio@1,0 (brcm,bcm6345-gpio): 'bank-width', 'intel,ixp4xx-eb-write-enable', 'pci-reset-hog', 'pstn-relay-hog-1', 'pstn-relay-hog-2' do not match any of the regexes: '^pinctrl-[0-9]+$'
> from schema $id: http://devicetree.org/schemas/gpio/gpio-mmio.yaml#
This is an error since forever: the node is on an external bus and the
external bus while
defined in:
Documentation/devicetree/bindings/memory-controllers/intel,ixp4xx-expansion-bus-controller.yaml
Adds properties to any child, which can be any MMIO device.
I don't know what is the proper way to solve this.
A separate include .yaml for the children and then pull that into
every possible device on that bus?
> arch/arm/boot/dts/intel/ixp/intel-ixp42x-actiontec-mi424wr-ac.dtb: /soc/usb@c800b000: failed to match any schema with compatible: ['intel,ixp4xx-udc']
OK I should write that yaml file.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2025-08-19 18:13 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-14 16:40 [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Linus Walleij
2025-08-14 16:40 ` [PATCH 1/3] dt-bindings: Add Actiontec vendor prefix Linus Walleij
2025-08-14 20:46 ` Conor Dooley
2025-08-14 16:40 ` [PATCH 2/3] dt-bindings: arm: List actiontec devices Linus Walleij
2025-08-14 20:46 ` Conor Dooley
2025-08-14 21:03 ` Rob Herring
2025-08-14 21:04 ` Rob Herring
2025-08-14 16:40 ` [PATCH 3/3] ARM: dts: Add ixp4xx Actiontec MI424WR device trees Linus Walleij
2025-08-14 21:13 ` Florian Fainelli
2025-08-15 9:09 ` Linus Walleij
2025-08-15 21:19 ` [PATCH 0/3] ARM: dts: ixp4xx: Add device trees for MI424WR Rob Herring (Arm)
2025-08-19 13:14 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).