From: Jonathan Cameron <jic23@kernel.org>
To: Haibo Chen <haibo.chen@nxp.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
primoz.fiser@norik.com, linux-iio@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Keep imx93 ADC works even calibration failed.
Date: Sat, 16 Aug 2025 14:28:50 +0100 [thread overview]
Message-ID: <20250816142850.53948a13@jic23-huawei> (raw)
In-Reply-To: <20250812-adc-v2-0-0260833f13b8@nxp.com>
On Tue, 12 Aug 2025 16:04:21 +0800
Haibo Chen <haibo.chen@nxp.com> wrote:
> imx93 ADC calibration has requirement for reference voltage:
> ADC reference voltage Noise < 1.8V * 1/2^ENOB
>
> Some boards can't meet such requirement, ADC calibration failed on these
> boards, and adc can't be used. This is not appropriate, board can't meet
> this requirement do not means ADC can't work, just means ADC can't work
> that accurate. Here add an optimization, keep adc works even calibration
> failed.
>
> Changes in V2:
> - add patch 1 to keep one style of the hex values according to
> Andy Shevchenko's suggestion.
> - keep {} when give the calibration failed warning log.
>
> For the register 0x3A0, it is a new added register in latest imx93 RM,
> please refer to this link:
> https://www.nxp.com/products/processors-and-microcontrollers/arm-processors/i-mx-applications-processors/i-mx-9-processors/i-mx-93-applications-processor-family-arm-cortex-a55-ml-acceleration-power-efficient-mpu:i.MX93
>
> Patch v1 also pass test on one customer board, refer to this topic:
> https://patchwork.kernel.org/project/linux-iio/patch/20250710073905.1105417-2-primoz.fiser@norik.com/
>
> Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
Series applied to the togreg branch of iio.git.
I'll push that out as testing to get a bit of build coverage before
risking letting next see it.
Thanks,
Jonathan
> ---
> Haibo Chen (2):
> iio: adc: imx93_adc: keep one style of the hex values
> iio: adc: imx93_adc: load calibrated values even calibration failed
>
> drivers/iio/adc/imx93_adc.c | 22 +++++++++++++++++-----
> 1 file changed, 17 insertions(+), 5 deletions(-)
> ---
> base-commit: 2674d1eadaa2fd3a918dfcdb6d0bb49efe8a8bb9
> change-id: 20250812-adc-839e49d55da9
>
> Best regards,
prev parent reply other threads:[~2025-08-16 13:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 8:04 [PATCH v2 0/2] Keep imx93 ADC works even calibration failed Haibo Chen
2025-08-12 8:04 ` [PATCH v2 1/2] iio: adc: imx93_adc: keep one style of the hex values Haibo Chen
2025-08-12 9:06 ` Andy Shevchenko
2025-08-12 16:14 ` Frank Li
2025-08-12 8:04 ` [PATCH v2 2/2] iio: adc: imx93_adc: load calibrated values even calibration failed Haibo Chen
2025-08-12 8:45 ` Primoz Fiser
2025-08-12 15:53 ` Jonathan Cameron
2025-08-12 16:16 ` Frank Li
2025-08-16 13:28 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250816142850.53948a13@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=primoz.fiser@norik.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox