From: Andreas Kemnade <andreas@kemnade.info>
To: Yang Xiuwei <yangxiuwei2025@163.com>
Cc: tony@atomide.com, khilman@baylibre.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Yang Xiuwei <yangxiuwei@kylinos.cn>
Subject: Re: [PATCH] ARM: OMAP2+: use IS_ERR_OR_NULL() helper
Date: Mon, 18 Aug 2025 19:12:08 +0200 [thread overview]
Message-ID: <20250818191208.11db7aae@akair> (raw)
In-Reply-To: <20250817083449.2249268-1-yangxiuwei2025@163.com>
Am Sun, 17 Aug 2025 16:34:49 +0800
schrieb Yang Xiuwei <yangxiuwei2025@163.com>:
> From: Yang Xiuwei <yangxiuwei@kylinos.cn>
>
> Simplify error handling in OMAP powerdomain, voltage, and VP code by
> replacing open-coded '!ptr || IS_ERR(ptr)' checks with the combined
> IS_ERR_OR_NULL() helper.
>
> This improves readability and consistency across
> omap_set_pwrdm_state(), voltdm_get_voltage(), voltdm_scale(),
> voltdm_reset(), and related functions.
>
> No functional change intended.
>
> Signed-off-by: Yang Xiuwei <yangxiuwei@kylinos.cn>
Reviewed-by: Andreas Kemnade <andreas@kemnade.info>
next prev parent reply other threads:[~2025-08-18 17:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-17 8:34 [PATCH] ARM: OMAP2+: use IS_ERR_OR_NULL() helper Yang Xiuwei
2025-08-18 17:12 ` Andreas Kemnade [this message]
2025-09-05 22:22 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250818191208.11db7aae@akair \
--to=andreas@kemnade.info \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=yangxiuwei2025@163.com \
--cc=yangxiuwei@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox