From: Conor Dooley <conor@kernel.org>
To: Xiandong Wang <xiandong.wang@mediatek.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Houlong Wei <houlong.wei@mediatek.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, sirius.wang@mediatek.com,
vince-wl.liu@mediatek.com, jh.hsu@mediatek.com,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v2 1/4] dt-bindings: mailbox: add cmdq yaml for MT8189
Date: Tue, 19 Aug 2025 18:51:34 +0100 [thread overview]
Message-ID: <20250819-coliseum-unsheathe-0c12a58e65e0@spud> (raw)
In-Reply-To: <20250819015948.15450-2-xiandong.wang@mediatek.com>
[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]
On Tue, Aug 19, 2025 at 09:59:38AM +0800, Xiandong Wang wrote:
> Add compatible string to support cmdq for MT8189.
Is this even the right commit message or a copy-paste mistake?
That said, you're definitely not "adding cmdq yaml" as your
$subject says, just one compatible, so the wording there should match
what you have here (if cmdq is the correct name for this).
With that,
Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Signed-off-by: Xiandong Wang <xiandong.wang@mediatek.com>
> ---
> .../devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> index 73d6db34d64a..f9718b90d36a 100644
> --- a/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/mediatek,gce-mailbox.yaml
> @@ -23,6 +23,7 @@ properties:
> - mediatek,mt8183-gce
> - mediatek,mt8186-gce
> - mediatek,mt8188-gce
> + - mediatek,mt8189-gce
> - mediatek,mt8192-gce
> - mediatek,mt8195-gce
> - mediatek,mt8196-gce
> --
> 2.46.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-08-19 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 1:59 [PATCH v2 0/4] Add GCE driver for 8189 Xiandong Wang
2025-08-19 1:59 ` [PATCH v2 1/4] dt-bindings: mailbox: add cmdq yaml for MT8189 Xiandong Wang
2025-08-19 17:51 ` Conor Dooley [this message]
2025-08-19 1:59 ` [PATCH v2 2/4] mailbox: mtk-cmdq: Add cmdq driver for mt8189 Xiandong Wang
2025-08-19 1:59 ` [PATCH v2 3/4] arm64: dts: mediatek: Add GCE header " Xiandong Wang
2025-08-19 1:59 ` [PATCH v2 4/4] mailbox: mtk-cmdq: modify clk api for suspend/resume Xiandong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819-coliseum-unsheathe-0c12a58e65e0@spud \
--to=conor@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=jh.hsu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=sirius.wang@mediatek.com \
--cc=vince-wl.liu@mediatek.com \
--cc=xiandong.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox