From: Guoniu Zhou <guoniu.zhou@nxp.com>
To: Rui Miguel Silva <rmfrfs@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Martin Kepplinger <martink@posteo.de>,
Purism Kernel Team <kernel@puri.sm>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>
Cc: linux-media@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Frank Li <Frank.Li@nxp.com>,
Guoniu Zhou <guoniu.zhou@nxp.com>
Subject: [PATCH v4 1/4] media: imx8mq-mipi-csi2: Remove width field in csi2_pix_format
Date: Tue, 19 Aug 2025 11:58:00 +0800 [thread overview]
Message-ID: <20250819-csi2_imx8mq-v4-1-c16b1d8f88a9@nxp.com> (raw)
In-Reply-To: <20250819-csi2_imx8mq-v4-0-c16b1d8f88a9@nxp.com>
Simplify the code by using helper function media_bus_fmt_to_csi2_bpp()
to get width for supported format.
No functions changed.
Signed-off-by: Guoniu Zhou <guoniu.zhou@nxp.com>
---
drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 29 +++++----------------------
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
index 3a4645f59a44028fdca82a4d8393e1a0a6ba88f0..85700655ecad334c61e9b5f9f073e10b6db2618f 100644
--- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
+++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c
@@ -25,6 +25,7 @@
#include <linux/reset.h>
#include <linux/spinlock.h>
+#include <media/mipi-csi2.h>
#include <media/v4l2-common.h>
#include <media/v4l2-device.h>
#include <media/v4l2-fwnode.h>
@@ -138,7 +139,6 @@ struct csi_state {
struct csi2_pix_format {
u32 code;
- u8 width;
};
/* -----------------------------------------------------------------------------
@@ -262,70 +262,49 @@ static const struct csi2_pix_format imx8mq_mipi_csi_formats[] = {
/* RAW (Bayer and greyscale) formats. */
{
.code = MEDIA_BUS_FMT_SBGGR8_1X8,
- .width = 8,
}, {
.code = MEDIA_BUS_FMT_SGBRG8_1X8,
- .width = 8,
}, {
.code = MEDIA_BUS_FMT_SGRBG8_1X8,
- .width = 8,
}, {
.code = MEDIA_BUS_FMT_SRGGB8_1X8,
- .width = 8,
}, {
.code = MEDIA_BUS_FMT_Y8_1X8,
- .width = 8,
}, {
.code = MEDIA_BUS_FMT_SBGGR10_1X10,
- .width = 10,
}, {
.code = MEDIA_BUS_FMT_SGBRG10_1X10,
- .width = 10,
}, {
.code = MEDIA_BUS_FMT_SGRBG10_1X10,
- .width = 10,
}, {
.code = MEDIA_BUS_FMT_SRGGB10_1X10,
- .width = 10,
}, {
.code = MEDIA_BUS_FMT_Y10_1X10,
- .width = 10,
}, {
.code = MEDIA_BUS_FMT_SBGGR12_1X12,
- .width = 12,
}, {
.code = MEDIA_BUS_FMT_SGBRG12_1X12,
- .width = 12,
}, {
.code = MEDIA_BUS_FMT_SGRBG12_1X12,
- .width = 12,
}, {
.code = MEDIA_BUS_FMT_SRGGB12_1X12,
- .width = 12,
}, {
.code = MEDIA_BUS_FMT_Y12_1X12,
- .width = 12,
}, {
.code = MEDIA_BUS_FMT_SBGGR14_1X14,
- .width = 14,
}, {
.code = MEDIA_BUS_FMT_SGBRG14_1X14,
- .width = 14,
}, {
.code = MEDIA_BUS_FMT_SGRBG14_1X14,
- .width = 14,
}, {
.code = MEDIA_BUS_FMT_SRGGB14_1X14,
- .width = 14,
},
/* YUV formats */
{
.code = MEDIA_BUS_FMT_YUYV8_1X16,
- .width = 16,
}, {
.code = MEDIA_BUS_FMT_UYVY8_1X16,
- .width = 16,
- }
+ },
};
static const struct csi2_pix_format *find_csi2_format(u32 code)
@@ -415,6 +394,7 @@ static int imx8mq_mipi_csi_calc_hs_settle(struct csi_state *state,
u32 min_ths_settle, max_ths_settle, ths_settle_ns, esc_clk_period_ns;
const struct v4l2_mbus_framefmt *fmt;
const struct csi2_pix_format *csi2_fmt;
+ u32 bpp;
src_pad = media_entity_remote_source_pad_unique(&sd_state->sd->entity);
if (IS_ERR(src_pad)) {
@@ -427,8 +407,9 @@ static int imx8mq_mipi_csi_calc_hs_settle(struct csi_state *state,
fmt = v4l2_subdev_state_get_format(sd_state, MIPI_CSI2_PAD_SINK);
csi2_fmt = find_csi2_format(fmt->code);
+ bpp = media_bus_fmt_to_csi2_bpp(csi2_fmt->code);
- link_freq = v4l2_get_link_freq(src_pad, csi2_fmt->width,
+ link_freq = v4l2_get_link_freq(src_pad, bpp,
state->bus.num_data_lanes * 2);
if (link_freq < 0) {
dev_err(state->dev, "Unable to obtain link frequency: %d\n",
--
2.34.1
next prev parent reply other threads:[~2025-08-19 4:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 3:57 [PATCH v4 0/4] media: imx8mq-mipi-csi2: Enhance the driver to meet more usage case Guoniu Zhou
2025-08-19 3:58 ` Guoniu Zhou [this message]
2025-08-19 3:58 ` [PATCH v4 2/4] media: imx8mq-mipi-csi2: Add output filed in csi2_pix_format Guoniu Zhou
2025-08-19 15:41 ` Frank Li
2025-08-19 3:58 ` [PATCH v4 3/4] media: imx8mq-mipi-csi2: Add RGB format support Guoniu Zhou
2025-08-19 3:58 ` [PATCH v4 4/4] media: imx8mq-mipi-csi2: Implement .get_frame_desc subdev callback Guoniu Zhou
2025-08-19 15:45 ` [PATCH v4 0/4] media: imx8mq-mipi-csi2: Enhance the driver to meet more usage case Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250819-csi2_imx8mq-v4-1-c16b1d8f88a9@nxp.com \
--to=guoniu.zhou@nxp.com \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=rmfrfs@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).