From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 24FA9CA0EE4 for ; Wed, 20 Aug 2025 17:27:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gbzi7bKOiZkPR4tVr8Rl75IJu4u69w506O4duD5k0zQ=; b=kGFyrMKLq0qWAN6IwdUJW8lN+9 cdqMOvza2hhR6n5HktkOhrYcySn7hUYoYnnBB3tj0El+qYNY/JiBolnxycHBy+VjK5EZaL2RCwv8F IB3oioPuT0H07FcA5A0L1Sop+47tzZFUlzHOpyZpsp69Pi9PPhQMM7O0YUXmkxr73l8czEULoDCzW aDPfAYh6z9RHMDakODozDg7zL7yyilL+MtzFZTUKtDSj5/Uf9lmlEcAxPjvFPsemV1FMhTodbWeu2 /X14qFB9ijKuyyqNkKKbbmI6wWi/JUohJb+16tjDKIVgaZsPgNPnZOUhdw4igSBPLAMqbwwF1Ceyw 637YbOhw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uomay-0000000EXlz-2fGz; Wed, 20 Aug 2025 17:27:32 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uokHW-0000000EAYn-1Vu2 for linux-arm-kernel@lists.infradead.org; Wed, 20 Aug 2025 14:59:19 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-323267bcee7so21926a91.1 for ; Wed, 20 Aug 2025 07:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755701957; x=1756306757; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gbzi7bKOiZkPR4tVr8Rl75IJu4u69w506O4duD5k0zQ=; b=Q0obGLw0IjQZ++XAFsDdOzFgdq1IKftG9aUGu9v6PFhHgi7MvBE1xIxZ9eJf9C4VR6 3gEUdeBc7dHVv158k5b87kvXfIODkQeUhNc6niI2oeICMB27WRQhRFHEPlTvzv7KvTbC ObQDFuYsXOoJ4a00cOBmNhtg1GTSTlGBfjr6sGOCGCyf1m/pYbtHQA9owCiRjJfn0g3q ttMNHyPYVC0VwwXCA273xjJxxnFiSMikQdNrsm0AWY8wRIXvJ+Cuy24dzzp2d01WAqlr libT14S0IJOlCrKDAaWYNeNvlJyIdVparzcy2uJE/V/zb35PiqTA7jcQ8TI8hdhdzJI0 cc+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755701957; x=1756306757; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gbzi7bKOiZkPR4tVr8Rl75IJu4u69w506O4duD5k0zQ=; b=TKA9VSrF0PAf0MJGihs2gliRAtVfB9w5KiglAxwPlOCyNC1InY0Xj9APuIJV1Za+s1 PSdyQxsGzp/wNNHMN6bxarFKMI/UsappCVATFffHYaMpUX2TZ7wBy8Y8HmA20gZjgRw+ fwTrdeSVAo0ZPn2jguYDZ2Bp38bwe9A/eSmOur3odXT+/jzFcHGpAm0OpNVggp+rSV5h MckjWLl0OYjnbZwbBEHCB7AiHUFgME+hZMCGfmI+RWg6zEE/ayj5MVcqIkrZuDdRoSVG AtziGQtW3h4Drm8eWy8zH68G44BknMt7zIJPifc7R9B15zapKYvxFvlu8krdb+6KLrve FC7g== X-Forwarded-Encrypted: i=1; AJvYcCXxjI2exYQWTLr3I5zgRMamv3IB8z+xie1TVgW6vF4kXHyLoVIEuw8jyVgw++5kpFSacL+IY5H6UheKEL9cbDJt@lists.infradead.org X-Gm-Message-State: AOJu0Yz8fPuXZX57zA8uwENisUmy6p/aseVAA1+fcK3zsIRqQ0haMxWd h9oUjpmnki/GFMojwGLEBXsJcvrfsnJ4bMDOZGsuJgfDJ+OrM7CTXei+ X-Gm-Gg: ASbGncvVimpgpAXjMUGQJa/RY6KqSazIwBCwok1EUNzB+rPC6RhgxiUpTM4IwHaGKjx 8r9urJ2zfPPPYt6sW9nZYnkbESHP4uE1TXSL96JBJJsf0bCUGugpQCSBJhRuxev1uEhdhVcLDSn 4YmyaxARJBfLVFU+pJwZZ/tiOQHrFqKp+8nPsKgLvvEDXmfOkb+SXkcq9RqqOxICDm7k0GBFRmz TLgq9zID4ERSFbVmcndtmcILsHAk04FZW+RaBDwqByCIOky5DMeIShWX6rzEs+/OWOPprrNprcp jzXu99lnzSvL0E7pBjM773mFJGnoNwsmxGCA7HVr/AsV6HwOw4uJlDJP0wRyDcxUSk4Naaj35be gRco4qkrEA3fcLv92EiM55pTkXLWbqtq1qKmZSdCfT8xPoNI= X-Google-Smtp-Source: AGHT+IGIPMmmi+mgr0mAE1JQsz1veRMJRyPlRi1U97wGAtb3S18yQ9jwLbrK+aFHnPQ5j5mKg5P57A== X-Received: by 2002:a17:90b:4fc7:b0:323:7e81:7faa with SMTP id 98e67ed59e1d1-324e14557e7mr3738888a91.36.1755701957464; Wed, 20 Aug 2025 07:59:17 -0700 (PDT) Received: from [127.0.0.1] (aulavirtual.utp.edu.pe. [190.12.77.24]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-324e257809esm2606455a91.24.2025.08.20.07.59.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Aug 2025 07:59:17 -0700 (PDT) From: Denzeel Oliva Date: Wed, 20 Aug 2025 09:57:22 -0500 Subject: [PATCH v2 1/3] clk: samsung: exynos990: Fix CMU TOP mux/div widths and add fixed-factors MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250820-2-v2-1-bd45e196d4c4@gmail.com> References: <20250820-2-v2-0-bd45e196d4c4@gmail.com> In-Reply-To: <20250820-2-v2-0-bd45e196d4c4@gmail.com> To: Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Rob Herring , Conor Dooley Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Denzeel Oliva X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1755701949; l=6236; i=wachiturroxd150@gmail.com; s=20250819; h=from:subject:message-id; bh=08L0O1QzjB06mEEmW7E8BQyzmJgrxO6aKMGsjwBWY9M=; b=DiclXwUL8lWy/P/EylsoMUXhN7bjdPJ0nOLt5SECWdfpBvCt5RXYZI2aLUSBvCGlkmvgdGbG4 bqiEAeCBxVcA4wAnuyYaWvchxH2BpmD73W0mHwobldpE2fKD3WBxYEm X-Developer-Key: i=wachiturroxd150@gmail.com; a=ed25519; pk=qNvcL0Ehm3chrW9jFA2JaPVgubN5mHH//uriMxR/DlI= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250820_075918_404548_5AB4A525 X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Correct mux/div bit widths in CMU TOP (DPU, DSP_BUS, G2D_MSCL, HSI0/1/2). Replace wrong divs with fixed-factor clocks for HSI1/2 PCIe and USBDP debug. Also fix OTP rate. These align with Exynos990 downstream cmucal and ensure correct parent/rate selection. Signed-off-by: Denzeel Oliva --- drivers/clk/samsung/clk-exynos990.c | 33 +++++++++++++++++++-------------- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos990.c b/drivers/clk/samsung/clk-exynos990.c index 8d3f193d2b4d4c2146d9b8b57d76605b88dc9bbb..a55991ebb77bcb2988071fc156dbe5c9b100215f 100644 --- a/drivers/clk/samsung/clk-exynos990.c +++ b/drivers/clk/samsung/clk-exynos990.c @@ -759,11 +759,11 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = { MUX(CLK_MOUT_CMU_DPU_ALT, "mout_cmu_dpu_alt", mout_cmu_dpu_alt_p, CLK_CON_MUX_MUX_CLKCMU_DPU_ALT, 0, 2), MUX(CLK_MOUT_CMU_DSP_BUS, "mout_cmu_dsp_bus", - mout_cmu_dsp_bus_p, CLK_CON_MUX_MUX_CLKCMU_DSP_BUS, 0, 2), + mout_cmu_dsp_bus_p, CLK_CON_MUX_MUX_CLKCMU_DSP_BUS, 0, 3), MUX(CLK_MOUT_CMU_G2D_G2D, "mout_cmu_g2d_g2d", mout_cmu_g2d_g2d_p, CLK_CON_MUX_MUX_CLKCMU_G2D_G2D, 0, 2), MUX(CLK_MOUT_CMU_G2D_MSCL, "mout_cmu_g2d_mscl", - mout_cmu_g2d_mscl_p, CLK_CON_MUX_MUX_CLKCMU_G2D_MSCL, 0, 1), + mout_cmu_g2d_mscl_p, CLK_CON_MUX_MUX_CLKCMU_G2D_MSCL, 0, 2), MUX(CLK_MOUT_CMU_HPM, "mout_cmu_hpm", mout_cmu_hpm_p, CLK_CON_MUX_MUX_CLKCMU_HPM, 0, 2), MUX(CLK_MOUT_CMU_HSI0_BUS, "mout_cmu_hsi0_bus", @@ -775,7 +775,7 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = { 0, 2), MUX(CLK_MOUT_CMU_HSI0_USBDP_DEBUG, "mout_cmu_hsi0_usbdp_debug", mout_cmu_hsi0_usbdp_debug_p, - CLK_CON_MUX_MUX_CLKCMU_HSI0_USBDP_DEBUG, 0, 2), + CLK_CON_MUX_MUX_CLKCMU_HSI0_USBDP_DEBUG, 0, 1), MUX(CLK_MOUT_CMU_HSI1_BUS, "mout_cmu_hsi1_bus", mout_cmu_hsi1_bus_p, CLK_CON_MUX_MUX_CLKCMU_HSI1_BUS, 0, 3), MUX(CLK_MOUT_CMU_HSI1_MMC_CARD, "mout_cmu_hsi1_mmc_card", @@ -788,7 +788,7 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = { 0, 2), MUX(CLK_MOUT_CMU_HSI1_UFS_EMBD, "mout_cmu_hsi1_ufs_embd", mout_cmu_hsi1_ufs_embd_p, CLK_CON_MUX_MUX_CLKCMU_HSI1_UFS_EMBD, - 0, 1), + 0, 2), MUX(CLK_MOUT_CMU_HSI2_BUS, "mout_cmu_hsi2_bus", mout_cmu_hsi2_bus_p, CLK_CON_MUX_MUX_CLKCMU_HSI2_BUS, 0, 1), MUX(CLK_MOUT_CMU_HSI2_PCIE, "mout_cmu_hsi2_pcie", @@ -862,7 +862,7 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_PLL_SHARED4_DIV4, 0, 1), DIV(CLK_DOUT_CMU_APM_BUS, "dout_cmu_apm_bus", "gout_cmu_apm_bus", - CLK_CON_DIV_CLKCMU_APM_BUS, 0, 3), + CLK_CON_DIV_CLKCMU_APM_BUS, 0, 2), DIV(CLK_DOUT_CMU_AUD_CPU, "dout_cmu_aud_cpu", "gout_cmu_aud_cpu", CLK_CON_DIV_CLKCMU_AUD_CPU, 0, 3), DIV(CLK_DOUT_CMU_BUS0_BUS, "dout_cmu_bus0_bus", "gout_cmu_bus0_bus", @@ -889,7 +889,7 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_CLKCMU_CORE_BUS, 0, 4), DIV(CLK_DOUT_CMU_CPUCL0_DBG_BUS, "dout_cmu_cpucl0_debug", "gout_cmu_cpucl0_dbg_bus", CLK_CON_DIV_CLKCMU_CPUCL0_DBG_BUS, - 0, 3), + 0, 4), DIV(CLK_DOUT_CMU_CPUCL0_SWITCH, "dout_cmu_cpucl0_switch", "gout_cmu_cpucl0_switch", CLK_CON_DIV_CLKCMU_CPUCL0_SWITCH, 0, 3), DIV(CLK_DOUT_CMU_CPUCL1_SWITCH, "dout_cmu_cpucl1_switch", @@ -924,16 +924,11 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_CLKCMU_HSI0_DPGTC, 0, 3), DIV(CLK_DOUT_CMU_HSI0_USB31DRD, "dout_cmu_hsi0_usb31drd", "gout_cmu_hsi0_usb31drd", CLK_CON_DIV_CLKCMU_HSI0_USB31DRD, 0, 4), - DIV(CLK_DOUT_CMU_HSI0_USBDP_DEBUG, "dout_cmu_hsi0_usbdp_debug", - "gout_cmu_hsi0_usbdp_debug", CLK_CON_DIV_CLKCMU_HSI0_USBDP_DEBUG, - 0, 4), DIV(CLK_DOUT_CMU_HSI1_BUS, "dout_cmu_hsi1_bus", "gout_cmu_hsi1_bus", CLK_CON_DIV_CLKCMU_HSI1_BUS, 0, 3), DIV(CLK_DOUT_CMU_HSI1_MMC_CARD, "dout_cmu_hsi1_mmc_card", "gout_cmu_hsi1_mmc_card", CLK_CON_DIV_CLKCMU_HSI1_MMC_CARD, 0, 9), - DIV(CLK_DOUT_CMU_HSI1_PCIE, "dout_cmu_hsi1_pcie", "gout_cmu_hsi1_pcie", - CLK_CON_DIV_CLKCMU_HSI1_PCIE, 0, 7), DIV(CLK_DOUT_CMU_HSI1_UFS_CARD, "dout_cmu_hsi1_ufs_card", "gout_cmu_hsi1_ufs_card", CLK_CON_DIV_CLKCMU_HSI1_UFS_CARD, 0, 3), @@ -942,8 +937,6 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { 0, 3), DIV(CLK_DOUT_CMU_HSI2_BUS, "dout_cmu_hsi2_bus", "gout_cmu_hsi2_bus", CLK_CON_DIV_CLKCMU_HSI2_BUS, 0, 4), - DIV(CLK_DOUT_CMU_HSI2_PCIE, "dout_cmu_hsi2_pcie", "gout_cmu_hsi2_pcie", - CLK_CON_DIV_CLKCMU_HSI2_PCIE, 0, 7), DIV(CLK_DOUT_CMU_IPP_BUS, "dout_cmu_ipp_bus", "gout_cmu_ipp_bus", CLK_CON_DIV_CLKCMU_IPP_BUS, 0, 4), DIV(CLK_DOUT_CMU_ITP_BUS, "dout_cmu_itp_bus", "gout_cmu_itp_bus", @@ -980,7 +973,17 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { DIV(CLK_DOUT_CMU_VRA_BUS, "dout_cmu_vra_bus", "gout_cmu_vra_bus", CLK_CON_DIV_CLKCMU_VRA_BUS, 0, 4), DIV(CLK_DOUT_CMU_DPU, "dout_cmu_clkcmu_dpu", "gout_cmu_dpu", - CLK_CON_DIV_DIV_CLKCMU_DPU, 0, 4), + CLK_CON_DIV_DIV_CLKCMU_DPU, 0, 3), +}; + +static const struct samsung_fixed_factor_clock cmu_top_ffactor[] __initconst = { + FFACTOR(CLK_DOUT_CMU_HSI1_PCIE, "dout_cmu_hsi1_pcie", + "gout_cmu_hsi1_pcie", 1, 8, 0), + FFACTOR(CLK_DOUT_CMU_OTP, "dout_cmu_otp", "oscclk", 1, 8, 0), + FFACTOR(CLK_DOUT_CMU_HSI0_USBDP_DEBUG, "dout_cmu_hsi0_usbdp_debug", + "gout_cmu_hsi0_usbdp_debug", 1, 8, 0), + FFACTOR(CLK_DOUT_CMU_HSI2_PCIE, "dout_cmu_hsi2_pcie", + "gout_cmu_hsi2_pcie", 1, 8, 0), }; static const struct samsung_gate_clock top_gate_clks[] __initconst = { @@ -1126,6 +1129,8 @@ static const struct samsung_cmu_info top_cmu_info __initconst = { .nr_mux_clks = ARRAY_SIZE(top_mux_clks), .div_clks = top_div_clks, .nr_div_clks = ARRAY_SIZE(top_div_clks), + .fixed_factor_clks = cmu_top_ffactor, + .nr_fixed_factor_clks = ARRAY_SIZE(cmu_top_ffactor), .gate_clks = top_gate_clks, .nr_gate_clks = ARRAY_SIZE(top_gate_clks), .nr_clk_ids = CLKS_NR_TOP, -- 2.49.0