From: Frank Li <Frank.Li@nxp.com>
To: Rui Miguel Silva <rmfrfs@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Martin Kepplinger <martink@posteo.de>,
Purism Kernel Team <kernel@puri.sm>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Eugen Hristev <eugen.hristev@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Peng Fan <peng.fan@nxp.com>,
Alice Yuan <alice.yuan@nxp.com>, Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Steve Longerbeam <slongerbeam@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-staging@lists.linux.dev,
Frank Li <Frank.Li@nxp.com>
Subject: [PATCH v3 29/31] media: synopsys: csi2: Add Image Pixel Interface (IPI) support for v150
Date: Thu, 21 Aug 2025 16:16:04 -0400 [thread overview]
Message-ID: <20250821-95_cam-v3-29-c9286fbb34b9@nxp.com> (raw)
In-Reply-To: <20250821-95_cam-v3-0-c9286fbb34b9@nxp.com>
Add Image Pixel Interface (IPI) support for v150. Check the ipi_mode
register to determine whether the hardware supports IPI.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
drivers/media/platform/synopsys/mipi-csi2.c | 82 +++++++++++++++++++++++++++++
1 file changed, 82 insertions(+)
diff --git a/drivers/media/platform/synopsys/mipi-csi2.c b/drivers/media/platform/synopsys/mipi-csi2.c
index 695159f463f872ee0775c271b8e1c4e1d289de20..8ccd3d4960801cccd8d24647f726e4653955f90c 100644
--- a/drivers/media/platform/synopsys/mipi-csi2.c
+++ b/drivers/media/platform/synopsys/mipi-csi2.c
@@ -40,6 +40,11 @@ struct dw_csi2_regs {
u32 msk2;
u32 phy_tst_ctrl0;
u32 phy_tst_ctrl1;
+ u32 ipi_softrstn;
+ u32 ipi_datatype;
+ u32 ipi_vcid;
+ u32 ipi_mode;
+ u32 ipi_mem_flush;
u32 int_st_main;
u32 int_st_dphy_fatal;
u32 int_msk_dphy_fatal;
@@ -90,6 +95,11 @@ static const struct dw_csi2_regs dw_csi2_v150 = {
.phy_stopstate = DW_REG(0x4c),
.phy_tst_ctrl0 = DW_REG(0x50),
.phy_tst_ctrl1 = DW_REG(0x54),
+ .ipi_mode = DW_REG(0x80),
+ .ipi_vcid = DW_REG(0x84),
+ .ipi_datatype = DW_REG(0x88),
+ .ipi_mem_flush = DW_REG(0x8c),
+ .ipi_softrstn = DW_REG(0xa0),
.int_st_dphy_fatal = DW_REG(0xe0),
.int_msk_dphy_fatal = DW_REG(0xe4),
.int_force_dphy_fatal = DW_REG(0xe8),
@@ -115,6 +125,31 @@ static const struct dw_csi2_regs dw_csi2_v150 = {
#define INT_ST_MAIN_ERR_PHY BIT(16)
#define INT_ST_MAIN_FATAL_ERR_IPI BIT(18)
+#define IPI_VCID_VC(x) FIELD_PREP(GENMASK(1, 0), (x))
+#define IPI_VCID_VC_0_1(x) FIELD_PREP(GENMASK(3, 2), (x))
+#define IPI_VCID_VC_2 BIT(4)
+
+#define IPI_DATA_TYPE_DT(x) FIELD_PREP(GENMASK(5, 0), (x))
+#define IPI_DATA_TYPE_EMB_DATA_EN BIT(8)
+
+#define IPI_MODE_CONTROLLER BIT(1)
+#define IPI_MODE_COLOR_MODE16 BIT(8)
+#define IPI_MODE_CUT_THROUGH BIT(16)
+#define IPI_MODE_ENABLE BIT(24)
+
+#define IPI_MEM_FLUSH_AUTO BIT(8)
+
+#define INT_ST_MAIN_FATAL_ERR_PHY BIT(0)
+#define INT_ST_MAIN_FATAL_ERR_PKT BIT(1)
+#define INT_ST_MAIN_FATAL_ERR_BNDRY_FRAMEL BIT(2)
+#define INT_ST_MAIN_FATAL_ERR_SEQ_FRAME BIT(3)
+#define INT_ST_MAIN_FATAL_ERR_CRC_FRAME BIT(4)
+#define INT_ST_MAIN_FATAL_ERR_PLD_CRC BIT(5)
+#define INT_ST_MAIN_ERR_DID BIT(6)
+#define INT_ST_MAIN_ERR_ECC BIT(7)
+#define INT_ST_MAIN_ERR_PHY BIT(16)
+#define INT_ST_MAIN_FATAL_ERR_IPI BIT(18)
+
#define INT_MSK_DPHY_FATAL_ERR_SOT_LANE0 BIT(0)
#define INT_MSK_DPHY_FATAL_ERR_SOT_LANE1 BIT(1)
@@ -449,6 +484,48 @@ static int dw_mipi_csi2_phy_prep(struct dw_mipi_csi2_dev *csi2, int bpp)
return ret;
}
+static void dw_csi2_device_ipi_config(struct dw_mipi_csi2_dev *csi2)
+{
+ int dt = media_bus_fmt_to_csi2_dt(csi2->format_mbus.code);
+ u32 val;
+
+ /* Do IPI soft reset */
+ dw_writel(csi2, 0x0, ipi_softrstn);
+ dw_writel(csi2, 0x1, ipi_softrstn);
+
+ /* Select virtual channel and data type to be processed by IPI */
+ val = IPI_DATA_TYPE_DT(dt);
+ dw_writel(csi2, val, ipi_datatype);
+
+ /* Set virtual channel 0 as default */
+ val = IPI_VCID_VC(0);
+ dw_writel(csi2, val, ipi_vcid);
+
+ /*
+ * Select IPI camera timing mode and allow the pixel stream
+ * to be non-continuous when pixel interface FIFO is empty
+ */
+ val = dw_readl(csi2, ipi_mode);
+ val &= ~IPI_MODE_CONTROLLER;
+ val &= ~IPI_MODE_COLOR_MODE16;
+ val |= IPI_MODE_CUT_THROUGH;
+ dw_writel(csi2, val, ipi_mode);
+}
+
+static void dw_csi2_ipi_enable(struct dw_mipi_csi2_dev *csi2)
+{
+ u32 val;
+
+ /* Memory is automatically flushed at each Frame Start */
+ val = IPI_MEM_FLUSH_AUTO;
+ dw_writel(csi2, val, ipi_mem_flush);
+
+ /* Enable IPI */
+ val = dw_readl(csi2, ipi_mode);
+ val |= IPI_MODE_ENABLE;
+ dw_writel(csi2, val, ipi_mode);
+}
+
static void dw_csi2_enable_irq(struct dw_mipi_csi2_dev *csi2)
{
u32 val;
@@ -583,6 +660,11 @@ static int csi2_start(struct dw_mipi_csi2_dev *csi2, int bpp)
if (ret)
goto err_stop_upstream;
+ if (csi2->regs->ipi_mode) {
+ dw_csi2_device_ipi_config(csi2);
+ dw_csi2_ipi_enable(csi2);
+ }
+
dw_csi2_enable_irq(csi2);
return 0;
--
2.34.1
next prev parent reply other threads:[~2025-08-22 2:49 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 20:15 [PATCH v3 00/31] media: add imx93 mipi/controller csi support Frank Li
2025-08-21 20:15 ` [PATCH v3 01/31] dt-bindings: media: add DW MIPI CSI-2 Host support Frank Li
2025-08-22 20:15 ` Rob Herring (Arm)
2025-08-21 20:15 ` [PATCH v3 02/31] media: v4l2-common: Add helper function v4l_get_required_align_by_bpp() Frank Li
2025-08-21 20:15 ` [PATCH v3 03/31] media: v4l2-common: Add helper function media_bus_fmt_to_csi2_(bpp|dt)() Frank Li
2025-08-21 20:15 ` [PATCH v3 04/31] media: staging: media: imx6-mipi-csi2: replace space with tab for alignment Frank Li
2025-08-21 20:15 ` [PATCH v3 05/31] media: staging: media: imx6-mipi-csi2: use devm_add_action_or_reset() to simplify code Frank Li
2025-08-21 20:15 ` [PATCH v3 06/31] media: staging: media: imx6-mipi-csi2: use devm_clk_bulk_get_all() to fetch clocks Frank Li
2025-08-21 20:15 ` [PATCH v3 07/31] media: staging: media: imx6-mipi-csi2: use devm_mutex_init() to simplify code Frank Li
2025-08-21 20:15 ` [PATCH v3 08/31] media: staging: media: imx6-mipi-csi2: use guard() " Frank Li
2025-08-21 20:15 ` [PATCH v3 09/31] media: staging: media: imx6-mipi-csi2: use register structure to match hardware Frank Li
2025-08-21 20:15 ` [PATCH v3 10/31] media: staging: media: imx6-mipi-csi2: use devm_platform_ioremap_resource() simplify code Frank Li
2025-08-21 20:15 ` [PATCH v3 11/31] media: staging: media: imx6-mipi-csi2: move probe part to imx6-csi2.c Frank Li
2025-08-21 20:15 ` [PATCH v3 12/31] media: staging: media: imx6-mipi-csi2: move sd imx6's specific initialization into imx6-sci2.c Frank Li
2025-08-21 20:15 ` [PATCH v3 13/31] media: staging: media: imx6-mipi-csi2: move csi2ipu_gasket_init() to imx6-csi2.c Frank Li
2025-08-21 20:15 ` [PATCH v3 14/31] media: staging: media: imx6-mipi-csi2: move number pad macro define into imx6-csi2.c Frank Li
2025-08-21 20:15 ` [PATCH v3 15/31] media: staging: media: imx6-mipi-csi2: move dphy init part to imx6-csi2.c Frank Li
2025-08-21 20:15 ` [PATCH v3 16/31] media: staging: media: imx6-mipi-csi2: use runtime_pm frame to control clks Frank Li
2025-08-21 20:15 ` [PATCH v3 17/31] media: synopsys: move imx6-mipi-csi2.c to synopsys/mipi-csi2.c Frank Li
2025-08-21 20:15 ` [PATCH v3 18/31] media: synopsys: csi2: Remove deprecated s_stream and use v4l2_subdev_pad_ops Frank Li
2025-08-21 20:15 ` [PATCH v3 19/31] media: synopsys: csi2: Add phy interface support Frank Li
2025-08-21 20:15 ` [PATCH v3 20/31] media: synopsys: csi2: Add basic v150* version register Frank Li
2025-08-21 20:15 ` [PATCH v3 21/31] media: synopsys: csi2: Add irq support to record error count Frank Li
2025-08-21 20:15 ` [PATCH v3 22/31] media: synopsys: csi2: Handle alignment requirement for width Frank Li
2025-08-21 20:15 ` [PATCH v3 23/31] media: synopsys: csi2: Add register prefix to register field definitions Frank Li
2025-08-21 20:15 ` [PATCH v3 24/31] media: synopsys: csi2: Add need_dphy_reset in config Frank Li
2025-08-21 20:16 ` [PATCH v3 25/31] media: synopsys: csi2: Add default simple dw_csi2_subdev_init_state Frank Li
2025-08-21 20:16 ` [PATCH v3 26/31] media: synopsys: csi2: Add v150 lane stop state register bit define Frank Li
2025-08-21 20:16 ` [PATCH v3 27/31] media: synopsys: csi2: use standard v4l2_subdev_get_fmt() function Frank Li
2025-08-21 20:16 ` [PATCH v3 28/31] media: synopsys: csi2: Add customize get_frame_desc() callback Frank Li
2025-08-21 20:16 ` Frank Li [this message]
2025-08-21 20:16 ` [PATCH v3 30/31] media: synopsys: csi2: Remove source pad connected check at dw_csi2_enable_streams() Frank Li
2025-08-21 20:16 ` [PATCH v3 31/31] media: synopsys: csi2: Add simple synopsys platform driver Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821-95_cam-v3-29-c9286fbb34b9@nxp.com \
--to=frank.li@nxp.com \
--cc=alice.yuan@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@linaro.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=martink@posteo.de \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=rmfrfs@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).