linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Beleswar Padhi <b-padhi@ti.com>
Cc: nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, afd@ti.com,
	u-kumar1@ti.com, hnagalla@ti.com, jm@ti.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Emanuele Ghidoli <emanuele.ghidoli@toradex.com>,
	Parth Pancholi <parth.pancholi@toradex.com>,
	Jo_o Paulo Gon_alves <joao.goncalves@toradex.com>
Subject: Re: [PATCH 16/33] arm64: dts: ti: k3-am62p-verdin: Add missing cfg for TI IPC Firmware
Date: Thu, 21 Aug 2025 08:06:29 +0200	[thread overview]
Message-ID: <20250821060629.GB7503@francesco-nb> (raw)
In-Reply-To: <20250814223839.3256046-17-b-padhi@ti.com>

On Fri, Aug 15, 2025 at 04:08:22AM +0530, Beleswar Padhi wrote:
> The wkup_r5fss0_core0_memory_region is used to store the text/data
> sections of the Device Manager (DM) firmware itself and is necessary for
> platform boot. Whereas the wkup_r5fss0_core0_dma_memory_region is used
> for allocating the Virtio buffers needed for IPC with the DM core which
> could be optional. The labels were incorrectly used in the
> k3-am62p-verdin.dtsi file. Correct the firmware memory region label.
> 
> Currently, only mailbox node is enabled with FIFO assignment. However,
> there are no users of the enabled mailboxes. Add the missing carveouts
> for WKUP and MCU R5F remote processors, and enable those by associating
> to the above carveout and mailboxes. This config aligns with other AM62P
> boards and can be refactored out later.
> 
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
> Cc: Francesco Dolcini <francesco.dolcini@toradex.com>
> Cc: Emanuele Ghidoli <emanuele.ghidoli@toradex.com>
> Cc: Parth Pancholi <parth.pancholi@toradex.com>
> Cc: Jo_o Paulo Gon_alves <joao.goncalves@toradex.com>
> Requesting for a review/test.
> 
>  arch/arm64/boot/dts/ti/k3-am62p-verdin.dtsi | 42 ++++++++++++++++++++-
>  1 file changed, 41 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-verdin.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-verdin.dtsi
> index 6a04b370d149..0687debf3bbb 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-verdin.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-verdin.dtsi
> @@ -162,7 +162,25 @@ secure_ddr: optee@9e800000 {
>  			no-map;
>  		};
>  
> -		wkup_r5fss0_core0_memory_region: r5f-dma-memory@9c900000 {
> +		mcu_r5fss0_core0_dma_memory_region: mcu-r5fss-dma-memory-region@9b800000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9b800000 0x00 0x100000>;
> +			no-map;
> +		};
> +
> +		mcu_r5fss0_core0_memory_region: mcu-r5fss-memory-region@9b900000 {

Node name should be generic, `memory@9b900000` ?

this applies in multiple patches in this series


> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9b900000 0x00 0xf00000>;
> +			no-map;
> +		};
> +
> +		wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0x00 0x9c800000 0x00 0x100000>;
> +			no-map;
> +		};
> +
> +		wkup_r5fss0_core0_memory_region: r5f-memory@9c900000 {
>  			compatible = "shared-dma-pool";
>  			reg = <0x00 0x9c900000 0x00 0x01e00000>;
>  			no-map;
> @@ -848,6 +866,28 @@ mbox_mcu_r5_0: mbox-mcu-r5-0 {
>  	};
>  };
>  
> +&wkup_r5fss0 {
> +	status = "okay";
> +};
> +
> +&wkup_r5fss0_core0 {
> +	mboxes = <&mailbox0_cluster0 &mbox_r5_0>;
> +	memory-region = <&wkup_r5fss0_core0_dma_memory_region>,
> +			<&wkup_r5fss0_core0_memory_region>;
> +	status = "okay";
> +};
> +
> +&mcu_r5fss0 {
> +	status = "okay";
> +};
> +
> +&mcu_r5fss0_core0 {
> +	mboxes = <&mailbox0_cluster1 &mbox_mcu_r5_0>;
> +	memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
> +			<&mcu_r5fss0_core0_memory_region>;
> +	status = "okay";
> +};
> +
>  &main0_alert {
>  	temperature = <95000>;
>  };
> -- 
> 2.34.1
> 


  parent reply	other threads:[~2025-08-21  6:09 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-14 22:38 [PATCH 00/33] Refactor TI IPC DT configs into dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 01/33] arm64: dts: ti: k3-j7200: Enable remote processors at board level Beleswar Padhi
2025-08-15  2:30   ` Kumar, Udit
2025-08-22 16:32     ` Beleswar Prasad Padhi
2025-08-15 15:38   ` Andrew Davis
2025-08-14 22:38 ` [PATCH 02/33] arm64: dts: ti: k3-j7200-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 03/33] Revert "arm64: dts: ti: k3-j721e-sk: Fix reversed C6x carveout locations" Beleswar Padhi
2025-08-15  2:35   ` Kumar, Udit
2025-08-22 16:26     ` Beleswar Prasad Padhi
2025-08-14 22:38 ` [PATCH 04/33] Revert "arm64: dts: ti: k3-j721e-beagleboneai64: " Beleswar Padhi
2025-08-14 22:38 ` [PATCH 05/33] arm64: dts: ti: k3-j721e: Enable remote processors at board level Beleswar Padhi
2025-08-14 22:38 ` [PATCH 06/33] arm64: dts: ti: k3-j721e-beagleboneai64: Add missing cfg for TI IPC FW Beleswar Padhi
2025-08-15 15:42   ` Andrew Davis
2025-08-14 22:38 ` [PATCH 07/33] arm64: dts: ti: k3-j721e-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 08/33] arm64: dts: ti: k3-j721s2: Enable remote processors at board level Beleswar Padhi
2025-08-14 22:38 ` [PATCH 09/33] arm64: dts: ti: k3-j721s2-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 10/33] arm64: dts: ti: k3-j784s4-j742s2: Enable remote processors at board level Beleswar Padhi
2025-08-14 22:38 ` [PATCH 11/33] arm64: dts: ti: k3-j784s4-j742s2-ti-ipc-firmware-common: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 12/33] arm64: dts: ti: k3-j784s4-ti-ipc-firmware: " Beleswar Padhi
2025-08-14 22:38 ` [PATCH 13/33] arm64: dts: ti: k3-am62p-j722s: Enable remote processors at board level Beleswar Padhi
2025-08-14 22:38 ` [PATCH 14/33] arm64: dts: ti: k3-j722s-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 15/33] arm64: dts: ti: k3-am6*-boards: Add label to reserved-memory node Beleswar Padhi
2025-08-14 22:38 ` [PATCH 16/33] arm64: dts: ti: k3-am62p-verdin: Add missing cfg for TI IPC Firmware Beleswar Padhi
2025-08-18 19:39   ` Hiago De Franco
2025-08-21  6:06   ` Francesco Dolcini [this message]
2025-08-22 16:39     ` Beleswar Prasad Padhi
2025-08-23 16:43       ` Francesco Dolcini
2025-08-25  4:39         ` Beleswar Prasad Padhi
2025-08-14 22:38 ` [PATCH 17/33] arm64: dts: ti: k3-am62p-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 18/33] arm64: dts: ti: k3-am62-verdin: Add missing cfg for TI IPC Firmware Beleswar Padhi
2025-08-18 19:37   ` Hiago De Franco
2025-08-21  6:12   ` Francesco Dolcini
2025-08-22 16:46     ` Beleswar Prasad Padhi
2025-08-14 22:38 ` [PATCH 19/33] arm64: dts: ti: k3-am62-pocketbeagle2: " Beleswar Padhi
2025-08-14 22:38 ` [PATCH 20/33] arm64: dts: ti: k3-am62: Enable Mailbox nodes at the board level Beleswar Padhi
2025-08-21  6:03   ` Francesco Dolcini
2025-08-14 22:38 ` [PATCH 21/33] arm64: dts: ti: k3-am62: Enable remote processors at " Beleswar Padhi
2025-08-14 22:38 ` [PATCH 22/33] arm64: dts: ti: k3-am62-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 23/33] arm64: dts: ti: k3-am62a: Enable Mailbox nodes at the board level Beleswar Padhi
2025-08-14 22:38 ` [PATCH 24/33] arm64: dts: ti: k3-am62a: Enable remote processors at " Beleswar Padhi
2025-08-14 22:38 ` [PATCH 25/33] arm64: dts: ti: k3-am62a-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 26/33] arm64: dts: ti: k3-am64: Enable remote processors at board level Beleswar Padhi
2025-08-14 22:38 ` [PATCH 27/33] arm64: dts: ti: k3-am642-sr-som: Add missing cfg for TI IPC Firmware Beleswar Padhi
2025-08-14 22:38 ` [PATCH 28/33] arm64: dts: ti: k3-am64-phycore-som: " Beleswar Padhi
2025-08-14 22:38 ` [PATCH 29/33] arm64: dts: ti: k3-am642-tqma64xxl: " Beleswar Padhi
2025-08-14 22:38 ` [PATCH 30/33] arm64: dts: ti: k3-am64-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 31/33] arm64: dts: ti: k3-am65: Enable remote processors at board level Beleswar Padhi
2025-08-14 22:38 ` [PATCH 32/33] arm64: dts: ti: k3-am65-ti-ipc-firmware: Refactor IPC cfg into new dtsi Beleswar Padhi
2025-08-14 22:38 ` [PATCH 33/33] arm64: dts: ti: k3-j7*-ti-ipc-firmware: Switch MCU R5F cluster to Split-mode Beleswar Padhi
2025-08-15  2:41   ` Kumar, Udit
2025-08-15  3:13     ` Nishanth Menon
2025-08-15 15:48   ` Andrew Davis
2025-08-18 15:56     ` Kumar, Udit
2025-08-22 17:26     ` Beleswar Prasad Padhi
2025-08-22 17:31       ` Andrew Davis
2025-08-15  5:49 ` [PATCH 00/33] Refactor TI IPC DT configs into dtsi Wadim Egorov
2025-08-22 17:00   ` Beleswar Prasad Padhi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250821060629.GB7503@francesco-nb \
    --to=francesco@dolcini.it \
    --cc=afd@ti.com \
    --cc=b-padhi@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emanuele.ghidoli@toradex.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=hnagalla@ti.com \
    --cc=jm@ti.com \
    --cc=joao.goncalves@toradex.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=parth.pancholi@toradex.com \
    --cc=robh@kernel.org \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).