* [PATCH] pinctrl: airoha: Fix return value in pinconf callbacks
@ 2025-08-22 12:14 Lorenzo Bianconi
2025-08-22 13:09 ` Linus Walleij
0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2025-08-22 12:14 UTC (permalink / raw)
To: Sean Wang, Linus Walleij, Matthias Brugger,
AngeloGioacchino Del Regno, Benjamin Larsson
Cc: linux-mediatek, linux-gpio, linux-arm-kernel, Lorenzo Bianconi
Pinctrl stack requires ENOTSUPP error code if the parameter is not
supported by the pinctrl driver. Fix the returned error code in pinconf
callbacks if the operation is not supported.
Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/pinctrl/mediatek/pinctrl-airoha.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
index 5f1ec9e0de213d587b68f41d3458cf504ee1b21f..1b2f132d76f0aff78768ed846e8d5980e5b46770 100644
--- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
+++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
@@ -2696,7 +2696,7 @@ static int airoha_pinconf_get(struct pinctrl_dev *pctrl_dev,
arg = 1;
break;
default:
- return -EOPNOTSUPP;
+ return -ENOTSUPP;
}
*config = pinconf_to_config_packed(param, arg);
@@ -2788,7 +2788,7 @@ static int airoha_pinconf_set(struct pinctrl_dev *pctrl_dev,
break;
}
default:
- return -EOPNOTSUPP;
+ return -ENOTSUPP;
}
}
@@ -2805,10 +2805,10 @@ static int airoha_pinconf_group_get(struct pinctrl_dev *pctrl_dev,
if (airoha_pinconf_get(pctrl_dev,
airoha_pinctrl_groups[group].pins[i],
config))
- return -EOPNOTSUPP;
+ return -ENOTSUPP;
if (i && cur_config != *config)
- return -EOPNOTSUPP;
+ return -ENOTSUPP;
cur_config = *config;
}
---
base-commit: 0ae621d78880a406f164a719150dfc66a69b7148
change-id: 20250822-airoha-pinconf-err-val-fix-38f6e78538c7
Best regards,
--
Lorenzo Bianconi <lorenzo@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pinctrl: airoha: Fix return value in pinconf callbacks
2025-08-22 12:14 [PATCH] pinctrl: airoha: Fix return value in pinconf callbacks Lorenzo Bianconi
@ 2025-08-22 13:09 ` Linus Walleij
0 siblings, 0 replies; 2+ messages in thread
From: Linus Walleij @ 2025-08-22 13:09 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: Sean Wang, Matthias Brugger, AngeloGioacchino Del Regno,
Benjamin Larsson, linux-mediatek, linux-gpio, linux-arm-kernel
On Fri, Aug 22, 2025 at 2:14 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> Pinctrl stack requires ENOTSUPP error code if the parameter is not
> supported by the pinctrl driver. Fix the returned error code in pinconf
> callbacks if the operation is not supported.
>
> Fixes: 1c8ace2d0725 ("pinctrl: airoha: Add support for EN7581 SoC")
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Patch applied for fixes.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-23 8:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 12:14 [PATCH] pinctrl: airoha: Fix return value in pinconf callbacks Lorenzo Bianconi
2025-08-22 13:09 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).