* [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups
@ 2025-08-22 13:31 Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 01/10] arm64: dts: fsl-ls1012a: Add default GIC address cells Krzysztof Kozlowski
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
One W=1 warning cleanup for Freescale.
Best regards,
Krzysztof
---
Krzysztof Kozlowski (10):
arm64: dts: fsl-ls1012a: Add default GIC address cells
arm64: dts: fsl-ls1043a: Add default GIC address cells
arm64: dts: fsl-ls1046a: Add default GIC address cells
arm64: dts: imx8dxl: Add default GIC address cells
arm64: dts: imx8mm: Add default GIC address cells
arm64: dts: imx8mp: Add default GIC address cells
arm64: dts: imx8mq: Add default GIC address cells
arm64: dts: imx8qm: Add default GIC address cells
arm64: dts: imx8qxp: Add default GIC address cells
arm64: dts: imx8: Use GIC_SPI for interrupt-map for readability
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 +
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi | 8 ++++----
arch/arm64/boot/dts/freescale/imx8dxl-ss-hsio.dtsi | 8 ++++----
arch/arm64/boot/dts/freescale/imx8dxl.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi | 16 ++++++++--------
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 1 +
12 files changed, 25 insertions(+), 16 deletions(-)
---
base-commit: 812efb8b495f2ca50795062b77415b0e8d9d7e53
change-id: 20250822-b4-dts-interrupt-address-cells-imx-45a128fb371d
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 01/10] arm64: dts: fsl-ls1012a: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 02/10] arm64: dts: fsl-ls1043a: " Krzysztof Kozlowski
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
fsl-ls1012a.dtsi:548.4-551.32: Warning (interrupt_map): /soc/pcie@3400000:interrupt-map:
Missing property '#address-cells' in node /interrupt-controller@1400000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
index dd479889658d452142e6d50b507147ba91c799af..fc3e138077b86cd5e3cf95c3d336cb3c6e1c45ef 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
@@ -87,6 +87,7 @@ pmu {
gic: interrupt-controller@1400000 {
compatible = "arm,gic-400";
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
reg = <0x0 0x1401000 0 0x1000>, /* GICD */
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 02/10] arm64: dts: fsl-ls1043a: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 01/10] arm64: dts: fsl-ls1012a: Add default GIC address cells Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 03/10] arm64: dts: fsl-ls1046a: " Krzysztof Kozlowski
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
fsl-ls1043a.dtsi:330.5-342.26: Warning (interrupt_map): /soc/scfg@1570000/interrupt-controller@1ac:interrupt-map:
Missing property '#address-cells' in node /interrupt-controller@1400000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
index 26bea88cb967ccdb7b3cbae3191476f486c86288..73315c51703943d9ee5e1aa300c388ff6482423f 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
@@ -289,6 +289,7 @@ pmu {
gic: interrupt-controller@1400000 {
compatible = "arm,gic-400";
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
reg = <0x0 0x1401000 0 0x1000>, /* GICD */
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 03/10] arm64: dts: fsl-ls1046a: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 01/10] arm64: dts: fsl-ls1012a: Add default GIC address cells Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 02/10] arm64: dts: fsl-ls1043a: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 04/10] arm64: dts: imx8dxl: " Krzysztof Kozlowski
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
fsl-ls1046a.dtsi:334.5-346.26: Warning (interrupt_map): /soc/scfg@1570000/interrupt-controller@1ac:interrupt-map:
Missing property '#address-cells' in node /interrupt-controller@1400000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
index 4a22fde38bea678ffcaaf44e9984ded687cd2297..770d91ef0310d971d044a1f55cc5e2cb738acc47 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
@@ -260,6 +260,7 @@ pmu {
gic: interrupt-controller@1400000 {
compatible = "arm,gic-400";
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
reg = <0x0 0x1410000 0 0x10000>, /* GICD */
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 04/10] arm64: dts: imx8dxl: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
` (2 preceding siblings ...)
2025-08-22 13:31 ` [PATCH 03/10] arm64: dts: fsl-ls1046a: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 05/10] arm64: dts: imx8mm: " Krzysztof Kozlowski
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
imx8dxl-ss-hsio.dtsi:45.3-48.27: Warning (interrupt_map): /bus@5f000000/pcie@5f010000:interrupt-map:
Missing property '#address-cells' in node /interrupt-controller@51a00000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8dxl.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl.dtsi
index a71d8b32c1920bf9d73020ef48eb98fdbe9adc6f..8d60827822ed1cc6cfb1a9369faaebfd711708d1 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl.dtsi
@@ -92,6 +92,7 @@ gic: interrupt-controller@51a00000 {
compatible = "arm,gic-v3";
reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
<0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base + SGI_base) */
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 05/10] arm64: dts: imx8mm: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
` (3 preceding siblings ...)
2025-08-22 13:31 ` [PATCH 04/10] arm64: dts: imx8dxl: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 06/10] arm64: dts: imx8mp: " Krzysztof Kozlowski
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
imx8mm.dtsi:1355.4-1358.29: Warning (interrupt_map): /soc@0/pcie@33800000:interrupt-map:
Missing property '#address-cells' in node /soc@0/interrupt-controller@38800000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mm.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index ded89b04697014771c20cd7c285d01b73ac9edb9..fc3cd639310ef07d6d14c457af607f61e2288b1e 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -1467,6 +1467,7 @@ gic: interrupt-controller@38800000 {
compatible = "arm,gic-v3";
reg = <0x38800000 0x10000>, /* GIC Dist */
<0x38880000 0xc0000>; /* GICR (RD_base + SGI_base) */
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 06/10] arm64: dts: imx8mp: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
` (4 preceding siblings ...)
2025-08-22 13:31 ` [PATCH 05/10] arm64: dts: imx8mm: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 07/10] arm64: dts: imx8mq: " Krzysztof Kozlowski
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
imx8mp.dtsi:2184.4-2187.29: Warning (interrupt_map): /soc@0/pcie@33800000:interrupt-map:
Missing property '#address-cells' in node /soc@0/interrupt-controller@38800000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
index bb24dba7338ea00dd50c5f7e409d72ecb7d790b9..b57817949d80ae7d891b2168c17d4e1a6311fbbf 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
@@ -2317,6 +2317,7 @@ gic: interrupt-controller@38800000 {
compatible = "arm,gic-v3";
reg = <0x38800000 0x10000>,
<0x38880000 0xc0000>;
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 07/10] arm64: dts: imx8mq: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
` (5 preceding siblings ...)
2025-08-22 13:31 ` [PATCH 06/10] arm64: dts: imx8mp: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 08/10] arm64: dts: imx8qm: " Krzysztof Kozlowski
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
imx8mq.dtsi:1746.4-1749.43: Warning (interrupt_map): /soc@0/pcie@33800000:interrupt-map:
Missing property '#address-cells' in node /soc@0/interrupt-controller@38800000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8mq.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index c9040d1131a80941474806da0741df18bd36b2c8..607962f807bebe52d55976019a210738fa6bb339 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -1890,6 +1890,7 @@ gic: interrupt-controller@38800000 {
<0x31000000 0x2000>, /* GICC */
<0x31010000 0x2000>, /* GICV */
<0x31020000 0x2000>; /* GICH */
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 08/10] arm64: dts: imx8qm: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
` (6 preceding siblings ...)
2025-08-22 13:31 ` [PATCH 07/10] arm64: dts: imx8mq: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 09/10] arm64: dts: imx8qxp: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 10/10] arm64: dts: imx8: Use GIC_SPI for interrupt-map for readability Krzysztof Kozlowski
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
imx8qm-ss-hsio.dtsi:83.3-86.28: Warning (interrupt_map): /bus@5f000000/pcie@5f010000:interrupt-map:
Missing property '#address-cells' in node /interrupt-controller@51a00000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8qm.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
index 827e1365b5dae438d4628852ed6884aa846eb89b..5206ca82eaf642a32299147e9c1b45704075e2b2 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
@@ -245,6 +245,7 @@ gic: interrupt-controller@51a00000 {
<0x0 0x52000000 0 0x2000>, /* GICC */
<0x0 0x52010000 0 0x1000>, /* GICH */
<0x0 0x52020000 0 0x20000>; /* GICV */
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 09/10] arm64: dts: imx8qxp: Add default GIC address cells
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
` (7 preceding siblings ...)
2025-08-22 13:31 ` [PATCH 08/10] arm64: dts: imx8qm: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 10/10] arm64: dts: imx8: Use GIC_SPI for interrupt-map for readability Krzysztof Kozlowski
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Add missing address-cells 0 to GIC interrupt node to silence W=1
warning:
imx8-ss-hsio.dtsi:71.3-74.28: Warning (interrupt_map): /bus@5f000000/pcie@5f010000:interrupt-map:
Missing property '#address-cells' in node /interrupt-controller@51a00000, using 0 as fallback
Value '0' is correct because:
1. GIC interrupt controller does not have children,
2. interrupt-map property (in PCI node) consists of five components and
the fourth component "parent unit address", which size is defined by
'#address-cells' of the node pointed to by the interrupt-parent
component, is not used (=0)
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
index 9e46e16a8dc06448c6eb1796a3ffe70acb09374a..95edab058276bcfc87b9bd85426b999d1ab32360 100644
--- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
@@ -159,6 +159,7 @@ gic: interrupt-controller@51a00000 {
compatible = "arm,gic-v3";
reg = <0x0 0x51a00000 0 0x10000>, /* GIC Dist */
<0x0 0x51b00000 0 0xc0000>; /* GICR (RD_base + SGI_base) */
+ #address-cells = <0>;
#interrupt-cells = <3>;
interrupt-controller;
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 10/10] arm64: dts: imx8: Use GIC_SPI for interrupt-map for readability
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
` (8 preceding siblings ...)
2025-08-22 13:31 ` [PATCH 09/10] arm64: dts: imx8qxp: " Krzysztof Kozlowski
@ 2025-08-22 13:31 ` Krzysztof Kozlowski
9 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2025-08-22 13:31 UTC (permalink / raw)
To: Shawn Guo, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam
Cc: linux-arm-kernel, devicetree, linux-kernel, imx,
Krzysztof Kozlowski
Decoding interrupt-map is tricky, because it consists of five
components. Use known GIC_SPI define in final interrupt specifier
component makes easier to read.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi | 8 ++++----
arch/arm64/boot/dts/freescale/imx8dxl-ss-hsio.dtsi | 8 ++++----
arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi | 16 ++++++++--------
3 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
index 9b8b1380c4c2bb25f691d72a0217915cf3824889..469de8b536b5866ea83cc0542941039996ae5f23 100644
--- a/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8-ss-hsio.dtsi
@@ -68,10 +68,10 @@ pcieb: pcie@5f010000 {
clock-names = "dbi", "mstr", "slv";
bus-range = <0x00 0xff>;
device_type = "pci";
- interrupt-map = <0 0 0 1 &gic 0 105 4>,
- <0 0 0 2 &gic 0 106 4>,
- <0 0 0 3 &gic 0 107 4>,
- <0 0 0 4 &gic 0 108 4>;
+ interrupt-map = <0 0 0 1 &gic GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 2 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 3 &gic GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 4 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
interrupt-map-mask = <0 0 0 0x7>;
num-lanes = <1>;
num-viewport = <4>;
diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8dxl-ss-hsio.dtsi
index bbc6abb0fdf25b650dacb8dfcbbbe5dac9ed5cce..ec466e4d7df5467803243404795a9a6a1da890b2 100644
--- a/arch/arm64/boot/dts/freescale/imx8dxl-ss-hsio.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8dxl-ss-hsio.dtsi
@@ -42,10 +42,10 @@ pcie0: pcie@5f010000 {
#interrupt-cells = <1>;
interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "msi";
- interrupt-map = <0 0 0 1 &gic 0 47 4>,
- <0 0 0 2 &gic 0 48 4>,
- <0 0 0 3 &gic 0 49 4>,
- <0 0 0 4 &gic 0 50 4>;
+ interrupt-map = <0 0 0 1 &gic GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 2 &gic GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 3 &gic GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 4 &gic GIC_SPI 50 IRQ_TYPE_LEVEL_HIGH>;
interrupt-map-mask = <0 0 0 0x7>;
};
diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
index 50c0f6b0f0bdc2bd6fd3a19e08d1b7a723353783..bd6e0aa27efe90d3489c16c705d508028b268ee7 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
@@ -30,10 +30,10 @@ pcie0: pciea: pcie@5f000000 {
clock-names = "dbi", "mstr", "slv";
bus-range = <0x00 0xff>;
device_type = "pci";
- interrupt-map = <0 0 0 1 &gic 0 73 4>,
- <0 0 0 2 &gic 0 74 4>,
- <0 0 0 3 &gic 0 75 4>,
- <0 0 0 4 &gic 0 76 4>;
+ interrupt-map = <0 0 0 1 &gic GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 2 &gic GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 3 &gic GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 4 &gic GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
interrupt-map-mask = <0 0 0 0x7>;
num-lanes = <1>;
num-viewport = <4>;
@@ -80,10 +80,10 @@ pcie1: pcieb: pcie@5f010000 {
clock-names = "dbi", "mstr", "slv";
bus-range = <0x00 0xff>;
device_type = "pci";
- interrupt-map = <0 0 0 1 &gic 0 105 4>,
- <0 0 0 2 &gic 0 106 4>,
- <0 0 0 3 &gic 0 107 4>,
- <0 0 0 4 &gic 0 108 4>;
+ interrupt-map = <0 0 0 1 &gic GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 2 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 3 &gic GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
+ <0 0 0 4 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
interrupt-map-mask = <0 0 0 0x7>;
num-lanes = <1>;
num-viewport = <4>;
--
2.48.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2025-08-23 9:34 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-22 13:31 [PATCH 00/10] arm64: dts: freescale/nxp/imx: Minor GIC interrupt-map cleanups Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 01/10] arm64: dts: fsl-ls1012a: Add default GIC address cells Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 02/10] arm64: dts: fsl-ls1043a: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 03/10] arm64: dts: fsl-ls1046a: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 04/10] arm64: dts: imx8dxl: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 05/10] arm64: dts: imx8mm: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 06/10] arm64: dts: imx8mp: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 07/10] arm64: dts: imx8mq: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 08/10] arm64: dts: imx8qm: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 09/10] arm64: dts: imx8qxp: " Krzysztof Kozlowski
2025-08-22 13:31 ` [PATCH 10/10] arm64: dts: imx8: Use GIC_SPI for interrupt-map for readability Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).