From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 74196CA0EED for ; Mon, 25 Aug 2025 03:06:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zc0D+AKRBVahZLN09XFTNDxvFlIQ9tA5x14f6DoX6Xs=; b=ugTFDPN/A0aU29qbKvN/WzC/CI 4KQVff7KjS/yAKMSyOQ2kear7mmu73jS08sUsm9U8rEkCDN3mM4X+ED5xVloakKbnpPaVj3D/6NOR c5KRs9TEBqGihp0yB6XDdotQZ6tO2q/SAF9Oivt8RKNKnGBx/wvyDasxb54bieR5nuYgnKTCjnTb4 aLKFFOB/1wtZqU90rKpmuSucngTo51+xzN7sXGfJ3p5FoDdTsJi4WM5tiCSCbpOAAOsX8dwYGV4GG JMuVJSeI4bbD4ZPfnzF4L82c0uIIhFI6wNEoOv4jtmeMxgBT874+7uHeImoWEgkvnR3Q9BVfSWHi4 1K4xM1Zw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqNXZ-00000006mnp-3hNO; Mon, 25 Aug 2025 03:06:37 +0000 Received: from mail-qt1-x832.google.com ([2607:f8b0:4864:20::832]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uqNN4-00000006lUc-3seV for linux-arm-kernel@lists.infradead.org; Mon, 25 Aug 2025 02:55:48 +0000 Received: by mail-qt1-x832.google.com with SMTP id d75a77b69052e-4b109c58e29so75004801cf.3 for ; Sun, 24 Aug 2025 19:55:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1756090546; x=1756695346; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zc0D+AKRBVahZLN09XFTNDxvFlIQ9tA5x14f6DoX6Xs=; b=JIcVQOzDMwu8Ww5hPXweQKGb4AJkAJ62YAdKgSyTPVbofqWzABq5y5qZ09N4BcbVXt Gz9UFlmxjBmv/tl/Cc+BnS2EU95TE5mSgou+A5jxGVE9QJbGxCvBVyXvdWQs6znHedrR 5oqfxsOrgnzyPbfWVhBzS/HiAIG2dvVOIVdGOoleNjLY6kwvG9BksbJPcONuwB4KWZnd Ay7CWyZwC4W59w/5oJwU2P9Hhxs5nJbZmxLVSZBh22jYYIuSv+w3DRNeuvjfmfXoFl0J 3fVEqSvhn3yrOENYH7S5ck/iKfTSg+7VfU7W5Mf/rnxoeXLNhAcLTZgPtQXacrQObv8x Hj4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756090546; x=1756695346; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zc0D+AKRBVahZLN09XFTNDxvFlIQ9tA5x14f6DoX6Xs=; b=O8o7vnNEIppYcBM7RxeHgQumK1CYRB1Cijz9f4gKrNUMqANNfMIxsPoYo5GP7Nh0/a C69Vv7Im5B5gWBFVq7WHfVolFXPFVX9BhPTG7exonfrBC4dWnltV0RC7msjrdZrC6s7e NPEyx4i/3KWOgBDN0a+G+4yQDof4NIJsBYwToLfZk5oeZRuIOnJbb3DkE/jZbSt87e/I B3Jbbn3+qPOG2ojRHoThLFhH85ok4S5GRvEXYZdhC6Ctu7rPbqepD9oBUCPV5WD5j7Re JVtdA3rKoIx2LBVDZ96fmNPh/s1Oi2jZO22xhye6KKAUFzbrLAxs+nqS4KGQr1gljZlU 6q5A== X-Forwarded-Encrypted: i=1; AJvYcCUSuZchVB/Uz5H8i45wX7W8ifSTeWgXOEt0aiNDxdKYVTofXQLKg9494XaENbHFMhjuG3W+oz1D/tVFJv+Hdty5@lists.infradead.org X-Gm-Message-State: AOJu0YwmvXRTzm76VICZVkE7BWLSI1f85GIM6GVnoH8hO6i6PuI2jy4v FHEhLAsE7iHjKZksNbMStx570nIbzEjEAPPOQlGIL6DNkCJp2E9zurxj X-Gm-Gg: ASbGncsLcBxl9RXsrXzWuvt9UTeCHrVcyirLkgvvHnDNLNqxrUdhyq8ZdmC2XpmcBQw LCLQI8vTXLcPrMl0y0l8YxaSxZFiSjpsyDcld5oAOaaX/GbNDC6v7xyDJJS0koWnnJE7/joIYyf fpm/Gr0RUzd1Z6dX5+NJwx1OW5vcrtvP9SIBba7KMHjBTXiStL2dc5a5lOEmiyrw7BAEbZgPpHO L/FBouPBv/WPv4mjYTyfROQK1kbGXVL4MrtEtV07jQrg7WAUpdnyRDY7XcbHJjgFlQYG0HGZwSx zhyv8o/VfHgCELaYKOt/lmplDl7x0XNfxqA0/PQisOKsxiiNDAgybIoqwmbHmB+3ousQX6Wtyht Dq7hwAyirtj8Op7qgEN1xFEgIDVw02w== X-Google-Smtp-Source: AGHT+IFWf+0yFKOAjNKcLyByBbWIg5yxPlSf1hO+uUtWIIIIVmxke6gbxyvdbizcCOTEM6m28gQ2yA== X-Received: by 2002:a05:622a:144d:b0:4af:195a:b92e with SMTP id d75a77b69052e-4b2aab49916mr128691271cf.39.1756090545693; Sun, 24 Aug 2025 19:55:45 -0700 (PDT) Received: from [127.0.0.1] ([172.191.151.57]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b2b8c61adcsm43970491cf.5.2025.08.24.19.55.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Aug 2025 19:55:45 -0700 (PDT) From: Denzeel Oliva Date: Mon, 25 Aug 2025 02:55:43 +0000 Subject: [PATCH v3 1/4] clk: samsung: exynos990: Fix CMU TOP mux/div widths and add fixed-factors MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250825-cmu-top-v3-1-8838641432dc@gmail.com> References: <20250825-cmu-top-v3-0-8838641432dc@gmail.com> In-Reply-To: <20250825-cmu-top-v3-0-8838641432dc@gmail.com> To: Krzysztof Kozlowski , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Rob Herring , Conor Dooley Cc: linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Denzeel Oliva X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1756090544; l=6467; i=wachiturroxd150@gmail.com; s=20250825; h=from:subject:message-id; bh=20mWLZEGgEbpDt41ggUQHBXHpARZ9CqTlFdX4+rxceg=; b=9eQUrHFA6JWiUOj54Of+ZRMj8QCvqjd9UJnx8FYg3p3AOXXkhni3E4qcxIyzUy4XPrPm3x2Zg y6ItJ8CskQ1DTmpTiIaeN6nS9qzy743P+DY2EByLJaf+1FfzWVulCey X-Developer-Key: i=wachiturroxd150@gmail.com; a=ed25519; pk=qZrip2idhSTNQABELWG6WKCrg9xOKep//pV9JGKmW5k= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250824_195546_993046_F9F38A75 X-CRM114-Status: GOOD ( 11.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Correct mux/div bit widths in CMU TOP (DPU, DSP_BUS, G2D_MSCL, HSI0/1/2). Replace wrong divs with fixed-factor clocks for HSI1/2 PCIe and USBDP debug. Also add OTP rate in ffactor. These align with Exynos990 downstream cmucal and ensure correct parent/rate selection. Signed-off-by: Denzeel Oliva --- drivers/clk/samsung/clk-exynos990.c | 37 +++++++++++++++++++++---------------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos990.c b/drivers/clk/samsung/clk-exynos990.c index 8d3f193d2..105ba0363 100644 --- a/drivers/clk/samsung/clk-exynos990.c +++ b/drivers/clk/samsung/clk-exynos990.c @@ -759,11 +759,11 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = { MUX(CLK_MOUT_CMU_DPU_ALT, "mout_cmu_dpu_alt", mout_cmu_dpu_alt_p, CLK_CON_MUX_MUX_CLKCMU_DPU_ALT, 0, 2), MUX(CLK_MOUT_CMU_DSP_BUS, "mout_cmu_dsp_bus", - mout_cmu_dsp_bus_p, CLK_CON_MUX_MUX_CLKCMU_DSP_BUS, 0, 2), + mout_cmu_dsp_bus_p, CLK_CON_MUX_MUX_CLKCMU_DSP_BUS, 0, 3), MUX(CLK_MOUT_CMU_G2D_G2D, "mout_cmu_g2d_g2d", mout_cmu_g2d_g2d_p, CLK_CON_MUX_MUX_CLKCMU_G2D_G2D, 0, 2), MUX(CLK_MOUT_CMU_G2D_MSCL, "mout_cmu_g2d_mscl", - mout_cmu_g2d_mscl_p, CLK_CON_MUX_MUX_CLKCMU_G2D_MSCL, 0, 1), + mout_cmu_g2d_mscl_p, CLK_CON_MUX_MUX_CLKCMU_G2D_MSCL, 0, 2), MUX(CLK_MOUT_CMU_HPM, "mout_cmu_hpm", mout_cmu_hpm_p, CLK_CON_MUX_MUX_CLKCMU_HPM, 0, 2), MUX(CLK_MOUT_CMU_HSI0_BUS, "mout_cmu_hsi0_bus", @@ -775,7 +775,7 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = { 0, 2), MUX(CLK_MOUT_CMU_HSI0_USBDP_DEBUG, "mout_cmu_hsi0_usbdp_debug", mout_cmu_hsi0_usbdp_debug_p, - CLK_CON_MUX_MUX_CLKCMU_HSI0_USBDP_DEBUG, 0, 2), + CLK_CON_MUX_MUX_CLKCMU_HSI0_USBDP_DEBUG, 0, 1), MUX(CLK_MOUT_CMU_HSI1_BUS, "mout_cmu_hsi1_bus", mout_cmu_hsi1_bus_p, CLK_CON_MUX_MUX_CLKCMU_HSI1_BUS, 0, 3), MUX(CLK_MOUT_CMU_HSI1_MMC_CARD, "mout_cmu_hsi1_mmc_card", @@ -788,7 +788,7 @@ static const struct samsung_mux_clock top_mux_clks[] __initconst = { 0, 2), MUX(CLK_MOUT_CMU_HSI1_UFS_EMBD, "mout_cmu_hsi1_ufs_embd", mout_cmu_hsi1_ufs_embd_p, CLK_CON_MUX_MUX_CLKCMU_HSI1_UFS_EMBD, - 0, 1), + 0, 2), MUX(CLK_MOUT_CMU_HSI2_BUS, "mout_cmu_hsi2_bus", mout_cmu_hsi2_bus_p, CLK_CON_MUX_MUX_CLKCMU_HSI2_BUS, 0, 1), MUX(CLK_MOUT_CMU_HSI2_PCIE, "mout_cmu_hsi2_pcie", @@ -862,7 +862,7 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_PLL_SHARED4_DIV4, 0, 1), DIV(CLK_DOUT_CMU_APM_BUS, "dout_cmu_apm_bus", "gout_cmu_apm_bus", - CLK_CON_DIV_CLKCMU_APM_BUS, 0, 3), + CLK_CON_DIV_CLKCMU_APM_BUS, 0, 2), DIV(CLK_DOUT_CMU_AUD_CPU, "dout_cmu_aud_cpu", "gout_cmu_aud_cpu", CLK_CON_DIV_CLKCMU_AUD_CPU, 0, 3), DIV(CLK_DOUT_CMU_BUS0_BUS, "dout_cmu_bus0_bus", "gout_cmu_bus0_bus", @@ -887,9 +887,9 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_CLKCMU_CMU_BOOST, 0, 2), DIV(CLK_DOUT_CMU_CORE_BUS, "dout_cmu_core_bus", "gout_cmu_core_bus", CLK_CON_DIV_CLKCMU_CORE_BUS, 0, 4), - DIV(CLK_DOUT_CMU_CPUCL0_DBG_BUS, "dout_cmu_cpucl0_debug", + DIV(CLK_DOUT_CMU_CPUCL0_DBG_BUS, "dout_cmu_cpucl0_dbg_bus", "gout_cmu_cpucl0_dbg_bus", CLK_CON_DIV_CLKCMU_CPUCL0_DBG_BUS, - 0, 3), + 0, 4), DIV(CLK_DOUT_CMU_CPUCL0_SWITCH, "dout_cmu_cpucl0_switch", "gout_cmu_cpucl0_switch", CLK_CON_DIV_CLKCMU_CPUCL0_SWITCH, 0, 3), DIV(CLK_DOUT_CMU_CPUCL1_SWITCH, "dout_cmu_cpucl1_switch", @@ -924,16 +924,11 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_CLKCMU_HSI0_DPGTC, 0, 3), DIV(CLK_DOUT_CMU_HSI0_USB31DRD, "dout_cmu_hsi0_usb31drd", "gout_cmu_hsi0_usb31drd", CLK_CON_DIV_CLKCMU_HSI0_USB31DRD, 0, 4), - DIV(CLK_DOUT_CMU_HSI0_USBDP_DEBUG, "dout_cmu_hsi0_usbdp_debug", - "gout_cmu_hsi0_usbdp_debug", CLK_CON_DIV_CLKCMU_HSI0_USBDP_DEBUG, - 0, 4), DIV(CLK_DOUT_CMU_HSI1_BUS, "dout_cmu_hsi1_bus", "gout_cmu_hsi1_bus", CLK_CON_DIV_CLKCMU_HSI1_BUS, 0, 3), DIV(CLK_DOUT_CMU_HSI1_MMC_CARD, "dout_cmu_hsi1_mmc_card", "gout_cmu_hsi1_mmc_card", CLK_CON_DIV_CLKCMU_HSI1_MMC_CARD, 0, 9), - DIV(CLK_DOUT_CMU_HSI1_PCIE, "dout_cmu_hsi1_pcie", "gout_cmu_hsi1_pcie", - CLK_CON_DIV_CLKCMU_HSI1_PCIE, 0, 7), DIV(CLK_DOUT_CMU_HSI1_UFS_CARD, "dout_cmu_hsi1_ufs_card", "gout_cmu_hsi1_ufs_card", CLK_CON_DIV_CLKCMU_HSI1_UFS_CARD, 0, 3), @@ -942,8 +937,6 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { 0, 3), DIV(CLK_DOUT_CMU_HSI2_BUS, "dout_cmu_hsi2_bus", "gout_cmu_hsi2_bus", CLK_CON_DIV_CLKCMU_HSI2_BUS, 0, 4), - DIV(CLK_DOUT_CMU_HSI2_PCIE, "dout_cmu_hsi2_pcie", "gout_cmu_hsi2_pcie", - CLK_CON_DIV_CLKCMU_HSI2_PCIE, 0, 7), DIV(CLK_DOUT_CMU_IPP_BUS, "dout_cmu_ipp_bus", "gout_cmu_ipp_bus", CLK_CON_DIV_CLKCMU_IPP_BUS, 0, 4), DIV(CLK_DOUT_CMU_ITP_BUS, "dout_cmu_itp_bus", "gout_cmu_itp_bus", @@ -979,8 +972,18 @@ static const struct samsung_div_clock top_div_clks[] __initconst = { CLK_CON_DIV_CLKCMU_TNR_BUS, 0, 4), DIV(CLK_DOUT_CMU_VRA_BUS, "dout_cmu_vra_bus", "gout_cmu_vra_bus", CLK_CON_DIV_CLKCMU_VRA_BUS, 0, 4), - DIV(CLK_DOUT_CMU_DPU, "dout_cmu_clkcmu_dpu", "gout_cmu_dpu", - CLK_CON_DIV_DIV_CLKCMU_DPU, 0, 4), + DIV(CLK_DOUT_CMU_DPU, "dout_cmu_dpu", "gout_cmu_dpu", + CLK_CON_DIV_DIV_CLKCMU_DPU, 0, 3), +}; + +static const struct samsung_fixed_factor_clock cmu_top_ffactor[] __initconst = { + FFACTOR(CLK_DOUT_CMU_HSI1_PCIE, "dout_cmu_hsi1_pcie", + "gout_cmu_hsi1_pcie", 1, 8, 0), + FFACTOR(CLK_DOUT_CMU_OTP, "dout_cmu_otp", "oscclk", 1, 8, 0), + FFACTOR(CLK_DOUT_CMU_HSI0_USBDP_DEBUG, "dout_cmu_hsi0_usbdp_debug", + "gout_cmu_hsi0_usbdp_debug", 1, 8, 0), + FFACTOR(CLK_DOUT_CMU_HSI2_PCIE, "dout_cmu_hsi2_pcie", + "gout_cmu_hsi2_pcie", 1, 8, 0), }; static const struct samsung_gate_clock top_gate_clks[] __initconst = { @@ -1126,6 +1129,8 @@ static const struct samsung_cmu_info top_cmu_info __initconst = { .nr_mux_clks = ARRAY_SIZE(top_mux_clks), .div_clks = top_div_clks, .nr_div_clks = ARRAY_SIZE(top_div_clks), + .fixed_factor_clks = cmu_top_ffactor, + .nr_fixed_factor_clks = ARRAY_SIZE(cmu_top_ffactor), .gate_clks = top_gate_clks, .nr_gate_clks = ARRAY_SIZE(top_gate_clks), .nr_clk_ids = CLKS_NR_TOP, -- 2.50.1