From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Xion Wang (王鑫)" <Xion.Wang@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
wsd_upstream <wsd_upstream@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Huadian Liu (刘华典)" <huadian.liu@mediatek.com>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/1] misc: Prevent double registration and deregistration of miscdevice
Date: Tue, 26 Aug 2025 12:40:45 +0200 [thread overview]
Message-ID: <2025082631-hypnotist-snazzy-147a@gregkh> (raw)
In-Reply-To: <1ffa28bf6e3dcde83a6a6a5dde163596c4db639d.camel@mediatek.com>
On Tue, Aug 26, 2025 at 07:58:47AM +0000, Xion Wang (王鑫) wrote:
> > Again, this shouldn't be something that any driver should hit as this
> > usage is not in the kernel tree that I can see. Attempting to
> > re-register a device multiple times is normally never a good idea.
>
> Thank you for your comments.
>
> I am not the owner of the WiFi driver and do not have full details of
> its internal logic. However, during internal integration and stress
> testing, we observed an issue where repeated registration and
> deregistration of a misc device by the WiFi module led to corruption of
> the misc_list. While I cannot provide the exact reasoning behind the
> WiFi driver's design, I wanted to report the problem and share our
> findings with the community in case similar patterns exist elsewhere,
> including in vendor or out-of-tree drivers.
We do not "harden" our internal apis for external drivers, we fix
drivers to not do foolish things :)
Please fix your out-of-tree code, it should not be even touching the
miscdev api, as that is not something a wifi driver should be
interacting with. Please use the correct one instead, and then you will
not have this type of issue.
thanks,
greg k-h
next prev parent reply other threads:[~2025-08-26 11:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-25 8:45 [PATCH 0/1] misc: Prevent double registration and deregistration of miscdevice xion.wang
2025-08-25 8:45 ` [PATCH 1/1] " xion.wang
2025-08-25 20:28 ` Greg Kroah-Hartman
2025-08-26 2:55 ` Xion Wang (王鑫)
2025-08-26 7:05 ` gregkh
2025-08-26 7:58 ` Xion Wang (王鑫)
2025-08-26 10:40 ` gregkh [this message]
2025-08-26 12:09 ` Xion Wang (王鑫)
2025-08-26 12:54 ` gregkh
2025-09-02 1:42 ` Xion Wang (王鑫)
2025-08-25 20:27 ` [PATCH 0/1] " Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025082631-hypnotist-snazzy-147a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Xion.Wang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=huadian.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox