From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBE86CA0EED for ; Thu, 28 Aug 2025 20:47:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jAO2WeXDFkbtwkjKyd1xrqU98u0EGyjojmTyXcAuE7w=; b=k7qjy5Idk0rMX7SL4Ml4YyHMRu FYVQO95ZwuWqajNWgBv2wuG7zuFBMSbumpHqA6UqeWX5vb54dcBGE7A+8j2MzRon8hLi1PUXNzd9Q hixOgmaTZtkFjMvtfJ+vZwnt0y7QbfPEzLYWj5pfORFEgHOGbBrgfDFYyY0HHL/7vuBPEmPmmQNnn 6xWJBmIULgmOxNKQDvJ+EVeijjGDiRIRdzHfXrRnK0X38yJEDJq9dHx5d24qF7D2WlgQQr6DvRhv7 dP47xCui3LY2aGTLcr9nNhHkcn6vuYZEhzGO3jy8cQ7sqqX2PHMWi8HqsIQQA/xGIidOo1ox723Tf NY9jIvpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urjX6-00000003DW4-36qZ; Thu, 28 Aug 2025 20:47:44 +0000 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1urf3O-00000002BV7-3xyh for linux-arm-kernel@lists.infradead.org; Thu, 28 Aug 2025 16:00:48 +0000 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-45b7c01a8c1so6240775e9.2 for ; Thu, 28 Aug 2025 09:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1756396845; x=1757001645; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jAO2WeXDFkbtwkjKyd1xrqU98u0EGyjojmTyXcAuE7w=; b=lnYckaq9SdvvUdizwmKYzLJ2XDDRosMyDfLD3Mg0SBizxqlk2oj2BLm8dLcSIUQth3 bLaIqtW1Y1jQBi6t3M82RP48qhPURsJ/TgTESKAiIsR5gxmzjQ0zf+XNw8wXBfvM6Txv SBRxhtsnXcymJ8lc/zjxumwvb0/0T35bbHG11x7vcN/daLizOCPz6tv/8fd0j7PNLA3G nswEqfebqYfYJ2ESLrraLd98fh7FioPpVr8MB+Zj2rLoJ2sbgvU0rER8d5NXWLXQ4jND WDCBHqpijpv6SLAuG8zHj0uJ+CX5iRpKTk6jpKxqd/hoLJfZPV3S3ivZ6bP6AwS5S0v7 uDiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756396845; x=1757001645; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jAO2WeXDFkbtwkjKyd1xrqU98u0EGyjojmTyXcAuE7w=; b=w4XWHXJAXPVssrHDj9GjuzG5jXSkCoGEiK38EL/Fp5dhBRpqvBWA0aN+QHJMU2024a 7OsJFTmCBTPWL8tybDi5xNzZEitfZsnJagRxc6nByoEPSCVJ1R9tijc08i2XxrShujie bVoF41Iwk21uWmA1J/lkEam3SC1FRUiBka9lQk2+yuCGgBo0avct5ub3F0V3ot2xsw// EqtpNkLjwnUGdLoisW9PxDeNmtzblzcWXTIZf1IiUu8r/dS2B1YpKSYnXjzl0IZ6F5oI B4QeIQR5DdyFr3D9eEH7H286Sfh2/YeRGbtuHs56CR4WoUQWhlGX/6WsEInFhyeMfeXt l4gA== X-Forwarded-Encrypted: i=1; AJvYcCVUPF557bSOscNUG87LzafGKJnnogyA5bpB9RZ86ZfAQ5r5261anEd25fX53kfKuBqa9k/GtQqvfuBu+oUlqQts@lists.infradead.org X-Gm-Message-State: AOJu0YwlYuM9fLmV52upwCJ9SaD3tNEW8RUyZ9VWa1Vn/lNwdwv4eMO9 WwBAQZ0AAjPNHfhgsbu8Mgy4JNGc8XCQUEcgtGK4FopbcRjXpD/R44WFqsVlybpo/Qw= X-Gm-Gg: ASbGncsvgKGz1Iq+9tOEz6aOtmeX7bb/Vdo1m9r/8rVV79dWVe5ij9ZXEN2rDy1SqvB zIiPnET7wkz1Sxfmk11S9zAky2jbXfa68Pho7NXKeHb/reUgwkrLp5Yzoppef0YdJkPQLas4Bug BUdhGt5bK2PVpo6sMdMSY1AUacFpd7BC1iqByQtNqEbNcS1nuSLjIRg2ywfXv6pYe90HHRb6RV3 +BZH1PKpxMLMyKZJGSmCD9CIy32DetxN4XZuFPkCg9mYp/MuduFZcye5XIa5drleugh0ZCtDnor QGf3iBqfFYbThoRpTn16xTMUlc5NaG15FFMbsdXey0gl9VB5qTZTToGlUVxhRQ3mwjdZ/59epmC xc5SlfwF/suXJJIR66g== X-Google-Smtp-Source: AGHT+IH9eqAsu0mBkmZO1sLp4iQB82doTTOSGeYtxhUeFPIbPn5xY/WnY8KAWmQi9Jdt7MPymPYo1A== X-Received: by 2002:a05:600c:4f05:b0:45b:5f5e:f1e4 with SMTP id 5b1f17b1804b1-45b648111dfmr100878215e9.27.1756396845191; Thu, 28 Aug 2025 09:00:45 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4933:4d7c:cf69:9502]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45b6f0c6fe5sm80211675e9.5.2025.08.28.09.00.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Aug 2025 09:00:44 -0700 (PDT) From: Bartosz Golaszewski Date: Thu, 28 Aug 2025 18:00:23 +0200 Subject: [PATCH v6 15/15] pinctrl: qcom: make the pinmuxing strict MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20250828-pinctrl-gpio-pinfuncs-v6-15-c9abb6bdb689@linaro.org> References: <20250828-pinctrl-gpio-pinfuncs-v6-0-c9abb6bdb689@linaro.org> In-Reply-To: <20250828-pinctrl-gpio-pinfuncs-v6-0-c9abb6bdb689@linaro.org> To: Linus Walleij , Bjorn Andersson , Konrad Dybcio , Alexey Klimov , Lorenzo Bianconi , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Paul Cercueil , Kees Cook , Andy Shevchenko , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Dong Aisheng , Fabio Estevam , Shawn Guo , Jacky Bai , Pengutronix Kernel Team , NXP S32 Linux Team , Sascha Hauer , Tony Lindgren , Haojian Zhuang , Geert Uytterhoeven , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Neil Armstrong , Mark Brown Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, imx@lists.linux.dev, linux-omap@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Bartosz Golaszewski , Konrad Dybcio X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1142; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=M6AAfE1ZYIqFZsBoDZ4O1bJllvK/6bMXFJ6Zryc+i/E=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBosH0PX+ObgCFGCgqoUrUjW902keUOxgLE8EUsB XcES2lA2qmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaLB9DwAKCRARpy6gFHHX ctL5D/9vpjY2JraOKI6xQLDzt9TXljIFuNDozQLvzOHyC9MgvKOWbsLqyOrunHPfrNqqKOFBK3T KwmfdS1uCAhkPVJFu9+QIjoLLd5p693JFSuHkObJvgCet04MNbRQLB5JHqL6iuH+bu9MyubXgwJ krZwBmRMnrDWPenruj6k4hAA2ihAQlUx9GOdKpiLfvYH8b6RAkHtDQPWjO21WqCLg4XFku4EESO 5IruyaJkV3MTpbYIobh2C/a6mUW8SqezSSh1LG4Bd1XobET0b8+hWmght65TmOvonC+GLe5r2Wh pLFBhM0QRVLHeqtJgYx4uIqUU9M0k9AXIOR9238ttf3Ct3ldZ9ZfTONb3jNBXOp9939T7h4ZLpx SUaPlc2TzAFEbRUJNonPEbxaaa0+qbqTjF9ltT5tZC1Mlqr8pyzA1YH8BN9wyrbK4N6qH1ty3MJ 6emE/yXMZFLsGd8hOSA+egnDYIO5BK1s91hpGWU/ZY/fadrMn6UtPYHf85JlfFzmhIlsS9nHjfY oLMcdYawGwDD/MdG1Dt9y2yWY+0T4iNxJoUqYKmpisWrARyHw/iR5VjqJFS50k88+CJMB1H36z0 letY3JTa4NNIETPLbq0dvyWaZmnqCNmCzEgKPyWyC7sxmk66PTtyQoJj32nMAH62uZVZ+A6DZeE zit65McHjdrqSGA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250828_090047_029552_811FDDBB X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski The strict flag in struct pinmux_ops disallows the usage of the same pin as a GPIO and for another function. Without it, a rouge user-space process with enough privileges (or even a buggy driver) can request a used pin as GPIO and drive it, potentially confusing devices or even crashing the system. Set it globally for all pinctrl-msm users. Reviewed-by: Konrad Dybcio Signed-off-by: Bartosz Golaszewski --- drivers/pinctrl/qcom/pinctrl-msm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pinctrl/qcom/pinctrl-msm.c b/drivers/pinctrl/qcom/pinctrl-msm.c index a5f69464827119dfe2a7781b558094b283fca215..1751d838ce95d6138c824b90098f74891dec7656 100644 --- a/drivers/pinctrl/qcom/pinctrl-msm.c +++ b/drivers/pinctrl/qcom/pinctrl-msm.c @@ -268,6 +268,7 @@ static const struct pinmux_ops msm_pinmux_ops = { .function_is_gpio = pinmux_generic_function_is_gpio, .gpio_request_enable = msm_pinmux_request_gpio, .set_mux = msm_pinmux_set_mux, + .strict = true, }; static int msm_config_reg(struct msm_pinctrl *pctrl, -- 2.48.1