From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Luo Jie <quic_luoj@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Anusha Rao <quic_anusha@quicinc.com>,
Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
Devi Priya <quic_devipriy@quicinc.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com,
quic_linchen@quicinc.com, quic_leiwei@quicinc.com,
quic_pavir@quicinc.com, quic_suruchia@quicinc.com
Subject: Re: [PATCH v4 06/10] dt-bindings: clock: Add required "interconnect-cells" property
Date: Fri, 29 Aug 2025 09:37:02 +0200 [thread overview]
Message-ID: <20250829-ubiquitous-imaginary-mammoth-d52bde@kuoka> (raw)
In-Reply-To: <20250828-qcom_ipq5424_nsscc-v4-6-cb913b205bcb@quicinc.com>
On Thu, Aug 28, 2025 at 06:32:19PM +0800, Luo Jie wrote:
> ICC clocks are always provided by the NSS clock controller of IPQ9574,
> so add interconnect-cells as required DT property.
Does not make sense. If clocks are always, you require different
property?
>
> Fixes: 28300ecedce4 ("dt-bindings: clock: Add ipq9574 NSSCC clock and reset definitions")
> Signed-off-by: Luo Jie <quic_luoj@quicinc.com>
Fixes cannot be in the middle of patchset.
See submitting patches and your internal guideline explaining it with
great details.
> ---
> Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> index 17252b6ea3be..fc604279114f 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,ipq9574-nsscc.yaml
> @@ -57,6 +57,7 @@ required:
> - compatible
> - clocks
> - clock-names
> + - '#interconnect-cells'
ABI break without explanation.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-29 7:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 10:32 [PATCH v4 00/10] Add Network Subsystem (NSS) clock controller support for IPQ5424 SoC Luo Jie
2025-08-28 10:32 ` [PATCH v4 01/10] clk: qcom: gcc-ipq5424: Correct the icc_first_node_id Luo Jie
2025-09-02 12:07 ` Konrad Dybcio
2025-08-28 10:32 ` [PATCH v4 02/10] dt-bindings: interconnect: Add Qualcomm IPQ5424 NSSNOC IDs Luo Jie
2025-08-28 10:32 ` [PATCH v4 03/10] clk: qcom: gcc-ipq5424: Enable NSS NoC clocks to use icc-clk Luo Jie
2025-09-02 12:11 ` Konrad Dybcio
2025-08-28 10:32 ` [PATCH v4 04/10] dt-bindings: clock: gcc-ipq5424: Add definition for GPLL0_OUT_AUX Luo Jie
2025-08-28 10:32 ` [PATCH v4 05/10] clk: qcom: gcc-ipq5424: Add gpll0_out_aux clock Luo Jie
2025-09-02 12:11 ` Konrad Dybcio
2025-08-28 10:32 ` [PATCH v4 06/10] dt-bindings: clock: Add required "interconnect-cells" property Luo Jie
2025-08-29 7:37 ` Krzysztof Kozlowski [this message]
2025-09-02 12:56 ` Luo Jie
2025-08-28 10:32 ` [PATCH v4 07/10] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5424 SoC Luo Jie
2025-08-29 7:38 ` Krzysztof Kozlowski
2025-09-02 12:58 ` Luo Jie
2025-08-28 10:32 ` [PATCH v4 08/10] clk: qcom: Add NSS clock controller driver for IPQ5424 Luo Jie
2025-08-28 10:32 ` [PATCH v4 09/10] arm64: dts: qcom: ipq5424: Add NSS clock controller node Luo Jie
2025-08-28 10:32 ` [PATCH v4 10/10] arm64: defconfig: Build NSS clock controller driver for IPQ5424 Luo Jie
2025-08-29 7:34 ` [PATCH v4 00/10] Add Network Subsystem (NSS) clock controller support for IPQ5424 SoC Krzysztof Kozlowski
2025-09-02 13:01 ` Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250829-ubiquitous-imaginary-mammoth-d52bde@kuoka \
--to=krzysztof.kozlowski@linaro.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox