From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C45E8CA0FF0 for ; Fri, 29 Aug 2025 13:36:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PihGL1P4RBNbBsyVpq//LNp6agc4RiTkkaODgbjMY+g=; b=YCoYJxswab1ev30H1PUbjzd16j r9aCLqdSPBNdcGFYGtgWN3cyZHWK3PBPQJt5Kc0GTZET/gG6qjjgufpaMHd/nbOw2YumuJ2fdfjYM jQkze98xSbrdfWXhbj01oB+IZvuKvi6CWm4XwHFnii4VW0g9c19v26dYY/MDHU+/yjYbOOpcIs0uN S4PjoVnGKIUDpp2/i6+JJxai0iCE4/Gjx07ocmcZ0Fr0kWT8+CQb/w5WyS7zUauqbhx/K+mhnx+ld khQH38stkI9h/hmTf329aCsvgw4/eAH94pGU/vL09NZSgcpJ7uqN7GXbvv6nnLP4XReBFBGJcM8fC SyPTyvBQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urzHZ-00000005pto-2lf3; Fri, 29 Aug 2025 13:36:45 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1urwgc-00000005Nie-0Ocm for linux-arm-kernel@lists.infradead.org; Fri, 29 Aug 2025 10:50:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 49FC91BCB; Fri, 29 Aug 2025 03:50:17 -0700 (PDT) Received: from bogus (e133711.arm.com [10.1.196.55]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B42AF3F694; Fri, 29 Aug 2025 03:50:23 -0700 (PDT) Date: Fri, 29 Aug 2025 11:50:20 +0100 From: Sudeep Holla To: Peng Fan Cc: Cristian Marussi , Sudeep Holla , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , , , , Subject: Re: [PATCH v3 2/6] firmware: arm_scmi: imx: Support discovering buildinfo of MISC protocol Message-ID: <20250829-woodoo-acoustic-lynx-7ffaba@sudeepholla> References: <20250827-sm-misc-api-v1-v3-0-82c982c1815a@nxp.com> <20250827-sm-misc-api-v1-v3-2-82c982c1815a@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250827-sm-misc-api-v1-v3-2-82c982c1815a@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250829_035026_167671_0BA7B85E X-CRM114-Status: GOOD ( 17.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 27, 2025 at 12:59:14PM +0800, Peng Fan wrote: > MISC protocol supports discovering the System Manager(SM) build > information including build commit, build time and etc. Retrieve the > information from SM. > > Reviewed-by: Cristian Marussi > Signed-off-by: Peng Fan > --- > .../firmware/arm_scmi/vendors/imx/imx-sm-misc.c | 41 ++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > index a8915d3b4df518719d56bfff38922625ad9b70f6..464afeae8267d8c1eca4c4d5e008eca6d741c6ff 100644 > --- a/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > +++ b/drivers/firmware/arm_scmi/vendors/imx/imx-sm-misc.c > @@ -25,6 +25,7 @@ > enum scmi_imx_misc_protocol_cmd { > SCMI_IMX_MISC_CTRL_SET = 0x3, > SCMI_IMX_MISC_CTRL_GET = 0x4, > + SCMI_IMX_MISC_DISCOVER_BUILDINFO = 0x6, > SCMI_IMX_MISC_CTRL_NOTIFY = 0x8, > }; > > @@ -65,6 +66,15 @@ struct scmi_imx_misc_ctrl_get_out { > __le32 val[]; > }; > > +struct scmi_imx_misc_buildinfo_out { > + __le32 buildnum; > + __le32 buildcommit; > +#define MISC_MAX_BUILDDATE 16 > + u8 builddate[MISC_MAX_BUILDDATE]; > +#define MISC_MAX_BUILDTIME 16 > + u8 buildtime[MISC_MAX_BUILDTIME]; > +}; > + > static int scmi_imx_misc_attributes_get(const struct scmi_protocol_handle *ph, > struct scmi_imx_misc_info *mi) > { > @@ -272,6 +282,33 @@ static int scmi_imx_misc_ctrl_set(const struct scmi_protocol_handle *ph, > return ret; > } > > +static int scmi_imx_misc_discover_build_info(const struct scmi_protocol_handle *ph) > +{ > + char date[MISC_MAX_BUILDDATE], time[MISC_MAX_BUILDTIME]; > + struct scmi_imx_misc_buildinfo_out *out; > + struct scmi_xfer *t; > + int ret; > + > + ret = ph->xops->xfer_get_init(ph, SCMI_IMX_MISC_DISCOVER_BUILDINFO, 0, > + sizeof(*out), &t); > + if (ret) > + return ret; > + > + ret = ph->xops->do_xfer(ph, t); > + if (!ret) { > + out = t->rx.buf; > + strscpy(date, out->builddate, MISC_MAX_BUILDDATE); > + strscpy(time, out->buildtime, MISC_MAX_BUILDTIME); > + dev_info(ph->dev, "SM Version\t= Build %u, Commit %08x %s %s\n", > + le32_to_cpu(out->buildnum), le32_to_cpu(out->buildcommit), > + date, time); And fix the alignment above, just noticed after hitting enter. -- Regards, Sudeep