From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73683CA0FF9 for ; Fri, 29 Aug 2025 17:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Lx+kBNu3qEkV7prHxTjcI9oa/dRZ+TFcfCNE4xjEqho=; b=Oz/5Hxl/+z3XpysNjgvzpuvadX CpgxwD2JkK15TggYhcI4Xoq5Vk0DKzrRfGZJhsH0LpOJGO9wCC2YQDrv8+bkvOR1xrNtVA7wI90H+ KxwZXwpocYQ8V3/sqBEyAcjKe7dD0cfhuBrr8fEN2iMhYolUsnYbS/cOZef51ji4vM7nqvfNngEWP wHmbCIoegqRizzTsyuZdxFU1JjAz+0O2R6I0kU2B3+xrvNUvZ07wNGOQNRYYViY3qZUClhbkGQ6RD d+4PqKgZjxnHFkdlx9flv3QgHGDsKgf2t0vlHcAxUI24owEyuc+CBkvP2WamY1yO1ySyxXy3VBlUr c+ROMwuA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1us3Jd-00000006aJ5-3kme; Fri, 29 Aug 2025 17:55:09 +0000 Received: from mail-northeuropeazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c200::5] helo=DUZPR83CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ury7Q-00000005dK3-08u5 for linux-arm-kernel@lists.infradead.org; Fri, 29 Aug 2025 12:22:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ovwGGl9dCcCfYKpdwkTRtrSyVsYOP4MDjjjMyhYmdqxzt6C+6EeL0JuC83oudr+GpLh6V6p6mehADAy5pyt3cGKa6iUcKmkD3P8xxM64itmXooU4DnH2bEy0wNacWTM/bBCQ4OPvVaPNGGm67lKZmLfM3niFYFUcuJKdof4wIp3BQbfQQyDSDyT3sM5aqBT5QXl52KIp9xdTmgCxoNSzQFHyxfKBVWh6aLvbypYPP0NakQ2GxFVY/u9Ifawm6WXzomGPZUrhCOmQlbv5shFaWTXb8uEQtQ347plNcGTmdTSlO+SmNw13uoJoyQSltFAshKZWLaNMjXyl6xTHxBk3kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lx+kBNu3qEkV7prHxTjcI9oa/dRZ+TFcfCNE4xjEqho=; b=YQ7/E2CaMYkKuumzcPLyv9L6cAOfeDVW5Sf+Rgz0dlXV8HFBnId1+pcD1Gnon8ggvBSQD1MWJ7nSmdY1H0OmiONOi3K7sF93VDJV+e8U/z6rXKoqIPYNmdU/JFfnKiun7rsZprxnOKFL+zu9rOZsoMr9VKYhi40oblJ6CyKA/pAeGprsVS7PSTBWFoKYRDM9oDXzCaqVVNiuof+27ybmdkZCeM460+uUyHNa10dbuFzjSYztNnYOSusTzfU6jaoX5oZxobOOJs8KuHnp+fTHhVH3uXEzMpAJgq4ErNs1mrLk7c0xFeVQRaHLuasBuqtr7C6JVp8f1usgRXvLP3QVRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lx+kBNu3qEkV7prHxTjcI9oa/dRZ+TFcfCNE4xjEqho=; b=TvHQVmRYfxUflFDYff8NyS/zas27aRQQG/EllMLRrjjhpMeQ+70irlxO3BUdhevT+wtQ4WxOv/7Kw3ukutr1zT69biSnd32dJOvf7jWhiWlHLGxnMzuF1zYBcPVPdQ+9PHOuzXqWKNg+Qr/2/+Visb7isqdSnM7vN/afgT3pbe595N+PcXPvT4lx9Nwst3qDvELIFDDqQbtJ+Zu0wXMbjnOIeJIM4odrLURXoowAdcwfnPPxaBSjmH6gDmCU3CHPkuK8OBFeZZXfDaMB1s03/rfs4drYSOtzDpQ8yIJfVQK+d8UmlzdQG3ZODaSh9FtcYuZIcMxb5yF60eiftrYe7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by PA4PR04MB9637.eurprd04.prod.outlook.com (2603:10a6:102:272::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9073.10; Fri, 29 Aug 2025 12:22:04 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%7]) with mapi id 15.20.9073.010; Fri, 29 Aug 2025 12:22:04 +0000 Date: Fri, 29 Aug 2025 21:33:14 +0800 From: Peng Fan To: Sudeep Holla Cc: Brian Masney , Cristian Marussi , Michael Turquette , Stephen Boyd , arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: scmi: migrate round_rate() to determine_rate() Message-ID: <20250829133314.GA30579@nxa18884-linux.ap.freescale.net> References: <20250827-clk-scmi-round-rate-v2-1-3782a50835ed@redhat.com> <20250829100903.GB16625@nxa18884-linux.ap.freescale.net> <20250829-fine-tacky-sturgeon-0ba3c4@sudeepholla> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250829-fine-tacky-sturgeon-0ba3c4@sudeepholla> User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: MA0PR01CA0079.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a01:ae::7) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|PA4PR04MB9637:EE_ X-MS-Office365-Filtering-Correlation-Id: cabcb72e-4947-4772-29b3-08dde6f6a983 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|19092799006|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Mpq3v/jXfpq6fOgQsD3GqztpMPBZbW42IUNyk3jtyycr/3dprZmFeY3BcBPa?= =?us-ascii?Q?k2szSYAMT3FP54aq1wUuLK01BWQeyvtqYWsYBhCtLh3foSP+fVlJxnptR1Au?= =?us-ascii?Q?uFMMZSuy2y4eBYIEoBe6R5aIBvKGcu9TLcQStIA5+Odao5zKeCYSepHB4W8P?= =?us-ascii?Q?h5rYyUf3ejf/DxqHcTnyfiizGiw3oyp/ibus4K+tDhoQSvGWz3MFesvXYbXY?= =?us-ascii?Q?TziQP1psQDodzkUsNDGTnhrpWKt/TVZIXB/A71INtyRJ8B9XshZUyrq6WmT3?= =?us-ascii?Q?o4Eye+Y+jlsC9Y8m7vBwBHQLoB9osaaNk2UycaXOvHMD5BXajhRSfuj0z9Us?= =?us-ascii?Q?3gysxjP4BNZg34XSKyVviaTjqXT5OeQost6DPSzqMrDuudMBqiO1J/ZYabQi?= =?us-ascii?Q?U75dcggYTmMkaoiqPrLhztKWHjemZDsm1EmSnQy+5A7nzOZ1WdWMDQVlNvgD?= =?us-ascii?Q?yDSbRi0jNkL0jmnWuQdI3n3c0vMFguDguXoyQ8E1pTNI6jJv0fZQRhvCqMmH?= =?us-ascii?Q?byRSNkkhTh9PerlEIXoBaJe7lgD1bOMf0suFcaJ7CgouZT+H6UVM10yJVbhL?= =?us-ascii?Q?PAdGeqB4lZlYXIWY2ZOOPuJe74z7B1Kd+4kSZeNIlda4qmAMc5O85me4B+DW?= =?us-ascii?Q?YzCZ80kRUzOQmQ39gyMXUjfBDm69294XJa8SBuNVBFr4b734W14mH4WVQZcl?= =?us-ascii?Q?EGApCf9sytvxsuLgGrStWyPywhgaPwU6miSYTA04NIDsIoAoOTlZryG1/NcX?= =?us-ascii?Q?91tmucwjwF4cI+RBLGL4vxF/uCaZjABwXT1qJUvH0M7ZocUROyRWd+lN7vTz?= =?us-ascii?Q?A6yHK6wEy+q9pf3jB0m0SgG8j1bIq3+tL3J//ukZAHV3Ltvg3Tssxntjh/BA?= =?us-ascii?Q?aGpYwobtB1ZT+hzRrGpdVPDvGJfkiy4EQ3HVWOQHI7rtVuS/Qm5Us4IPcTaf?= =?us-ascii?Q?3UuLlSyIP1duoSHAivProTivpGleWeDENmqklZVFqyiOBzB+B90EZBMVN6HP?= =?us-ascii?Q?FNYBjkzPDrlXCgb1HhFpX7QdIbE6S6YYxNBIbjCFDHiD9FjzMMILr+FWeqSw?= =?us-ascii?Q?TOf1i6Ojgp279BxXuLCHrrYm+374kenxJRRBm1zu30s9Wb6ZNt3cKV9dY69g?= =?us-ascii?Q?EWkWzlG6EZdN1f25zgWn1ARqiIAAtCc+QhuJEFQzJiPa6e4qdPskilZy6qWs?= =?us-ascii?Q?DUYE3POCaYKdRJEZ9ga3ucm8Mo74fDZKoxq++fVTdX/+wSnSElez2OP007Wf?= =?us-ascii?Q?QUm7qNKFHWJkr3NBgapxKZxJPlZf7ZweT/7kJKfMMYGRJhLpMr+nQUIa2d3G?= =?us-ascii?Q?unm7oZbvFpN76tAJg7vOuew/xrudeG+PRsqFy5SMBsIRA8ykLSznnnr2cBxX?= =?us-ascii?Q?K/uUjXDItGpnGyY7e0bWCm869SHQGDMJRpa5n3cbjK9FTZCs+oIUfgSNhzQk?= =?us-ascii?Q?V8NO2H3b2Xf3kgmMNn9BTOrZ3mwCwT1jPD4qJWp+c4+Uvxx6hjqNAQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(19092799006)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MciZzCXg6HmTrR1w8BMVpBwC0OaR4NQWXcFgXG4u+Mlh1Uxjr0IMgTpb++co?= =?us-ascii?Q?LerU1e/OK2j9CE8ucBEZwuX1g4PNB/CxCm+uv6ukS9V7HeRyGso0mzR8kIVY?= =?us-ascii?Q?0KUwgFUT0jG3Ga7HoCC8Hb829/TYldDxBvb4iuh56/2H+G4T96a8GWrHmmxi?= =?us-ascii?Q?hBmatoSiG8VWJXBdDAZbDRtnks44oA81Lj2l0ZmlpjxbWTfRe/gp+qFJlA8B?= =?us-ascii?Q?1omyQctEROSSZag7UJvMpjMlFK4otdoxTs/YUHaW1WwvsItRh3Uf64GIx/At?= =?us-ascii?Q?7utjxJ+f2ooRfVP4cAwu/Z+p1t7QxP5SizFCCRirxJ2/IsKxurthh3djVe2g?= =?us-ascii?Q?sYLVmWzFqFQOwcIWrxXISxnaNasaIFjdXGzyyEl4HEtz3k/mMYrl68btpK7V?= =?us-ascii?Q?ATKU6jKgi+gh3mxnckUxokM9jY3w4IjkIabxl9WTL1SiGMRkTIhWpoYqF/UO?= =?us-ascii?Q?xt1bhfPTx2tgxugElwCTTzx2dWbKLrr3msKSVACWWIAxzgEoSLSPO6ATGCTn?= =?us-ascii?Q?E7tjesw+6eYezdEARX84VRzX7YQeoH/1xMSXmClFDhbXXXL89kq4P8a61Zhv?= =?us-ascii?Q?HoQWQ5i/QaaHyVLMV0BeyIUz5io6cmwThUn1WhJi3KqoAUy+2ao2NkkQ1oTz?= =?us-ascii?Q?pBVkdEtgJ4iwciJsE6M767G6osM7J5GldIROIYYlu5E4GCdAoDZjhsc/mKCg?= =?us-ascii?Q?nNl0A9qxFPupVZOHaZqbv9kHGYXn1/Zgs/9jzeKdEDomAgcX6sUIbgTaDPyp?= =?us-ascii?Q?4BJxNFSwlAVTVMC34BLcmEerskI1YN4Nj6uABOCPs5hYDE5R0HzCAJZMBAzk?= =?us-ascii?Q?IKzstPHFj1k2E+09FUzfw3J7vph2mEfoFeMV+7NslUzoEwqdCJMG5xntb/0a?= =?us-ascii?Q?rlzpqEAvTFmpoV4s1S6rIbaTIlb9AUgYHCSeGqUPdIhX8uVkU2a6Vtez+xxL?= =?us-ascii?Q?nrYkMayssxZLez/IBFET9mSRMM2s3IZh8DiJi0AbrcDtX8O8wdli9h2H+Pe0?= =?us-ascii?Q?vrt+mywDn5AQ98aQ5pZQT93cffDV3UKQ4AyJbTViWuiETmMDOqTVEzVTXUUO?= =?us-ascii?Q?kFUA5BtZ/oim3xF7pBnVQ2Mg9eUmFciVzS/bcdoHT/nNVNGEMiqQJmDpSr7X?= =?us-ascii?Q?McmaaUhW5XNb7gi/FzPrlxtOef4CsOCAcjtBcQl1GZqGlZqEYWwkN1oAAvMr?= =?us-ascii?Q?cLoXy+0iNwZzu6Nvi6gHhcacH4VR9Rpn/v7YdMooWJlq+FFMImibIMbSPQtH?= =?us-ascii?Q?FUEfNIyXPaGNaXlMQaDoq6odkeFfrHTdd+XRyV/oMJ28KJ0rNOSob0FNPD0j?= =?us-ascii?Q?VFm+cILlX2X8kqNBInpOrPpnA7+mBd42EIsejC/L/MqsocyclzWUBAVtRQii?= =?us-ascii?Q?1Zi9Y2+LXTKAbnWPaKlcDbGL+kIox8rSf5V9pZYFY+/n8zbnr2gFtux5JvIv?= =?us-ascii?Q?HCg500RgPmvPX4J1QctlXf8WazEZ/IS7hidm86z9VvfJNfqQCrXitGyLNw29?= =?us-ascii?Q?peOI4GjH78Y1E1vFQMlMpaJf8xZrjsi6+URoIj7o/TNTaNfJ7hsP5guxJbou?= =?us-ascii?Q?9N2CDmnJx62/MUhM7ADV2kiAPSfvUUr8DZsiwoPA?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: cabcb72e-4947-4772-29b3-08dde6f6a983 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2025 12:22:04.0648 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8cl00MX69RYtritC00xcSw59jI4rP/+9haVJb6uUESiqWJooaaHChlfs7JO82Bf4XkIF1E1OtobLMn4yIG8GZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9637 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250829_052212_082881_F75D13FA X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 29, 2025 at 10:59:15AM +0100, Sudeep Holla wrote: >On Fri, Aug 29, 2025 at 06:09:03PM +0800, Peng Fan wrote: >> On Wed, Aug 27, 2025 at 01:12:07PM -0400, Brian Masney wrote: >> >This driver implements both the determine_rate() and round_rate() clk >> >ops, and the round_rate() clk ops is deprecated. When both are defined, >> >clk_core_determine_round_nolock() from the clk core will only use the >> >determine_rate() clk ops. >> > >> >The existing scmi_clk_determine_rate() is a noop implementation that >> >lets the firmware round the rate as appropriate. Drop the existing >> >determine_rate implementation and convert the existing round_rate() >> >implementation over to determine_rate(). >> > >> >scmi_clk_determine_rate() was added recently when the clock parent >> >support was added, so it's not expected that this change will regress >> >anything. >> > >> >Signed-off-by: Brian Masney >> >> Reviewed-by: Peng Fan > >Peng, > >It would be great if you can test it with parent clock support on i.MX >platforms just to be sure this doesn't regress anything. Just gave a test on i.MX95-EVK, it boots well and eth0 works, the results in /sys/kernel/debug/clk/clk_summary also looks correct. Tested-by: Peng Fan #i.MX95-19x19-EVK Regards Peng > >-- >Regards, >Sudeep