From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7876ACA1002 for ; Mon, 1 Sep 2025 23:12:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=QFlj6LeYeVXuLBI0PnR72/5EffcGcDPd5XwN7nEIac0=; b=4Qx1TF6KUDIo5rtiA6tYGZl7Ex XDXoinw9zsrFmd/voQcN1jY8O+5cOMmzG4IdU9iXkFPriso6AZ8ylkyJ0nqYt3baOk38Vj1DjdDjR bg3ZmANu4U/I3KifOuNDxtcWG8XggNYQkv7Hq92E9loKDlmst6CZMdkbTFK7Yt6AyLfGtdz3tW5qy t9g8bmOyp4ICHjUlmHtu0JHM7Fe+9iZ0yMnoFY3xeabRddOTec1ztp69vE1Gv+LNIx5yANbnAcMGf kFvyHveak9VmaS8995iBXFcoHL+ydQUT7oAJ25sgPRLjcc1E/1P/Qie2XU7WTdBUz7lx2o1TqbWaE rasfevBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1utDgz-0000000EDtd-2uuh; Mon, 01 Sep 2025 23:12:05 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ut6aX-0000000D8Dg-0amv for linux-arm-kernel@lists.infradead.org; Mon, 01 Sep 2025 15:36:58 +0000 Received: from pendragon.ideasonboard.com (230.215-178-91.adsl-dyn.isp.belgacom.be [91.178.215.230]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 4DAADB63; Mon, 1 Sep 2025 17:35:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1756740945; bh=JG/FmgDIqDX7Pla+FvRtTebcB0C0aiOljtqjKTBfLkI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EKiXZZw+1L6xfHznEGef9KgZOxr+v2EfyaEghsc+nhd3PwhWKlq+dfiA9Z/qY9w5j uFUEQ3zSgaQAGjEGOIaQx0RGoQO2LE1kQZBl3JhHsYwhbaWvOz6HmNQnQy8aaqoP51 w3N3wDxa0jrMGM/kPZ6JX3/ozGtYUUHBC4/lLFNY= Date: Mon, 1 Sep 2025 17:36:32 +0200 From: Laurent Pinchart To: Guoniu Zhou Cc: Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Philipp Zabel , Frank Li , linux-media@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 3/4] media: imx8mq-mipi-csi2: Explicitly release reset Message-ID: <20250901153632.GA13448@pendragon.ideasonboard.com> References: <20250901-csi2_imx8ulp-v5-0-67964d1471f3@nxp.com> <20250901-csi2_imx8ulp-v5-3-67964d1471f3@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250901-csi2_imx8ulp-v5-3-67964d1471f3@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250901_083657_311102_C091EF5E X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Guoniu, Thank you for the patch. On Mon, Sep 01, 2025 at 02:25:31PM +0800, Guoniu Zhou wrote: > Call reset_control_deassert() to explicitly release reset to make sure > reset bits are cleared since platform like i.MX8ULP can't clear reset > bits automatically. > > Reviewed-by: Frank Li > Signed-off-by: Guoniu Zhou > --- > drivers/media/platform/nxp/imx8mq-mipi-csi2.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > index 2bf11984690af2e687a3217e465697333d9d995d..6b83aa85af42e1dac25cf29056863680c1f89402 100644 > --- a/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > +++ b/drivers/media/platform/nxp/imx8mq-mipi-csi2.c > @@ -337,18 +337,14 @@ static int imx8mq_mipi_csi_sw_reset(struct csi_state *state) > { > int ret; > > - /* > - * these are most likely self-clearing reset bits. to make it > - * more clear, the reset-imx7 driver should implement the > - * .reset() operation. What happened to this plan, would it be feasible to implement the .reset() operation in the relevant drivers to be able to use reset_control_reset() here ? > - */ > ret = reset_control_assert(state->rst); > if (ret < 0) { > dev_err(state->dev, "Failed to assert resets: %d\n", ret); > return ret; > } > > - return 0; > + /* Explicitly release reset to make sure reset bits are cleared. */ > + return reset_control_deassert(state->rst); > } > > static void imx8mq_mipi_csi_set_params(struct csi_state *state) -- Regards, Laurent Pinchart