From: Sudeep Holla <sudeep.holla@arm.com>
To: Artem Shimko <artyom.shimko@gmail.com>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
arm-scmi@vger.kernel.org, Sudeep Holla <sudeep.holla@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation
Date: Tue, 2 Sep 2025 10:27:11 +0100 [thread overview]
Message-ID: <20250902-daft-pompous-angelfish-459c6e@sudeepholla> (raw)
In-Reply-To: <20250901161207.2501078-3-artyom.shimko@gmail.com>
On Mon, Sep 01, 2025 at 07:12:04PM +0300, Artem Shimko wrote:
> Adds a missing comment for xfer_lock spinlock in struct scmi_xfers_info.
> The spinlock protects access to the xfer buffers and transfer allocation
> mechanism, preventing race conditions in concurrent access scenarios.
>
> Signed-off-by: Artem Shimko <artyom.shimko@gmail.com>
> ---
> drivers/firmware/arm_scmi/driver.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index bd56a877fdfc..6828392152f4 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -76,6 +76,7 @@ static struct dentry *scmi_top_dentry;
> */
> struct scmi_xfers_info {
> unsigned long *xfer_alloc_table;
> + /* Protects access to the xfer buffers */
Thanks for your patch but this is quite obvious and I see no point in
just adding this comment.
--
Regards,
Sudeep
next prev parent reply other threads:[~2025-09-02 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 16:12 [PATCH 0/2] firmware: arm_scmi: Minor cleanups and documentation fixes Artem Shimko
2025-09-01 16:12 ` [PATCH 1/2] firmware: arm_scmi: fix alignment in protocol_id_show and debugfs calls Artem Shimko
2025-09-01 16:12 ` [PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation Artem Shimko
2025-09-02 9:27 ` Sudeep Holla [this message]
2025-09-05 23:44 ` Artem Shimko
-- strict thread matches above, loose matches on Subject: below --
2025-09-01 16:32 [PATCH 0/2] Subject: [PATCH v2 0/2] firmware: arm_scmi: Minor cleanups and documentation fixes Artem Shimko
2025-09-01 16:33 ` [PATCH 2/2] firmware: arm_scmi: add missing spinlock documentation Artem Shimko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250902-daft-pompous-angelfish-459c6e@sudeepholla \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=artyom.shimko@gmail.com \
--cc=cristian.marussi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox