[PATCH] bus: vexpress-config: fix device node reference leak in vexpress_syscfg_probe

[PATCH] bus: vexpress-config: fix device node reference leak in vexpress_syscfg_probe

[Miaoqian Lin]

Add missing of_node_put() call to release
the device node reference obtained via of_parse_phandle().

Since we don't actually use the node, decrement the
reference count immediately after obtaining it.

Fixes: a5a38765ac79 ("bus: vexpress-config: simplify config bus probing")
Cc: stable@vger.kernel.org
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 drivers/bus/vexpress-config.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index 64ee920721ee..aa17f819dfc9 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -393,6 +393,7 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
 		struct device_node *bridge_np;
 
 		bridge_np = of_parse_phandle(node, "arm,vexpress,config-bridge", 0);
+		of_node_put(bridge_np);
 		if (bridge_np != pdev->dev.parent->of_node)
 			continue;
 
-- 
2.35.1

Re: [PATCH] bus: vexpress-config: fix device node reference leak in vexpress_syscfg_probe

[Markus Elfring]

> Add missing of_node_put() call to release
> the device node reference obtained via of_parse_phandle().
…

You may occasionally put more than 58 characters into text lines
of such a change description.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc4#n638

Regards,
Markus