From: Conor Dooley <conor@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>,
Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Aswath Govindraju <a-govindraju@ti.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>, Frank Li <frank.li@nxp.com>,
Bough Chen <haibo.chen@nxp.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
"linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 1/6] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048
Date: Wed, 3 Sep 2025 17:25:54 +0100 [thread overview]
Message-ID: <20250903-subwoofer-anyone-bc7aa007927a@spud> (raw)
In-Reply-To: <PAXPR04MB845903CF3D03A436925150238801A@PAXPR04MB8459.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]
On Wed, Sep 03, 2025 at 06:49:47AM +0000, Peng Fan wrote:
> > Subject: RE: [PATCH v4 1/6] dt-bindings: phy: ti,tcan104x-can:
> > Document NXP TJA105X/1048
> >
> ...
> >
> > Thanks again for the detailed reading into datasheet.
> >
> > Yes. But I would like to only keep one compatible "nxp,tja1051" from a
> > board design level, EN could be always tied to high for TJA1051T/E. So
> > to dt-binding, EN it is optional for all TJA1051 variants.
> >
> > I am thinking to use below compatible in V4 for the devices added in
> > this patch. Does this look good to you?
> >
> > - items:
> > - const: nxp,tja1057
> > - const: nxp,tja1051
> > - enum:
> > ....
> > - nxp,tja1048
> > - nxp,tja1051
>
> Considering TJA1057 does not have EN, I may need to use:
> - enum:
> ....
> - nxp,tja1048
> - nxp,tja1051
> - nxp,tja1057
> ....
Seems reasonable to me, go for it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2025-09-03 21:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 3:18 [PATCH v4 0/6] phy: phy-can-transceiver: Support TJA1048/TJA1051 Peng Fan
2025-09-01 3:18 ` [PATCH v4 1/6] dt-bindings: phy: ti,tcan104x-can: Document NXP TJA105X/1048 Peng Fan
2025-09-01 18:54 ` Conor Dooley
2025-09-01 19:00 ` Conor Dooley
2025-09-02 2:24 ` Peng Fan
2025-09-02 19:31 ` Conor Dooley
2025-09-03 6:00 ` Peng Fan
2025-09-03 6:49 ` Peng Fan
2025-09-03 16:25 ` Conor Dooley [this message]
2025-09-01 3:18 ` [PATCH v4 2/6] phy: phy-can-transceiver: Introduce can_transceiver_priv Peng Fan
2025-09-01 3:18 ` [PATCH v4 3/6] phy: phy-can-transceiver: Add dual channel support for TJA1048 Peng Fan
2025-09-01 3:18 ` [PATCH v4 4/6] arm64: dts: imx95-15x15-evk: Use phys to replace xceiver-supply Peng Fan
2025-09-01 3:18 ` [PATCH v4 5/6] arm64: dts: imx8mp-evk: " Peng Fan
2025-09-01 3:18 ` [PATCH v4 6/6] arm64: dts: imx93-11x11-evk: " Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250903-subwoofer-anyone-bc7aa007927a@spud \
--to=conor@kernel.org \
--cc=a-govindraju@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=haibo.chen@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox