From: Jakub Kicinski <kuba@kernel.org>
To: Conley Lee <conleylee@foxmail.com>
Cc: davem@davemloft.net, wens@csie.org, mripard@kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: sun4i-emac: free dma descriptor
Date: Thu, 4 Sep 2025 07:24:46 -0700 [thread overview]
Message-ID: <20250904072446.5563130d@kernel.org> (raw)
In-Reply-To: <tencent_160BBED8A83CECDE110A344B51B6229B1209@qq.com>
On Wed, 3 Sep 2025 15:49:39 +0800 Conley Lee wrote:
> In the current implementation of the sun4i-emac driver, when using DMA to
> receive data packets, the descriptor for the current DMA request is not
> released in the rx_done_callback.
>
> Fix this by properly releasing the descriptor.
Reading the docs, it appears that the need to free the desc is tied to
setting descriptor reuse flag. Which this driver does not do. So I'm
unclear why this is needed, maybe the dma engine driver is doing
something strange?
Could you repost this, CC the dmaengine ML, Vinod and the appropriate
SoC maintainers?
next prev parent reply other threads:[~2025-09-04 19:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-30 7:49 [PATCH 1/2] net: ethernet: sun4i-emac: free dma desc Conley Lee
2025-09-02 22:57 ` Jakub Kicinski
2025-09-03 7:49 ` [PATCH] net: ethernet: sun4i-emac: free dma descriptor Conley Lee
2025-09-04 14:24 ` Jakub Kicinski [this message]
2025-09-07 11:29 ` Conley Lee
2025-09-08 20:26 ` Jakub Kicinski
2025-09-09 6:36 ` 李克斯
2025-09-10 1:15 ` Jakub Kicinski
2025-09-10 10:42 ` Conley Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904072446.5563130d@kernel.org \
--to=kuba@kernel.org \
--cc=conleylee@foxmail.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).